Sign upLogin

brandon14/ebay-sdk-php

View on GitHub
Star
src/Sell/Marketing/V1/Api/AdReportTaskApi.php

Summary

Maintainability
F
1 wk
Test Coverage

File AdReportTaskApi.php has 648 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * This file is part of the trollandtoad/ebay-sdk-php package.
 *
Severity: Major
Found in src/Sell/Marketing/V1/Api/AdReportTaskApi.php - About 1 day to fix

    Function createReportTaskRequest has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

        public function createReportTaskRequest($create_report_task)
    {
        // Verify the required parameter 'create_report_task' is set.
        if ($create_report_task === null || (\is_array($create_report_task) && count($create_report_task) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $create_report_task when calling createReportTask');
    Severity: Minor
    Found in src/Sell/Marketing/V1/Api/AdReportTaskApi.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getReportTasksRequest has 78 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getReportTasksRequest($limit = null, $offset = null, $report_task_statuses = null)
    {
        $resourcePath = '/ad_report_task';
        $formParams = [];
        $queryParams = [];
    Severity: Major
    Found in src/Sell/Marketing/V1/Api/AdReportTaskApi.php - About 3 hrs to fix

      Function deleteReportTaskRequest has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
      Open

          public function deleteReportTaskRequest($report_task_id)
    {
        // Verify the required parameter 'report_task_id' is set.
        if ($report_task_id === null || (\is_array($report_task_id) && count($report_task_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $report_task_id when calling deleteReportTask');
      Severity: Minor
      Found in src/Sell/Marketing/V1/Api/AdReportTaskApi.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getReportTaskRequest has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getReportTaskRequest($report_task_id)
    {
        // Verify the required parameter 'report_task_id' is set.
        if ($report_task_id === null || (\is_array($report_task_id) && count($report_task_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $report_task_id when calling getReportTask');
      Severity: Minor
      Found in src/Sell/Marketing/V1/Api/AdReportTaskApi.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      AdReportTaskApi has 25 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class AdReportTaskApi
{
    /**
     * @var ClientInterface
     */
      Severity: Minor
      Found in src/Sell/Marketing/V1/Api/AdReportTaskApi.php - About 2 hrs to fix

        Method deleteReportTaskRequest has 67 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function deleteReportTaskRequest($report_task_id)
    {
        // Verify the required parameter 'report_task_id' is set.
        if ($report_task_id === null || (\is_array($report_task_id) && count($report_task_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $report_task_id when calling deleteReportTask');
        Severity: Major
        Found in src/Sell/Marketing/V1/Api/AdReportTaskApi.php - About 2 hrs to fix

          Method getReportTaskRequest has 67 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getReportTaskRequest($report_task_id)
    {
        // Verify the required parameter 'report_task_id' is set.
        if ($report_task_id === null || (\is_array($report_task_id) && count($report_task_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $report_task_id when calling getReportTask');
          Severity: Major
          Found in src/Sell/Marketing/V1/Api/AdReportTaskApi.php - About 2 hrs to fix

            Method createReportTaskRequest has 66 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function createReportTaskRequest($create_report_task)
    {
        // Verify the required parameter 'create_report_task' is set.
        if ($create_report_task === null || (\is_array($create_report_task) && count($create_report_task) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $create_report_task when calling createReportTask');
            Severity: Major
            Found in src/Sell/Marketing/V1/Api/AdReportTaskApi.php - About 2 hrs to fix

              Function getReportTasksRequest has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getReportTasksRequest($limit = null, $offset = null, $report_task_statuses = null)
    {
        $resourcePath = '/ad_report_task';
        $formParams = [];
        $queryParams = [];
              Severity: Minor
              Found in src/Sell/Marketing/V1/Api/AdReportTaskApi.php - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method getReportTaskWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function getReportTaskWithHttpInfo($report_task_id)
    {
        $request = $this->getReportTaskRequest($report_task_id);

        try {
              Severity: Major
              Found in src/Sell/Marketing/V1/Api/AdReportTaskApi.php - About 2 hrs to fix

                Method getReportTasksWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function getReportTasksWithHttpInfo($limit = null, $offset = null, $report_task_statuses = null)
    {
        $request = $this->getReportTasksRequest($limit, $offset, $report_task_statuses);

        try {
                Severity: Major
                Found in src/Sell/Marketing/V1/Api/AdReportTaskApi.php - About 2 hrs to fix

                  Function getReportTasksWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function getReportTasksWithHttpInfo($limit = null, $offset = null, $report_task_statuses = null)
    {
        $request = $this->getReportTasksRequest($limit, $offset, $report_task_statuses);

        try {
                  Severity: Minor
                  Found in src/Sell/Marketing/V1/Api/AdReportTaskApi.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function getReportTaskWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function getReportTaskWithHttpInfo($report_task_id)
    {
        $request = $this->getReportTaskRequest($report_task_id);

        try {
                  Severity: Minor
                  Found in src/Sell/Marketing/V1/Api/AdReportTaskApi.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function createReportTaskWithHttpInfo has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function createReportTaskWithHttpInfo($create_report_task)
    {
        $request = $this->createReportTaskRequest($create_report_task);

        try {
                  Severity: Minor
                  Found in src/Sell/Marketing/V1/Api/AdReportTaskApi.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function deleteReportTaskWithHttpInfo has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function deleteReportTaskWithHttpInfo($report_task_id)
    {
        $request = $this->deleteReportTaskRequest($report_task_id);

        try {
                  Severity: Minor
                  Found in src/Sell/Marketing/V1/Api/AdReportTaskApi.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function getReportTasksRequest($limit = null, $offset = null, $report_task_statuses = null)
    {
        $resourcePath = '/ad_report_task';
        $formParams = [];
        $queryParams = [];
                  Severity: Major
                  Found in src/Sell/Marketing/V1/Api/AdReportTaskApi.php and 1 other location - About 3 days to fix
                  src/Sell/Marketing/V1/Api/CampaignApi.php on lines 1241..1339

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 582.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function getReportTasksWithHttpInfo($limit = null, $offset = null, $report_task_statuses = null)
    {
        $request = $this->getReportTasksRequest($limit, $offset, $report_task_statuses);

        try {
                  Severity: Major
                  Found in src/Sell/Marketing/V1/Api/AdReportTaskApi.php and 1 other location - About 2 days to fix
                  src/Sell/Marketing/V1/Api/CampaignApi.php on lines 1101..1166

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 549.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function getReportTasksAsyncWithHttpInfo($limit = null, $offset = null, $report_task_statuses = null)
    {
        $returnType = '\TNT\Ebay\Sell\Marketing\V1\Model\ReportTaskPagedCollection';
        $request = $this->getReportTasksRequest($limit, $offset, $report_task_statuses);
                  Severity: Major
                  Found in src/Sell/Marketing/V1/Api/AdReportTaskApi.php and 1 other location - About 1 day to fix
                  src/Sell/Marketing/V1/Api/CampaignApi.php on lines 1200..1228

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 253.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status