Sign upLogin

brandon14/ebay-sdk-php

View on GitHub
Star
src/Sell/Marketing/V1/Api/ItemPromotionApi.php

Summary

Maintainability
F
1 mo
Test Coverage

File ItemPromotionApi.php has 681 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * This file is part of the trollandtoad/ebay-sdk-php package.
 *
Severity: Major
Found in src/Sell/Marketing/V1/Api/ItemPromotionApi.php - About 1 day to fix

    Function updateItemPromotionRequest has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
    Open

        public function updateItemPromotionRequest($promotion_id, $item_promotion = null)
    {
        // Verify the required parameter 'promotion_id' is set.
        if ($promotion_id === null || (\is_array($promotion_id) && count($promotion_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $promotion_id when calling updateItemPromotion');
    Severity: Minor
    Found in src/Sell/Marketing/V1/Api/ItemPromotionApi.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method updateItemPromotionRequest has 73 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function updateItemPromotionRequest($promotion_id, $item_promotion = null)
    {
        // Verify the required parameter 'promotion_id' is set.
        if ($promotion_id === null || (\is_array($promotion_id) && count($promotion_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $promotion_id when calling updateItemPromotion');
    Severity: Major
    Found in src/Sell/Marketing/V1/Api/ItemPromotionApi.php - About 2 hrs to fix

      Function deleteItemPromotionRequest has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
      Open

          public function deleteItemPromotionRequest($promotion_id)
    {
        // Verify the required parameter 'promotion_id' is set.
        if ($promotion_id === null || (\is_array($promotion_id) && count($promotion_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $promotion_id when calling deleteItemPromotion');
      Severity: Minor
      Found in src/Sell/Marketing/V1/Api/ItemPromotionApi.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getItemPromotionRequest has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getItemPromotionRequest($promotion_id)
    {
        // Verify the required parameter 'promotion_id' is set.
        if ($promotion_id === null || (\is_array($promotion_id) && count($promotion_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $promotion_id when calling getItemPromotion');
      Severity: Minor
      Found in src/Sell/Marketing/V1/Api/ItemPromotionApi.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function createItemPromotionRequest has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
      Open

          public function createItemPromotionRequest($item_promotion = null)
    {
        $resourcePath = '/item_promotion';
        $formParams = [];
        $queryParams = [];
      Severity: Minor
      Found in src/Sell/Marketing/V1/Api/ItemPromotionApi.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      ItemPromotionApi has 25 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class ItemPromotionApi
{
    /**
     * @var ClientInterface
     */
      Severity: Minor
      Found in src/Sell/Marketing/V1/Api/ItemPromotionApi.php - About 2 hrs to fix

        Method deleteItemPromotionRequest has 67 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function deleteItemPromotionRequest($promotion_id)
    {
        // Verify the required parameter 'promotion_id' is set.
        if ($promotion_id === null || (\is_array($promotion_id) && count($promotion_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $promotion_id when calling deleteItemPromotion');
        Severity: Major
        Found in src/Sell/Marketing/V1/Api/ItemPromotionApi.php - About 2 hrs to fix

          Method getItemPromotionRequest has 67 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getItemPromotionRequest($promotion_id)
    {
        // Verify the required parameter 'promotion_id' is set.
        if ($promotion_id === null || (\is_array($promotion_id) && count($promotion_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $promotion_id when calling getItemPromotion');
          Severity: Major
          Found in src/Sell/Marketing/V1/Api/ItemPromotionApi.php - About 2 hrs to fix

            Method createItemPromotionRequest has 63 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function createItemPromotionRequest($item_promotion = null)
    {
        $resourcePath = '/item_promotion';
        $formParams = [];
        $queryParams = [];
            Severity: Major
            Found in src/Sell/Marketing/V1/Api/ItemPromotionApi.php - About 2 hrs to fix

              Method getItemPromotionWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function getItemPromotionWithHttpInfo($promotion_id)
    {
        $request = $this->getItemPromotionRequest($promotion_id);

        try {
              Severity: Major
              Found in src/Sell/Marketing/V1/Api/ItemPromotionApi.php - About 2 hrs to fix

                Method createItemPromotionWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function createItemPromotionWithHttpInfo($item_promotion = null)
    {
        $request = $this->createItemPromotionRequest($item_promotion);

        try {
                Severity: Major
                Found in src/Sell/Marketing/V1/Api/ItemPromotionApi.php - About 2 hrs to fix

                  Method updateItemPromotionWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function updateItemPromotionWithHttpInfo($promotion_id, $item_promotion = null)
    {
        $request = $this->updateItemPromotionRequest($promotion_id, $item_promotion);

        try {
                  Severity: Major
                  Found in src/Sell/Marketing/V1/Api/ItemPromotionApi.php - About 2 hrs to fix

                    Function createItemPromotionWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function createItemPromotionWithHttpInfo($item_promotion = null)
    {
        $request = $this->createItemPromotionRequest($item_promotion);

        try {
                    Severity: Minor
                    Found in src/Sell/Marketing/V1/Api/ItemPromotionApi.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function getItemPromotionWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function getItemPromotionWithHttpInfo($promotion_id)
    {
        $request = $this->getItemPromotionRequest($promotion_id);

        try {
                    Severity: Minor
                    Found in src/Sell/Marketing/V1/Api/ItemPromotionApi.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function updateItemPromotionWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function updateItemPromotionWithHttpInfo($promotion_id, $item_promotion = null)
    {
        $request = $this->updateItemPromotionRequest($promotion_id, $item_promotion);

        try {
                    Severity: Minor
                    Found in src/Sell/Marketing/V1/Api/ItemPromotionApi.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function deleteItemPromotionWithHttpInfo has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function deleteItemPromotionWithHttpInfo($promotion_id)
    {
        $request = $this->deleteItemPromotionRequest($promotion_id);

        try {
                    Severity: Minor
                    Found in src/Sell/Marketing/V1/Api/ItemPromotionApi.php - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    <?php

/**
 * This file is part of the trollandtoad/ebay-sdk-php package.
 *
                    Severity: Major
                    Found in src/Sell/Marketing/V1/Api/ItemPromotionApi.php and 1 other location - About 1 mo to fix
                    src/Sell/Marketing/V1/Api/ItemPriceMarkdownApi.php on lines 1..1129

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 5418.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status