File NegativeKeywordApi.php
has 1042 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* This file is part of the trollandtoad/ebay-sdk-php package.
*
NegativeKeywordApi
has 35 functions (exceeds 20 allowed). Consider refactoring. Open
class NegativeKeywordApi
{
/**
* @var ClientInterface
*/
Function updateNegativeKeywordRequest
has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring. Open
public function updateNegativeKeywordRequest($negative_keyword_id, $update_negative_keyword_request)
{
// Verify the required parameter 'negative_keyword_id' is set.
if ($negative_keyword_id === null || (\is_array($negative_keyword_id) && count($negative_keyword_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $negative_keyword_id when calling updateNegativeKeyword');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getNegativeKeywordsRequest
has 92 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getNegativeKeywordsRequest($ad_group_ids = null, $campaign_ids = null, $limit = null, $negative_keyword_status = null, $offset = null)
{
$resourcePath = '/negative_keyword';
$formParams = [];
$queryParams = [];
Function createNegativeKeywordRequest
has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring. Open
public function createNegativeKeywordRequest($create_negative_keyword_request)
{
// Verify the required parameter 'create_negative_keyword_request' is set.
if ($create_negative_keyword_request === null || (\is_array($create_negative_keyword_request) && count($create_negative_keyword_request) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $create_negative_keyword_request when calling createNegativeKeyword');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function bulkUpdateNegativeKeywordRequest
has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring. Open
public function bulkUpdateNegativeKeywordRequest($bulk_update_negative_keyword_request)
{
// Verify the required parameter 'bulk_update_negative_keyword_request' is set.
if ($bulk_update_negative_keyword_request === null || (\is_array($bulk_update_negative_keyword_request) && count($bulk_update_negative_keyword_request) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $bulk_update_negative_keyword_request when calling bulkUpdateNegativeKeyword');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function bulkCreateNegativeKeywordRequest
has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring. Open
public function bulkCreateNegativeKeywordRequest($bulk_create_negative_keyword_request)
{
// Verify the required parameter 'bulk_create_negative_keyword_request' is set.
if ($bulk_create_negative_keyword_request === null || (\is_array($bulk_create_negative_keyword_request) && count($bulk_create_negative_keyword_request) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $bulk_create_negative_keyword_request when calling bulkCreateNegativeKeyword');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method updateNegativeKeywordRequest
has 76 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function updateNegativeKeywordRequest($negative_keyword_id, $update_negative_keyword_request)
{
// Verify the required parameter 'negative_keyword_id' is set.
if ($negative_keyword_id === null || (\is_array($negative_keyword_id) && count($negative_keyword_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $negative_keyword_id when calling updateNegativeKeyword');
Function getNegativeKeywordRequest
has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring. Open
public function getNegativeKeywordRequest($negative_keyword_id)
{
// Verify the required parameter 'negative_keyword_id' is set.
if ($negative_keyword_id === null || (\is_array($negative_keyword_id) && count($negative_keyword_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $negative_keyword_id when calling getNegativeKeyword');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getNegativeKeywordRequest
has 67 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getNegativeKeywordRequest($negative_keyword_id)
{
// Verify the required parameter 'negative_keyword_id' is set.
if ($negative_keyword_id === null || (\is_array($negative_keyword_id) && count($negative_keyword_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $negative_keyword_id when calling getNegativeKeyword');
Method bulkUpdateNegativeKeywordRequest
has 66 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function bulkUpdateNegativeKeywordRequest($bulk_update_negative_keyword_request)
{
// Verify the required parameter 'bulk_update_negative_keyword_request' is set.
if ($bulk_update_negative_keyword_request === null || (\is_array($bulk_update_negative_keyword_request) && count($bulk_update_negative_keyword_request) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $bulk_update_negative_keyword_request when calling bulkUpdateNegativeKeyword');
Method createNegativeKeywordRequest
has 66 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function createNegativeKeywordRequest($create_negative_keyword_request)
{
// Verify the required parameter 'create_negative_keyword_request' is set.
if ($create_negative_keyword_request === null || (\is_array($create_negative_keyword_request) && count($create_negative_keyword_request) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $create_negative_keyword_request when calling createNegativeKeyword');
Method bulkCreateNegativeKeywordRequest
has 66 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function bulkCreateNegativeKeywordRequest($bulk_create_negative_keyword_request)
{
// Verify the required parameter 'bulk_create_negative_keyword_request' is set.
if ($bulk_create_negative_keyword_request === null || (\is_array($bulk_create_negative_keyword_request) && count($bulk_create_negative_keyword_request) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $bulk_create_negative_keyword_request when calling bulkCreateNegativeKeyword');
Function getNegativeKeywordsRequest
has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
public function getNegativeKeywordsRequest($ad_group_ids = null, $campaign_ids = null, $limit = null, $negative_keyword_status = null, $offset = null)
{
$resourcePath = '/negative_keyword';
$formParams = [];
$queryParams = [];
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method bulkCreateNegativeKeywordWithHttpInfo
has 53 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function bulkCreateNegativeKeywordWithHttpInfo($bulk_create_negative_keyword_request)
{
$request = $this->bulkCreateNegativeKeywordRequest($bulk_create_negative_keyword_request);
try {
Method getNegativeKeywordsWithHttpInfo
has 53 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getNegativeKeywordsWithHttpInfo($ad_group_ids = null, $campaign_ids = null, $limit = null, $negative_keyword_status = null, $offset = null)
{
$request = $this->getNegativeKeywordsRequest($ad_group_ids, $campaign_ids, $limit, $negative_keyword_status, $offset);
try {
Method bulkUpdateNegativeKeywordWithHttpInfo
has 53 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function bulkUpdateNegativeKeywordWithHttpInfo($bulk_update_negative_keyword_request)
{
$request = $this->bulkUpdateNegativeKeywordRequest($bulk_update_negative_keyword_request);
try {
Method getNegativeKeywordWithHttpInfo
has 53 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getNegativeKeywordWithHttpInfo($negative_keyword_id)
{
$request = $this->getNegativeKeywordRequest($negative_keyword_id);
try {
Method createNegativeKeywordWithHttpInfo
has 53 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function createNegativeKeywordWithHttpInfo($create_negative_keyword_request)
{
$request = $this->createNegativeKeywordRequest($create_negative_keyword_request);
try {
Function createNegativeKeywordWithHttpInfo
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
public function createNegativeKeywordWithHttpInfo($create_negative_keyword_request)
{
$request = $this->createNegativeKeywordRequest($create_negative_keyword_request);
try {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getNegativeKeywordsWithHttpInfo
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
public function getNegativeKeywordsWithHttpInfo($ad_group_ids = null, $campaign_ids = null, $limit = null, $negative_keyword_status = null, $offset = null)
{
$request = $this->getNegativeKeywordsRequest($ad_group_ids, $campaign_ids, $limit, $negative_keyword_status, $offset);
try {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getNegativeKeywordWithHttpInfo
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
public function getNegativeKeywordWithHttpInfo($negative_keyword_id)
{
$request = $this->getNegativeKeywordRequest($negative_keyword_id);
try {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function bulkCreateNegativeKeywordWithHttpInfo
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
public function bulkCreateNegativeKeywordWithHttpInfo($bulk_create_negative_keyword_request)
{
$request = $this->bulkCreateNegativeKeywordRequest($bulk_create_negative_keyword_request);
try {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function bulkUpdateNegativeKeywordWithHttpInfo
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
public function bulkUpdateNegativeKeywordWithHttpInfo($bulk_update_negative_keyword_request)
{
$request = $this->bulkUpdateNegativeKeywordRequest($bulk_update_negative_keyword_request);
try {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getNegativeKeywordsWithHttpInfo
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public function getNegativeKeywordsWithHttpInfo($ad_group_ids = null, $campaign_ids = null, $limit = null, $negative_keyword_status = null, $offset = null)
Method getNegativeKeywordsAsync
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public function getNegativeKeywordsAsync($ad_group_ids = null, $campaign_ids = null, $limit = null, $negative_keyword_status = null, $offset = null)
Method getNegativeKeywordsRequest
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public function getNegativeKeywordsRequest($ad_group_ids = null, $campaign_ids = null, $limit = null, $negative_keyword_status = null, $offset = null)
Method getNegativeKeywords
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public function getNegativeKeywords($ad_group_ids = null, $campaign_ids = null, $limit = null, $negative_keyword_status = null, $offset = null)
Method getNegativeKeywordsAsyncWithHttpInfo
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public function getNegativeKeywordsAsyncWithHttpInfo($ad_group_ids = null, $campaign_ids = null, $limit = null, $negative_keyword_status = null, $offset = null)
Function updateNegativeKeywordWithHttpInfo
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function updateNegativeKeywordWithHttpInfo($negative_keyword_id, $update_negative_keyword_request)
{
$request = $this->updateNegativeKeywordRequest($negative_keyword_id, $update_negative_keyword_request);
try {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Similar blocks of code found in 4 locations. Consider refactoring. Open
public function updateNegativeKeywordRequest($negative_keyword_id, $update_negative_keyword_request)
{
// Verify the required parameter 'negative_keyword_id' is set.
if ($negative_keyword_id === null || (\is_array($negative_keyword_id) && count($negative_keyword_id) === 0)) {
throw new \InvalidArgumentException('Missing the required parameter $negative_keyword_id when calling updateNegativeKeyword');
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 613.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 6 locations. Consider refactoring. Open
public function getNegativeKeywordsWithHttpInfo($ad_group_ids = null, $campaign_ids = null, $limit = null, $negative_keyword_status = null, $offset = null)
{
$request = $this->getNegativeKeywordsRequest($ad_group_ids, $campaign_ids, $limit, $negative_keyword_status, $offset);
try {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 573.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 12 locations. Consider refactoring. Open
public function updateNegativeKeywordWithHttpInfo($negative_keyword_id, $update_negative_keyword_request)
{
$request = $this->updateNegativeKeywordRequest($negative_keyword_id, $update_negative_keyword_request);
try {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 355.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 6 locations. Consider refactoring. Open
public function getNegativeKeywordsAsyncWithHttpInfo($ad_group_ids = null, $campaign_ids = null, $limit = null, $negative_keyword_status = null, $offset = null)
{
$returnType = '\TNT\Ebay\Sell\Marketing\V1\Model\NegativeKeywordPagedCollectionResponse';
$request = $this->getNegativeKeywordsRequest($ad_group_ids, $campaign_ids, $limit, $negative_keyword_status, $offset);
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 277.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 12 locations. Consider refactoring. Open
public function updateNegativeKeywordAsyncWithHttpInfo($negative_keyword_id, $update_negative_keyword_request)
{
$returnType = '';
$request = $this->updateNegativeKeywordRequest($negative_keyword_id, $update_negative_keyword_request);
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 182.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 6 locations. Consider refactoring. Open
public function getNegativeKeywordsAsync($ad_group_ids = null, $campaign_ids = null, $limit = null, $negative_keyword_status = null, $offset = null)
{
return $this->getNegativeKeywordsAsyncWithHttpInfo($ad_group_ids, $campaign_ids, $limit, $negative_keyword_status, $offset)
->then(
function ($response) {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 91.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76