brandon14/ebay-sdk-php

View on GitHub
src/Sell/Marketing/V1/Api/PromotionApi.php

Summary

Maintainability
F
2 wks
Test Coverage

File PromotionApi.php has 715 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * This file is part of the trollandtoad/ebay-sdk-php package.
 *
Severity: Major
Found in src/Sell/Marketing/V1/Api/PromotionApi.php - About 1 day to fix

    Method getPromotionsRequest has 109 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getPromotionsRequest($marketplace_id, $limit = null, $offset = null, $promotion_status = null, $promotion_type = null, $q = null, $sort = null)
        {
            // Verify the required parameter 'marketplace_id' is set.
            if ($marketplace_id === null || (\is_array($marketplace_id) && count($marketplace_id) === 0)) {
                throw new \InvalidArgumentException('Missing the required parameter $marketplace_id when calling getPromotions');
    Severity: Major
    Found in src/Sell/Marketing/V1/Api/PromotionApi.php - About 4 hrs to fix

      Method getListingSetRequest has 102 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getListingSetRequest($promotion_id, $limit = null, $offset = null, $q = null, $sort = null, $status = null)
          {
              // Verify the required parameter 'promotion_id' is set.
              if ($promotion_id === null || (\is_array($promotion_id) && count($promotion_id) === 0)) {
                  throw new \InvalidArgumentException('Missing the required parameter $promotion_id when calling getListingSet');
      Severity: Major
      Found in src/Sell/Marketing/V1/Api/PromotionApi.php - About 4 hrs to fix

        Function pausePromotionRequest has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

            public function pausePromotionRequest($promotion_id)
            {
                // Verify the required parameter 'promotion_id' is set.
                if ($promotion_id === null || (\is_array($promotion_id) && count($promotion_id) === 0)) {
                    throw new \InvalidArgumentException('Missing the required parameter $promotion_id when calling pausePromotion');
        Severity: Minor
        Found in src/Sell/Marketing/V1/Api/PromotionApi.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function resumePromotionRequest has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

            public function resumePromotionRequest($promotion_id)
            {
                // Verify the required parameter 'promotion_id' is set.
                if ($promotion_id === null || (\is_array($promotion_id) && count($promotion_id) === 0)) {
                    throw new \InvalidArgumentException('Missing the required parameter $promotion_id when calling resumePromotion');
        Severity: Minor
        Found in src/Sell/Marketing/V1/Api/PromotionApi.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getListingSetRequest has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getListingSetRequest($promotion_id, $limit = null, $offset = null, $q = null, $sort = null, $status = null)
            {
                // Verify the required parameter 'promotion_id' is set.
                if ($promotion_id === null || (\is_array($promotion_id) && count($promotion_id) === 0)) {
                    throw new \InvalidArgumentException('Missing the required parameter $promotion_id when calling getListingSet');
        Severity: Minor
        Found in src/Sell/Marketing/V1/Api/PromotionApi.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        PromotionApi has 25 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class PromotionApi
        {
            /**
             * @var ClientInterface
             */
        Severity: Minor
        Found in src/Sell/Marketing/V1/Api/PromotionApi.php - About 2 hrs to fix

          Function getPromotionsRequest has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getPromotionsRequest($marketplace_id, $limit = null, $offset = null, $promotion_status = null, $promotion_type = null, $q = null, $sort = null)
              {
                  // Verify the required parameter 'marketplace_id' is set.
                  if ($marketplace_id === null || (\is_array($marketplace_id) && count($marketplace_id) === 0)) {
                      throw new \InvalidArgumentException('Missing the required parameter $marketplace_id when calling getPromotions');
          Severity: Minor
          Found in src/Sell/Marketing/V1/Api/PromotionApi.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method pausePromotionRequest has 67 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function pausePromotionRequest($promotion_id)
              {
                  // Verify the required parameter 'promotion_id' is set.
                  if ($promotion_id === null || (\is_array($promotion_id) && count($promotion_id) === 0)) {
                      throw new \InvalidArgumentException('Missing the required parameter $promotion_id when calling pausePromotion');
          Severity: Major
          Found in src/Sell/Marketing/V1/Api/PromotionApi.php - About 2 hrs to fix

            Method resumePromotionRequest has 67 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function resumePromotionRequest($promotion_id)
                {
                    // Verify the required parameter 'promotion_id' is set.
                    if ($promotion_id === null || (\is_array($promotion_id) && count($promotion_id) === 0)) {
                        throw new \InvalidArgumentException('Missing the required parameter $promotion_id when calling resumePromotion');
            Severity: Major
            Found in src/Sell/Marketing/V1/Api/PromotionApi.php - About 2 hrs to fix

              Method getListingSetWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function getListingSetWithHttpInfo($promotion_id, $limit = null, $offset = null, $q = null, $sort = null, $status = null)
                  {
                      $request = $this->getListingSetRequest($promotion_id, $limit, $offset, $q, $sort, $status);
              
                      try {
              Severity: Major
              Found in src/Sell/Marketing/V1/Api/PromotionApi.php - About 2 hrs to fix

                Method getPromotionsWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function getPromotionsWithHttpInfo($marketplace_id, $limit = null, $offset = null, $promotion_status = null, $promotion_type = null, $q = null, $sort = null)
                    {
                        $request = $this->getPromotionsRequest($marketplace_id, $limit, $offset, $promotion_status, $promotion_type, $q, $sort);
                
                        try {
                Severity: Major
                Found in src/Sell/Marketing/V1/Api/PromotionApi.php - About 2 hrs to fix

                  Function getPromotionsWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function getPromotionsWithHttpInfo($marketplace_id, $limit = null, $offset = null, $promotion_status = null, $promotion_type = null, $q = null, $sort = null)
                      {
                          $request = $this->getPromotionsRequest($marketplace_id, $limit, $offset, $promotion_status, $promotion_type, $q, $sort);
                  
                          try {
                  Severity: Minor
                  Found in src/Sell/Marketing/V1/Api/PromotionApi.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function getListingSetWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function getListingSetWithHttpInfo($promotion_id, $limit = null, $offset = null, $q = null, $sort = null, $status = null)
                      {
                          $request = $this->getListingSetRequest($promotion_id, $limit, $offset, $q, $sort, $status);
                  
                          try {
                  Severity: Minor
                  Found in src/Sell/Marketing/V1/Api/PromotionApi.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method getPromotions has 7 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      public function getPromotions($marketplace_id, $limit = null, $offset = null, $promotion_status = null, $promotion_type = null, $q = null, $sort = null)
                  Severity: Major
                  Found in src/Sell/Marketing/V1/Api/PromotionApi.php - About 50 mins to fix

                    Method getPromotionsRequest has 7 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public function getPromotionsRequest($marketplace_id, $limit = null, $offset = null, $promotion_status = null, $promotion_type = null, $q = null, $sort = null)
                    Severity: Major
                    Found in src/Sell/Marketing/V1/Api/PromotionApi.php - About 50 mins to fix

                      Method getPromotionsWithHttpInfo has 7 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          public function getPromotionsWithHttpInfo($marketplace_id, $limit = null, $offset = null, $promotion_status = null, $promotion_type = null, $q = null, $sort = null)
                      Severity: Major
                      Found in src/Sell/Marketing/V1/Api/PromotionApi.php - About 50 mins to fix

                        Method getPromotionsAsync has 7 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            public function getPromotionsAsync($marketplace_id, $limit = null, $offset = null, $promotion_status = null, $promotion_type = null, $q = null, $sort = null)
                        Severity: Major
                        Found in src/Sell/Marketing/V1/Api/PromotionApi.php - About 50 mins to fix

                          Method getPromotionsAsyncWithHttpInfo has 7 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              public function getPromotionsAsyncWithHttpInfo($marketplace_id, $limit = null, $offset = null, $promotion_status = null, $promotion_type = null, $q = null, $sort = null)
                          Severity: Major
                          Found in src/Sell/Marketing/V1/Api/PromotionApi.php - About 50 mins to fix

                            Method getListingSetAsyncWithHttpInfo has 6 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                public function getListingSetAsyncWithHttpInfo($promotion_id, $limit = null, $offset = null, $q = null, $sort = null, $status = null)
                            Severity: Minor
                            Found in src/Sell/Marketing/V1/Api/PromotionApi.php - About 45 mins to fix

                              Method getListingSetRequest has 6 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                  public function getListingSetRequest($promotion_id, $limit = null, $offset = null, $q = null, $sort = null, $status = null)
                              Severity: Minor
                              Found in src/Sell/Marketing/V1/Api/PromotionApi.php - About 45 mins to fix

                                Method getListingSetWithHttpInfo has 6 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                    public function getListingSetWithHttpInfo($promotion_id, $limit = null, $offset = null, $q = null, $sort = null, $status = null)
                                Severity: Minor
                                Found in src/Sell/Marketing/V1/Api/PromotionApi.php - About 45 mins to fix

                                  Method getListingSet has 6 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                      public function getListingSet($promotion_id, $limit = null, $offset = null, $q = null, $sort = null, $status = null)
                                  Severity: Minor
                                  Found in src/Sell/Marketing/V1/Api/PromotionApi.php - About 45 mins to fix

                                    Method getListingSetAsync has 6 arguments (exceeds 4 allowed). Consider refactoring.
                                    Open

                                        public function getListingSetAsync($promotion_id, $limit = null, $offset = null, $q = null, $sort = null, $status = null)
                                    Severity: Minor
                                    Found in src/Sell/Marketing/V1/Api/PromotionApi.php - About 45 mins to fix

                                      Function resumePromotionWithHttpInfo has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                                      Open

                                          public function resumePromotionWithHttpInfo($promotion_id)
                                          {
                                              $request = $this->resumePromotionRequest($promotion_id);
                                      
                                              try {
                                      Severity: Minor
                                      Found in src/Sell/Marketing/V1/Api/PromotionApi.php - About 35 mins to fix

                                      Cognitive Complexity

                                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                      A method's cognitive complexity is based on a few simple rules:

                                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                      • Code is considered more complex for each "break in the linear flow of the code"
                                      • Code is considered more complex when "flow breaking structures are nested"

                                      Further reading

                                      Function pausePromotionWithHttpInfo has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                                      Open

                                          public function pausePromotionWithHttpInfo($promotion_id)
                                          {
                                              $request = $this->pausePromotionRequest($promotion_id);
                                      
                                              try {
                                      Severity: Minor
                                      Found in src/Sell/Marketing/V1/Api/PromotionApi.php - About 35 mins to fix

                                      Cognitive Complexity

                                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                      A method's cognitive complexity is based on a few simple rules:

                                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                      • Code is considered more complex for each "break in the linear flow of the code"
                                      • Code is considered more complex when "flow breaking structures are nested"

                                      Further reading

                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                          public function getListingSetRequest($promotion_id, $limit = null, $offset = null, $q = null, $sort = null, $status = null)
                                          {
                                              // Verify the required parameter 'promotion_id' is set.
                                              if ($promotion_id === null || (\is_array($promotion_id) && count($promotion_id) === 0)) {
                                                  throw new \InvalidArgumentException('Missing the required parameter $promotion_id when calling getListingSet');
                                      Severity: Major
                                      Found in src/Sell/Marketing/V1/Api/PromotionApi.php and 1 other location - About 4 days to fix
                                      src/Sell/Marketing/V1/Api/AdApi.php on lines 3740..3868

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 779.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                          public function getPromotionsWithHttpInfo($marketplace_id, $limit = null, $offset = null, $promotion_status = null, $promotion_type = null, $q = null, $sort = null)
                                          {
                                              $request = $this->getPromotionsRequest($marketplace_id, $limit, $offset, $promotion_status, $promotion_type, $q, $sort);
                                      
                                              try {
                                      Severity: Major
                                      Found in src/Sell/Marketing/V1/Api/PromotionApi.php and 1 other location - About 3 days to fix
                                      src/Buy/Feed/V1/Api/FileApi.php on lines 740..805

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 592.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Similar blocks of code found in 5 locations. Consider refactoring.
                                      Open

                                          public function getListingSetWithHttpInfo($promotion_id, $limit = null, $offset = null, $q = null, $sort = null, $status = null)
                                          {
                                              $request = $this->getListingSetRequest($promotion_id, $limit, $offset, $q, $sort, $status);
                                      
                                              try {
                                      Severity: Major
                                      Found in src/Sell/Marketing/V1/Api/PromotionApi.php and 4 other locations - About 3 days to fix
                                      src/Buy/Deal/V1/Api/DealItemApi.php on lines 189..254
                                      src/Sell/Compliance/V1/Api/ListingViolationApi.php on lines 189..254
                                      src/Sell/Marketing/V1/Api/AdApi.php on lines 3591..3656
                                      src/Sell/Marketing/V1/Api/PromotionReportApi.php on lines 189..254

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 580.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                          public function getPromotionsAsyncWithHttpInfo($marketplace_id, $limit = null, $offset = null, $promotion_status = null, $promotion_type = null, $q = null, $sort = null)
                                          {
                                              $returnType = '\TNT\Ebay\Sell\Marketing\V1\Model\PromotionsPagedCollection';
                                              $request = $this->getPromotionsRequest($marketplace_id, $limit, $offset, $promotion_status, $promotion_type, $q, $sort);
                                      
                                      
                                      Severity: Major
                                      Found in src/Sell/Marketing/V1/Api/PromotionApi.php and 1 other location - About 1 day to fix
                                      src/Buy/Feed/V1/Api/FileApi.php on lines 847..875

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 296.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Similar blocks of code found in 5 locations. Consider refactoring.
                                      Open

                                          public function getListingSetAsyncWithHttpInfo($promotion_id, $limit = null, $offset = null, $q = null, $sort = null, $status = null)
                                          {
                                              $returnType = '\TNT\Ebay\Sell\Marketing\V1\Model\ItemsPagedCollection';
                                              $request = $this->getListingSetRequest($promotion_id, $limit, $offset, $q, $sort, $status);
                                      
                                      
                                      Severity: Major
                                      Found in src/Sell/Marketing/V1/Api/PromotionApi.php and 4 other locations - About 1 day to fix
                                      src/Buy/Deal/V1/Api/DealItemApi.php on lines 294..322
                                      src/Sell/Compliance/V1/Api/ListingViolationApi.php on lines 294..322
                                      src/Sell/Marketing/V1/Api/AdApi.php on lines 3696..3724
                                      src/Sell/Marketing/V1/Api/PromotionReportApi.php on lines 294..322

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 284.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                          public function getPromotionsAsync($marketplace_id, $limit = null, $offset = null, $promotion_status = null, $promotion_type = null, $q = null, $sort = null)
                                          {
                                              return $this->getPromotionsAsyncWithHttpInfo($marketplace_id, $limit, $offset, $promotion_status, $promotion_type, $q, $sort)
                                                  ->then(
                                                      function ($response) {
                                      Severity: Major
                                      Found in src/Sell/Marketing/V1/Api/PromotionApi.php and 1 other location - About 1 hr to fix
                                      src/Buy/Feed/V1/Api/FileApi.php on lines 822..830

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 110.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                          public function getPromotions($marketplace_id, $limit = null, $offset = null, $promotion_status = null, $promotion_type = null, $q = null, $sort = null)
                                          {
                                              [$response] = $this->getPromotionsWithHttpInfo($marketplace_id, $limit, $offset, $promotion_status, $promotion_type, $q, $sort);
                                      
                                              return $response;
                                      Severity: Minor
                                      Found in src/Sell/Marketing/V1/Api/PromotionApi.php and 1 other location - About 1 hr to fix
                                      src/Buy/Feed/V1/Api/FileApi.php on lines 717..722

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 100.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Similar blocks of code found in 5 locations. Consider refactoring.
                                      Open

                                          public function getListingSetAsync($promotion_id, $limit = null, $offset = null, $q = null, $sort = null, $status = null)
                                          {
                                              return $this->getListingSetAsyncWithHttpInfo($promotion_id, $limit, $offset, $q, $sort, $status)
                                                  ->then(
                                                      function ($response) {
                                      Severity: Major
                                      Found in src/Sell/Marketing/V1/Api/PromotionApi.php and 4 other locations - About 55 mins to fix
                                      src/Buy/Deal/V1/Api/DealItemApi.php on lines 270..278
                                      src/Sell/Compliance/V1/Api/ListingViolationApi.php on lines 270..278
                                      src/Sell/Marketing/V1/Api/AdApi.php on lines 3672..3680
                                      src/Sell/Marketing/V1/Api/PromotionReportApi.php on lines 270..278

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 98.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      There are no issues that match your filters.

                                      Category
                                      Status