Sign upLogin

brandon14/ebay-sdk-php

View on GitHub
Star
src/Sell/Marketing/V1/Api/PromotionReportApi.php

Summary

Maintainability
F
6 days
Test Coverage

Method getPromotionReportsRequest has 102 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getPromotionReportsRequest($marketplace_id, $limit = null, $offset = null, $promotion_status = null, $promotion_type = null, $q = null)
    {
        // Verify the required parameter 'marketplace_id' is set.
        if ($marketplace_id === null || (\is_array($marketplace_id) && count($marketplace_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $marketplace_id when calling getPromotionReports');
Severity: Major
Found in src/Sell/Marketing/V1/Api/PromotionReportApi.php - About 4 hrs to fix

    Function getPromotionReportsRequest has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getPromotionReportsRequest($marketplace_id, $limit = null, $offset = null, $promotion_status = null, $promotion_type = null, $q = null)
    {
        // Verify the required parameter 'marketplace_id' is set.
        if ($marketplace_id === null || (\is_array($marketplace_id) && count($marketplace_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $marketplace_id when calling getPromotionReports');
    Severity: Minor
    Found in src/Sell/Marketing/V1/Api/PromotionReportApi.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File PromotionReportApi.php has 257 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

/**
 * This file is part of the trollandtoad/ebay-sdk-php package.
 *
    Severity: Minor
    Found in src/Sell/Marketing/V1/Api/PromotionReportApi.php - About 2 hrs to fix

      Method getPromotionReportsWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getPromotionReportsWithHttpInfo($marketplace_id, $limit = null, $offset = null, $promotion_status = null, $promotion_type = null, $q = null)
    {
        $request = $this->getPromotionReportsRequest($marketplace_id, $limit, $offset, $promotion_status, $promotion_type, $q);

        try {
      Severity: Major
      Found in src/Sell/Marketing/V1/Api/PromotionReportApi.php - About 2 hrs to fix

        Function getPromotionReportsWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getPromotionReportsWithHttpInfo($marketplace_id, $limit = null, $offset = null, $promotion_status = null, $promotion_type = null, $q = null)
    {
        $request = $this->getPromotionReportsRequest($marketplace_id, $limit, $offset, $promotion_status, $promotion_type, $q);

        try {
        Severity: Minor
        Found in src/Sell/Marketing/V1/Api/PromotionReportApi.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method getPromotionReports has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function getPromotionReports($marketplace_id, $limit = null, $offset = null, $promotion_status = null, $promotion_type = null, $q = null)
        Severity: Minor
        Found in src/Sell/Marketing/V1/Api/PromotionReportApi.php - About 45 mins to fix

          Method getPromotionReportsRequest has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function getPromotionReportsRequest($marketplace_id, $limit = null, $offset = null, $promotion_status = null, $promotion_type = null, $q = null)
          Severity: Minor
          Found in src/Sell/Marketing/V1/Api/PromotionReportApi.php - About 45 mins to fix

            Method getPromotionReportsWithHttpInfo has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function getPromotionReportsWithHttpInfo($marketplace_id, $limit = null, $offset = null, $promotion_status = null, $promotion_type = null, $q = null)
            Severity: Minor
            Found in src/Sell/Marketing/V1/Api/PromotionReportApi.php - About 45 mins to fix

              Method getPromotionReportsAsync has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function getPromotionReportsAsync($marketplace_id, $limit = null, $offset = null, $promotion_status = null, $promotion_type = null, $q = null)
              Severity: Minor
              Found in src/Sell/Marketing/V1/Api/PromotionReportApi.php - About 45 mins to fix

                Method getPromotionReportsAsyncWithHttpInfo has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public function getPromotionReportsAsyncWithHttpInfo($marketplace_id, $limit = null, $offset = null, $promotion_status = null, $promotion_type = null, $q = null)
                Severity: Minor
                Found in src/Sell/Marketing/V1/Api/PromotionReportApi.php - About 45 mins to fix

                  Similar blocks of code found in 5 locations. Consider refactoring.
                  Open

                      public function getPromotionReportsWithHttpInfo($marketplace_id, $limit = null, $offset = null, $promotion_status = null, $promotion_type = null, $q = null)
    {
        $request = $this->getPromotionReportsRequest($marketplace_id, $limit, $offset, $promotion_status, $promotion_type, $q);

        try {
                  Severity: Major
                  Found in src/Sell/Marketing/V1/Api/PromotionReportApi.php and 4 other locations - About 3 days to fix
                  src/Buy/Deal/V1/Api/DealItemApi.php on lines 189..254
                  src/Sell/Compliance/V1/Api/ListingViolationApi.php on lines 189..254
                  src/Sell/Marketing/V1/Api/AdApi.php on lines 3591..3656
                  src/Sell/Marketing/V1/Api/PromotionApi.php on lines 189..254

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 580.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 5 locations. Consider refactoring.
                  Open

                      public function getPromotionReportsAsyncWithHttpInfo($marketplace_id, $limit = null, $offset = null, $promotion_status = null, $promotion_type = null, $q = null)
    {
        $returnType = '\TNT\Ebay\Sell\Marketing\V1\Model\PromotionsReportPagedCollection';
        $request = $this->getPromotionReportsRequest($marketplace_id, $limit, $offset, $promotion_status, $promotion_type, $q);
                  Severity: Major
                  Found in src/Sell/Marketing/V1/Api/PromotionReportApi.php and 4 other locations - About 1 day to fix
                  src/Buy/Deal/V1/Api/DealItemApi.php on lines 294..322
                  src/Sell/Compliance/V1/Api/ListingViolationApi.php on lines 294..322
                  src/Sell/Marketing/V1/Api/AdApi.php on lines 3696..3724
                  src/Sell/Marketing/V1/Api/PromotionApi.php on lines 294..322

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 284.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 5 locations. Consider refactoring.
                  Open

                      public function getPromotionReportsAsync($marketplace_id, $limit = null, $offset = null, $promotion_status = null, $promotion_type = null, $q = null)
    {
        return $this->getPromotionReportsAsyncWithHttpInfo($marketplace_id, $limit, $offset, $promotion_status, $promotion_type, $q)
            ->then(
                function ($response) {
                  Severity: Major
                  Found in src/Sell/Marketing/V1/Api/PromotionReportApi.php and 4 other locations - About 55 mins to fix
                  src/Buy/Deal/V1/Api/DealItemApi.php on lines 270..278
                  src/Sell/Compliance/V1/Api/ListingViolationApi.php on lines 270..278
                  src/Sell/Marketing/V1/Api/AdApi.php on lines 3672..3680
                  src/Sell/Marketing/V1/Api/PromotionApi.php on lines 270..278

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 98.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status