Sign upLogin

brandon14/ebay-sdk-php

View on GitHub
Star
src/Sell/Negotiation/V1/Api/OfferApi.php

Summary

Maintainability
F
1 wk
Test Coverage

File OfferApi.php has 394 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * This file is part of the trollandtoad/ebay-sdk-php package.
 *
Severity: Minor
Found in src/Sell/Negotiation/V1/Api/OfferApi.php - About 5 hrs to fix

    Function sendOfferToInterestedBuyersRequest has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

        public function sendOfferToInterestedBuyersRequest($x_ebay_c_marketplace_id, $create_offers_request = null)
    {
        // Verify the required parameter 'x_ebay_c_marketplace_id' is set.
        if ($x_ebay_c_marketplace_id === null || (\is_array($x_ebay_c_marketplace_id) && count($x_ebay_c_marketplace_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $x_ebay_c_marketplace_id when calling sendOfferToInterestedBuyers');
    Severity: Minor
    Found in src/Sell/Negotiation/V1/Api/OfferApi.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method findEligibleItemsRequest has 74 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function findEligibleItemsRequest($x_ebay_c_marketplace_id, $limit = null, $offset = null)
    {
        // Verify the required parameter 'x_ebay_c_marketplace_id' is set.
        if ($x_ebay_c_marketplace_id === null || (\is_array($x_ebay_c_marketplace_id) && count($x_ebay_c_marketplace_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $x_ebay_c_marketplace_id when calling findEligibleItems');
    Severity: Major
    Found in src/Sell/Negotiation/V1/Api/OfferApi.php - About 2 hrs to fix

      Function findEligibleItemsRequest has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

          public function findEligibleItemsRequest($x_ebay_c_marketplace_id, $limit = null, $offset = null)
    {
        // Verify the required parameter 'x_ebay_c_marketplace_id' is set.
        if ($x_ebay_c_marketplace_id === null || (\is_array($x_ebay_c_marketplace_id) && count($x_ebay_c_marketplace_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $x_ebay_c_marketplace_id when calling findEligibleItems');
      Severity: Minor
      Found in src/Sell/Negotiation/V1/Api/OfferApi.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method sendOfferToInterestedBuyersRequest has 66 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function sendOfferToInterestedBuyersRequest($x_ebay_c_marketplace_id, $create_offers_request = null)
    {
        // Verify the required parameter 'x_ebay_c_marketplace_id' is set.
        if ($x_ebay_c_marketplace_id === null || (\is_array($x_ebay_c_marketplace_id) && count($x_ebay_c_marketplace_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $x_ebay_c_marketplace_id when calling sendOfferToInterestedBuyers');
      Severity: Major
      Found in src/Sell/Negotiation/V1/Api/OfferApi.php - About 2 hrs to fix

        Method sendOfferToInterestedBuyersWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function sendOfferToInterestedBuyersWithHttpInfo($x_ebay_c_marketplace_id, $create_offers_request = null)
    {
        $request = $this->sendOfferToInterestedBuyersRequest($x_ebay_c_marketplace_id, $create_offers_request);

        try {
        Severity: Major
        Found in src/Sell/Negotiation/V1/Api/OfferApi.php - About 2 hrs to fix

          Method findEligibleItemsWithHttpInfo has 53 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function findEligibleItemsWithHttpInfo($x_ebay_c_marketplace_id, $limit = null, $offset = null)
    {
        $request = $this->findEligibleItemsRequest($x_ebay_c_marketplace_id, $limit, $offset);

        try {
          Severity: Major
          Found in src/Sell/Negotiation/V1/Api/OfferApi.php - About 2 hrs to fix

            Function findEligibleItemsWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

                public function findEligibleItemsWithHttpInfo($x_ebay_c_marketplace_id, $limit = null, $offset = null)
    {
        $request = $this->findEligibleItemsRequest($x_ebay_c_marketplace_id, $limit, $offset);

        try {
            Severity: Minor
            Found in src/Sell/Negotiation/V1/Api/OfferApi.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function sendOfferToInterestedBuyersWithHttpInfo has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

                public function sendOfferToInterestedBuyersWithHttpInfo($x_ebay_c_marketplace_id, $create_offers_request = null)
    {
        $request = $this->sendOfferToInterestedBuyersRequest($x_ebay_c_marketplace_id, $create_offers_request);

        try {
            Severity: Minor
            Found in src/Sell/Negotiation/V1/Api/OfferApi.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public function findEligibleItemsRequest($x_ebay_c_marketplace_id, $limit = null, $offset = null)
    {
        // Verify the required parameter 'x_ebay_c_marketplace_id' is set.
        if ($x_ebay_c_marketplace_id === null || (\is_array($x_ebay_c_marketplace_id) && count($x_ebay_c_marketplace_id) === 0)) {
            throw new \InvalidArgumentException('Missing the required parameter $x_ebay_c_marketplace_id when calling findEligibleItems');
            Severity: Major
            Found in src/Sell/Negotiation/V1/Api/OfferApi.php and 1 other location - About 3 days to fix
            src/Buy/Deal/V1/Api/EventApi.php on lines 583..679

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 577.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 6 locations. Consider refactoring.
            Open

                public function findEligibleItemsWithHttpInfo($x_ebay_c_marketplace_id, $limit = null, $offset = null)
    {
        $request = $this->findEligibleItemsRequest($x_ebay_c_marketplace_id, $limit, $offset);

        try {
            Severity: Major
            Found in src/Sell/Negotiation/V1/Api/OfferApi.php and 5 other locations - About 2 days to fix
            src/Buy/Deal/V1/Api/EventApi.php on lines 443..508
            src/Buy/Order/V2/Api/GuestCheckoutSessionApi.php on lines 714..779
            src/Sell/Feed/V1/Api/ScheduleApi.php on lines 1363..1428
            src/Sell/Feed/V1/Api/ScheduleApi.php on lines 1635..1700
            src/Sell/ListingBeta/V1/Api/ItemDraftApi.php on lines 183..248

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 544.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 6 locations. Consider refactoring.
            Open

                public function findEligibleItemsAsyncWithHttpInfo($x_ebay_c_marketplace_id, $limit = null, $offset = null)
    {
        $returnType = '\TNT\Ebay\Sell\Negotiation\V1\Model\PagedEligibleItemCollection';
        $request = $this->findEligibleItemsRequest($x_ebay_c_marketplace_id, $limit, $offset);
            Severity: Major
            Found in src/Sell/Negotiation/V1/Api/OfferApi.php and 5 other locations - About 1 day to fix
            src/Buy/Deal/V1/Api/EventApi.php on lines 542..570
            src/Buy/Order/V2/Api/GuestCheckoutSessionApi.php on lines 813..841
            src/Sell/Feed/V1/Api/ScheduleApi.php on lines 1462..1490
            src/Sell/Feed/V1/Api/ScheduleApi.php on lines 1734..1762
            src/Sell/ListingBeta/V1/Api/ItemDraftApi.php on lines 282..310

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 248.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status