File FossabotCommander.php
has 318 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* This file is part of the brandon14/fossabot-commander package.
*
FossabotCommander
has 22 functions (exceeds 20 allowed). Consider refactoring. Open
class FossabotCommander implements FossabotCommanderInterface, LoggerAwareInterface
{
use LoggerAwareTrait;
use LoggerTrait;
Method runCommand
has 44 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function runCommand(
$command,
string $customApiToken,
bool $getContext = true
): string {
Method getExceptionFromBody
has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function getExceptionFromBody(array $body, int $statusCode, array $headers): FossabotApiException
{
// Get exception details from response body.
$fossabotCode = $body['code'] ?? 'unknown';
$errorClass = $body['error'] ?? 'Unknown Error';
Method getContext
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function getContext(string $customApiToken): FossabotContextInterface
{
$this->info('Sending request to get additional context.');
try {
Function runCommand
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
public function runCommand(
$command,
string $customApiToken,
bool $getContext = true
): string {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method __construct
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
ClientInterface $httpClient,
RequestFactoryInterface $requestFactory,
?LoggerInterface $logger = null,
bool $logging = false,
bool $includeLogContext = true
Function getContext
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
private function getContext(string $customApiToken): FossabotContextInterface
{
$this->info('Sending request to get additional context.');
try {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function log
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public function log($level, $message, array $context = []): void // @pest-ignore-type
{
// Only log if logging is enabled and we have a logger instance.
if (! $this->logging || $this->logger === null) {
return;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Similar blocks of code found in 2 locations. Consider refactoring. Open
try {
$body = $this->sendContextRequest($customApiToken);
$this->info('Successfully received context response.');
} catch (Throwable $exception) {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 187.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
try {
// Send validate request. Will throw exception if unable to validate.
$this->sendValidateRequest($customApiToken);
$this->info('Validated Fossabot request.');
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 187.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76