Sign upLogin

brewster1134/cli_miami

View on GitHub
Star
lib/cli_miami/ask.rb

Summary

Maintainability
D
1 day
Test Coverage

Method request_hash has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

  def request_hash options
    hash = {}
    options[:keys] ||= []
    value_options = CliMiami.get_options(options[:value_options] || {})
    required_keys_set = false
Severity: Minor
Found in lib/cli_miami/ask.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method request_multiple_choice has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

  def request_multiple_choice options
    selected_choices = nil
    selected_choice_indexes = []

    while selected_choice_indexes.length < options[:max]
Severity: Minor
Found in lib/cli_miami/ask.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method request_multiple_choice has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def request_multiple_choice options
    selected_choices = nil
    selected_choice_indexes = []

    while selected_choice_indexes.length < options[:max]
Severity: Minor
Found in lib/cli_miami/ask.rb - About 1 hr to fix

    Method request_hash has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def request_hash options
    hash = {}
    options[:keys] ||= []
    value_options = CliMiami.get_options(options[:value_options] || {})
    required_keys_set = false
    Severity: Minor
    Found in lib/cli_miami/ask.rb - About 1 hr to fix

      Method request_until_valid has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def request_until_valid options, allow_empty_string = false
    response = nil

    while response.nil?
      # get user input based on given file type
      Severity: Minor
      Found in lib/cli_miami/ask.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method request_range has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        def request_range options
    start_value = nil
    end_value = nil
    range_value_options = CliMiami.get_options type: :float
      Severity: Minor
      Found in lib/cli_miami/ask.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method request_array has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        def request_array options
    array = []
    value_options = CliMiami.get_options(options[:value_options] || {})

    # build the array by prompting the user
      Severity: Minor
      Found in lib/cli_miami/ask.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

                  if options[:keys].include? user_key
              # prevent deleting required keys
              CliMiami::S.ay I18n.t('cli_miami.errors.multiple_choice.delete_required_key', key: user_key), :cli_miami_fail
              redo
            else
      Severity: Major
      Found in lib/cli_miami/ask.rb - About 45 mins to fix

        Avoid rescuing without specifying an error class.
        Open

          rescue
        Severity: Minor
        Found in lib/cli_miami/ask.rb by rubocop

        This cop checks for rescuing StandardError. There are two supported styles implicit and explicit. This cop will not register an offense if any error other than StandardError is specified.

        Example: EnforcedStyle: implicit

        # `implicit` will enforce using `rescue` instead of
# `rescue StandardError`.

# bad
begin
  foo
rescue StandardError
  bar
end

# good
begin
  foo
rescue
  bar
end

# good
begin
  foo
rescue OtherError
  bar
end

# good
begin
  foo
rescue StandardError, SecurityError
  bar
end

        Example: EnforcedStyle: explicit (default)

        # `explicit` will enforce using `rescue StandardError`
# instead of `rescue`.

# bad
begin
  foo
rescue
  bar
end

# good
begin
  foo
rescue StandardError
  bar
end

# good
begin
  foo
rescue OtherError
  bar
end

# good
begin
  foo
rescue StandardError, SecurityError
  bar
end

        Do not return a value in initialize.
        Open

              return @value
        Severity: Minor
        Found in lib/cli_miami/ask.rb by rubocop

        This cop checks for the use of a return with a value in a context where the value will be ignored. (initialize and setter methods)

        Example:

        # bad
def initialize
  foo
  return :qux if bar?
  baz
end

def foo=(bar)
  return 42
end

        Example:

        # good
def initialize
  foo
  return if bar?
  baz
end

def foo=(bar)
  return
end

        There are no issues that match your filters.

        Category
        Status