brightdigit/MistKit

View on GitHub
Sources/MistKit/Controllers/MKDatabase.swift

Summary

Maintainability
A
0 mins
Test Coverage

Function body should span 15 lines or less excluding comments and whitespace: currently spans 16 lines
Open

  public func perform<RequestType: MKRequest, ResponseType>(

public declarations should be documented.
Open

  public let client: HttpClient

public declarations should be documented.
Open

  public let urlBuilder: MKURLBuilderProtocol

public declarations should be documented.
Open

  public init(connection: MKDatabaseConnection,

public declarations should be documented.
Open

  public let requestConfigFactory: RequestConfigurationFactoryProtocol

public declarations should be documented.
Open

  public func perform<RequestType: MKRequest, ResponseType>(

public declarations should be documented.
Open

  public let resultSink: ResultSinkProtocol

public declarations should be documented.
Open

public struct MKDatabase<HttpClient: MKHttpClient> {

Function should have at least one blank line after it
Open

  }

function-whitespace

Every function and method declaration should have one blank line before and after itself. An exception to this rule are functions that are declared at the start of a file (only need one blank line after their declaration) or at the end of a file (only need one blank line before their declaration). Comments immediately before a function declaration (no blank lines between them and the function) are considered to be part of the declaration.

Preferred

func function1() {
  var text = 1
  var text = 2
}

function1()

// a comment
func function2() {
  // something goes here
}

struct SomeStruct {

  func function3() {
    // something goes here
  }

  func function4() {
    // something else goes here
  };

}

func function5() {
  // something goes here
}

Not Preferred

func function1() {
  var text = 1
  var text = 2
}
function1()
// a comment
func function2() {
  // something goes here
}

struct SomeStruct {
  func function3() {
    // something goes here
  }

  func function4() {
    // something else goes here
  };
}
func function5() {
  // something goes here
}

There are no issues that match your filters.

Category
Status