brndnmtthws/dragon-rest

View on GitHub
dragon_rest/dragons.py

Summary

Maintainability
D
2 days
Test Coverage
C
70%

DragonAPI has 27 functions (exceeds 20 allowed). Consider refactoring.
Wontfix

class DragonAPI(object):
    """
    DragonMint/Innosilicon API wrapper.

    This wrapper should work with both DragonMint and Innosilicon branded
Severity: Minor
Found in dragon_rest/dragons.py - About 3 hrs to fix

    Function updatePools has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Wontfix

        def updatePools(self,
    Severity: Major
    Found in dragon_rest/dragons.py - About 1 hr to fix

      Function updateNetwork has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Wontfix

          def updateNetwork(self,
      Severity: Minor
      Found in dragon_rest/dragons.py - About 35 mins to fix

        Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Wontfix

            def __init__(self,
        Severity: Minor
        Found in dragon_rest/dragons.py - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def __post_files(self, path, files):
                  response = requests.post(
                      parse.urljoin(self.base_url, path),
                      headers={'Authorization': 'Bearer ' + self.jwt},
                      timeout=self.timeout,
          Severity: Major
          Found in dragon_rest/dragons.py and 1 other location - About 1 day to fix
          dragon_rest/dragons.py on lines 67..83

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 136.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def __post(self, path, data=None):
                  response = requests.post(
                      parse.urljoin(self.base_url, path),
                      headers={'Authorization': 'Bearer ' + self.jwt},
                      timeout=self.timeout,
          Severity: Major
          Found in dragon_rest/dragons.py and 1 other location - About 1 day to fix
          dragon_rest/dragons.py on lines 85..101

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 136.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status