Sign upLogin

brokencube/automatorm

View on GitHub
Star
src/DataLayer/Database/SchemaGenerator.php

Summary

Maintainability
D
1 day
Test Coverage

Function generate has a Cognitive Complexity of 57 (exceeds 5 allowed). Consider refactoring.
Open

    public function generate()
    {
        $connection = $this->connection;
        
        $model = [];
Severity: Minor
Found in src/DataLayer/Database/SchemaGenerator.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method generate has 129 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function generate()
    {
        $connection = $this->connection;
        
        $model = [];
Severity: Major
Found in src/DataLayer/Database/SchemaGenerator.php - About 5 hrs to fix

    The method generate() has 181 lines of code. Current threshold is set to 100. Avoid really long methods.
    Open

        public function generate()
    {
        $connection = $this->connection;
        
        $model = [];
    Severity: Minor
    Found in src/DataLayer/Database/SchemaGenerator.php by phpmd

    The method generate() has an NPath complexity of 4752. The configured NPath complexity threshold is 200.
    Open

        public function generate()
    {
        $connection = $this->connection;
        
        $model = [];
    Severity: Minor
    Found in src/DataLayer/Database/SchemaGenerator.php by phpmd

    NPathComplexity

    Since: 0.1

    The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

    Example

    class Foo {
    function bar() {
        // lots of complicated code
    }
}

    Source https://phpmd.org/rules/codesize.html#npathcomplexity

    The method generate() has a Cyclomatic Complexity of 25. The configured cyclomatic complexity threshold is 10.
    Open

        public function generate()
    {
        $connection = $this->connection;
        
        $model = [];
    Severity: Minor
    Found in src/DataLayer/Database/SchemaGenerator.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Possibly zero references to use statement for classlike/namespace Exception (\Automatorm\Exception)
    Open

    use Automatorm\Exception;
    Severity: Minor
    Found in src/DataLayer/Database/SchemaGenerator.php by phan

    Line exceeds 120 characters; contains 140 characters
    Open

                SELECT b.table_schema, b.table_name, b.column_name, b.referenced_table_schema, b.referenced_table_name, b.referenced_column_name
    Severity: Minor
    Found in src/DataLayer/Database/SchemaGenerator.php by phpcodesniffer

    Line exceeds 120 characters; contains 147 characters
    Open

                    // For each foreign key, store details in the table it point to on how to get to the OTHER table in the "Many to Many" relationship
    Severity: Minor
    Found in src/DataLayer/Database/SchemaGenerator.php by phpcodesniffer

    Line exceeds 120 characters; contains 134 characters
    Open

                        // If the column name is named based on the foreign table name, then use the pivot table name as the property name
    Severity: Minor
    Found in src/DataLayer/Database/SchemaGenerator.php by phpcodesniffer

    Line exceeds 120 characters; contains 140 characters
    Open

                SELECT b.table_schema, b.table_name, b.column_name, b.referenced_table_schema, b.referenced_table_name, b.referenced_column_name
    Severity: Minor
    Found in src/DataLayer/Database/SchemaGenerator.php by phpcodesniffer

    Line exceeds 120 characters; contains 124 characters
    Open

                        // Outersect of tables to create an array of all OTHER foreign keys in this table, for this foreign key.
    Severity: Minor
    Found in src/DataLayer/Database/SchemaGenerator.php by phpcodesniffer

    Line exceeds 120 characters; contains 132 characters
    Open

                SELECT table_schema, table_name, column_name, data_type FROM information_schema.columns where table_schema = database();
    Severity: Minor
    Found in src/DataLayer/Database/SchemaGenerator.php by phpcodesniffer

    Line exceeds 120 characters; contains 125 characters
    Open

                            // needs to have a unique name for at least one of the columns (which is not based on the table name)
    Severity: Minor
    Found in src/DataLayer/Database/SchemaGenerator.php by phpcodesniffer

    Whitespace found at end of line
    Open

            }
    Severity: Minor
    Found in src/DataLayer/Database/SchemaGenerator.php by phpcodesniffer

    Expected 0 spaces before closing bracket; newline found
    Open

            $query->sql("
    Severity: Minor
    Found in src/DataLayer/Database/SchemaGenerator.php by phpcodesniffer

    Expected 0 spaces before closing bracket; newline found
    Open

            $query->sql("
    Severity: Minor
    Found in src/DataLayer/Database/SchemaGenerator.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status