brollb/webgme-simple-nodes

View on GitHub

Showing 7 of 7 total issues

File SimpleNodes.js has 351 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*globals define*/
/*
 * @author brollb
 *
 * This file creates the virtual node structure to be used by the output
Severity: Minor
Found in src/plugins/SimpleNodes/SimpleNodes.js - About 4 hrs to fix

    Function createVirtualNode has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        SimpleNodes.prototype.createVirtualNode = function(node) {
            var id = this.core.getPath(node),
                attrNames = this.core.getAttributeNames(node),
                ptrNames = this.core.getPointerNames(node),
                tgts,
    Severity: Minor
    Found in src/plugins/SimpleNodes/SimpleNodes.js - About 1 hr to fix

      Function _saveOutput has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          SimpleNodes.prototype._saveOutput = function(filename, filesBlob, callback){
              var self = this,
                  artifact = self.blobClient.createArtifact(filename),
                  files = Object.keys(filesBlob),
                  fileCount = files.length,
      Severity: Minor
      Found in src/plugins/SimpleNodes/SimpleNodes.js - About 1 hr to fix

        Function createChildVirtualNodes has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            SimpleNodes.prototype.createChildVirtualNodes = function(nodeId) {
                var parentNode = this.getNode(nodeId),
                    nodeIds = this.core.getChildrenPaths(parentNode),
                    node,
                    vnode,
        Severity: Minor
        Found in src/plugins/SimpleNodes/SimpleNodes.js - About 1 hr to fix

          Function topologicalSort has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              var topologicalSort = function(nodes, al) {
                  var sortedNodes = [],
                      edgeCounts = {},
                      len = nodes.length,
                      nodeId,
          Severity: Minor
          Found in src/plugins/SimpleNodes/utils.js - About 1 hr to fix

            Strings must use singlequote.
            Open

                    this.logger.debug(`Loading virtual nodes`);

            enforce the consistent use of either backticks, double, or single quotes (quotes)

            JavaScript allows you to define strings in one of three ways: double quotes, single quotes, and backticks (as of ECMAScript 6). For example:

            /*eslint-env es6*/
            
            var double = "double";
            var single = 'single';
            var backtick = `backtick`;    // ES6 only

            Each of these lines creates a string and, in some cases, can be used interchangeably. The choice of how to define strings in a codebase is a stylistic one outside of template literals (which allow embedded of expressions to be interpreted).

            Many codebases require strings to be defined in a consistent manner.

            Rule Details

            This rule enforces the consistent use of either backticks, double, or single quotes.

            Options

            This rule has two options, a string option and an object option.

            String option:

            • "double" (default) requires the use of double quotes wherever possible
            • "single" requires the use of single quotes wherever possible
            • "backtick" requires the use of backticks wherever possible

            Object option:

            • "avoidEscape": true allows strings to use single-quotes or double-quotes so long as the string contains a quote that would have to be escaped otherwise
            • "allowTemplateLiterals": true allows strings to use backticks

            Deprecated: The object property avoid-escape is deprecated; please use the object property avoidEscape instead.

            double

            Examples of incorrect code for this rule with the default "double" option:

            /*eslint quotes: ["error", "double"]*/
            
            var single = 'single';
            var unescaped = 'a string containing "double" quotes';

            Examples of correct code for this rule with the default "double" option:

            /*eslint quotes: ["error", "double"]*/
            /*eslint-env es6*/
            
            var double = "double";
            var backtick = `back\ntick`;  // backticks are allowed due to newline
            var backtick = tag`backtick`; // backticks are allowed due to tag

            single

            Examples of incorrect code for this rule with the "single" option:

            /*eslint quotes: ["error", "single"]*/
            
            var double = "double";
            var unescaped = "a string containing 'single' quotes";

            Examples of correct code for this rule with the "single" option:

            /*eslint quotes: ["error", "single"]*/
            /*eslint-env es6*/
            
            var single = 'single';
            var backtick = `back${x}tick`; // backticks are allowed due to substitution

            backticks

            Examples of incorrect code for this rule with the "backtick" option:

            /*eslint quotes: ["error", "backtick"]*/
            
            var single = 'single';
            var double = "double";
            var unescaped = 'a string containing `backticks`';

            Examples of correct code for this rule with the "backtick" option:

            /*eslint quotes: ["error", "backtick"]*/
            /*eslint-env es6*/
            
            var backtick = `backtick`;

            avoidEscape

            Examples of additional correct code for this rule with the "double", { "avoidEscape": true } options:

            /*eslint quotes: ["error", "double", { "avoidEscape": true }]*/
            
            var single = 'a string containing "double" quotes';

            Examples of additional correct code for this rule with the "single", { "avoidEscape": true } options:

            /*eslint quotes: ["error", "single", { "avoidEscape": true }]*/
            
            var double = "a string containing 'single' quotes";

            Examples of additional correct code for this rule with the "backtick", { "avoidEscape": true } options:

            /*eslint quotes: ["error", "backtick", { "avoidEscape": true }]*/
            
            var double = "a string containing `backtick` quotes"

            allowTemplateLiterals

            Examples of additional correct code for this rule with the "double", { "allowTemplateLiterals": true } options:

            /*eslint quotes: ["error", "double", { "allowTemplateLiterals": true }]*/
            
            var double = "double";
            var double = `double`;

            Examples of additional correct code for this rule with the "single", { "allowTemplateLiterals": true } options:

            /*eslint quotes: ["error", "single", { "allowTemplateLiterals": true }]*/
            
            var single = 'single';
            var single = `single`;

            When Not To Use It

            If you do not need consistency in your string styles, you can safely disable this rule. Source: http://eslint.org/docs/rules/

            TODO found
            Open

                    //TODO the erroneous node should be send to the function
            Severity
            Category
            Status
            Source
            Language