browser-history/browser-history

View on GitHub
browser_history/generic.py

Summary

Maintainability
D
2 days
Test Coverage

File generic.py has 594 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""
This module defines the generic base class and the functionality.

All browsers from :py:mod:`browser_history.browsers` inherit this class.
"""
Severity: Major
Found in browser_history/generic.py - About 1 day to fix

    Function bookmarks_parser has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

        def bookmarks_parser(self, bookmark_path):
            """Returns bookmarks of a single profile for Chrome based browsers
            The returned datetimes are timezone-aware with the local timezone set
            by default
    
    
    Severity: Minor
    Found in browser_history/generic.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function profiles has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        def profiles(self, profile_file) -> typing.List[str]:
            """Returns a list of profile directories. If the browser is supported
            on the current
            platform but is not installed an empty list will be returned
    
    
    Severity: Minor
    Found in browser_history/generic.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __init__ has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def __init__(self, plat: typing.Optional[utils.Platform] = None):
            self.profile_dir_prefixes = []
            if plat is None:
                plat = utils.get_platform()
            homedir = Path.home()
    Severity: Minor
    Found in browser_history/generic.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function fetch_bookmarks has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def fetch_bookmarks(self, bookmarks_paths=None, sort=True, desc=False):
            """Returns bookmarks of all available profiles stored in SQL or JSON
            or plist.
    
            The returned datetimes are timezone-aware with the local timezone set
    Severity: Minor
    Found in browser_history/generic.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function to_json has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def to_json(self, json_lines: bool = False) -> str:
            """
            Return history or bookmarks formatted as a JSON or JSON Lines format
            names. If ``json_lines`` flag is `True` convert to JSON Lines format,
            otherwise convert it to Plain JSON format.
    Severity: Minor
    Found in browser_history/generic.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function fetch_history has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def fetch_history(self, history_paths=None, sort=True, desc=False):
            """Returns history of all available profiles stored in SQL.
    
            The returned datetimes are timezone-aware with the local timezone set
            by default.
    Severity: Minor
    Found in browser_history/generic.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status