brundage/thermostat

View on GitHub

Showing 509 of 509 total issues

Use empty lines between method definitions.
Open

    def initialize(*)
Severity: Minor
Found in lib/thermostat/logger.rb by rubocop

This cop checks whether method definitions are separated by one empty line.

NumberOfEmptyLines can be and integer (e.g. 1 by default) or an array (e.g. [1, 2]) to specificy a minimum and a maximum of empty lines.

AllowAdjacentOneLineDefs can be used to configure is adjacent one line methods definitions are an offense

Example:

# bad
def a
end
def b
end

Example:

# good
def a
end

def b
end

Extra empty line detected at class body end.
Open


  end
Severity: Minor
Found in lib/thermostat/logger.rb by rubocop

This cops checks if empty lines around the bodies of classes match the configuration.

Example: EnforcedStyle: empty_lines

# good

class Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

class Foo
  class Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
class Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

class Foo
  def bar
    # ...
  end
end

Space missing after comma.
Open

    def lookup(s,m,d)
Severity: Minor
Found in lib/thermostat/logger.rb by rubocop

Checks for comma (,) not followed by some kind of space.

Example:

# bad
[1,2]
{ foo:bar,}

# good
[1, 2]
{ foo:bar, }

Surrounding space missing in default value assignment.
Open

    def info(subsystem=nil, msg=nil, &block)
Severity: Minor
Found in lib/thermostat/logger.rb by rubocop

Checks that the equals signs in parameter default assignments have or don't have surrounding space depending on configuration.

Example:

# bad
def some_method(arg1=:default, arg2=nil, arg3=[])
  # do something...
end

# good
def some_method(arg1 = :default, arg2 = nil, arg3 = [])
  # do something...
end

Surrounding space missing in default value assignment.
Open

    def unknown(subsystem=nil, msg=nil, &block)
Severity: Minor
Found in lib/thermostat/logger.rb by rubocop

Checks that the equals signs in parameter default assignments have or don't have surrounding space depending on configuration.

Example:

# bad
def some_method(arg1=:default, arg2=nil, arg3=[])
  # do something...
end

# good
def some_method(arg1 = :default, arg2 = nil, arg3 = [])
  # do something...
end

Trailing whitespace detected.
Open

    end 
Severity: Minor
Found in lib/thermostat/logger.rb by rubocop

Line is too long. [92/80]
Open

                         unknown: UNKNOWN, # An unknown message that should always be logged
Severity: Minor
Found in lib/thermostat/logger.rb by rubocop

Missing top-level class documentation comment.
Open

  class Sensor
Severity: Minor
Found in lib/thermostat/sensor.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

TODO found
Open

    # TODO Implement multi-logger
Severity: Minor
Found in lib/thermostat/logging.rb by fixme
Severity
Category
Status
Source
Language