brynary/webrat

View on GitHub
lib/webrat/core/elements/field.rb

Summary

Maintainability
C
1 day
Test Coverage

File field.rb has 332 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require "cgi"
require "digest/md5"
require "webrat/core_extensions/blank"
require "webrat/core_extensions/nil_to_query_string"

Severity: Minor
Found in lib/webrat/core/elements/field.rb - About 4 hrs to fix

    Class Field has 23 methods (exceeds 20 allowed). Consider refactoring.
    Open

      class Field < Element #:nodoc:
        attr_reader :value
    
        def self.xpath_search
          ".//button|.//input|.//textarea|.//select"
    Severity: Minor
    Found in lib/webrat/core/elements/field.rb - About 2 hrs to fix

      Method build_query_string has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def build_query_string(escape_value=true)
            if @value.is_a?(Array)
              @value.collect {|value| "#{name}=#{ escape_value ? escape(value) : value }" }.join("&")
            else
              "#{name}=#{ escape_value ? escape(value) : value }"
      Severity: Minor
      Found in lib/webrat/core/elements/field.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method label_elements has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def label_elements
            return @label_elements unless @label_elements.nil?
            @label_elements = []
      
            parent = @element.parent
      Severity: Minor
      Found in lib/webrat/core/elements/field.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method field_class has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def self.field_class(element)
            case element.name
            when "button"   then ButtonField
            when "select"
              if element.attributes["multiple"].nil?
      Severity: Minor
      Found in lib/webrat/core/elements/field.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status