brynary/webrat

View on GitHub
lib/webrat/core/session.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Class Session has 34 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Session
    extend Forwardable
    include Logging
    include SaveAndOpenPage

Severity: Minor
Found in lib/webrat/core/session.rb - About 4 hrs to fix

    Method adapter_class has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def self.adapter_class
        case Webrat.configuration.mode
        when :rails
          RailsAdapter
        when :merb
    Severity: Minor
    Found in lib/webrat/core/session.rb - About 1 hr to fix

      Method request_page has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def request_page(url, http_method, data) #:nodoc:
            h = headers
            h['HTTP_REFERER'] = @current_url if @current_url
      
            debug_log "REQUESTING PAGE: #{http_method.to_s.upcase} #{url} with #{data.inspect} and HTTP headers #{h.inspect}"
      Severity: Minor
      Found in lib/webrat/core/session.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status