bsalex/angular-loading-overlay

View on GitHub

Showing 37 of 37 total issues

Function tests has 288 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    tests: function(dependencies: {
        bsLoadingOverlayService: BsLoadingOverlayService,
        $rootScope: angular.IRootScopeService,
        $q: angular.IQService
    }) {
Severity: Major
Found in source/BsLoadingOverlayService.spec.ts - About 1 day to fix

    File BsLoadingOverlayDirective.spec.ts has 542 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import * as angular from 'angular';
    import * as sinon from 'sinon';
    import 'angular-mocks';
    import 'jasmine';
    
    
    Severity: Major
    Found in source/BsLoadingOverlayDirective.spec.ts - About 1 day to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              it('should remove overlay custom class if reference became inactive and update event emitted', () => {
                  bsLoadingOverlayServiceMock.expects('isActive')
                      .twice()
                      .withArgs(referenceId)
                      .onFirstCall()
      Severity: Major
      Found in source/BsLoadingOverlayDirective.spec.ts and 1 other location - About 5 hrs to fix
      source/BsLoadingOverlayDirective.spec.ts on lines 560..578

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 137.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          it('should remove overlay class if reference became inactive and update event emitted', () => {
              bsLoadingOverlayServiceMock.expects('isActive')
                  .twice()
                  .withArgs(referenceId)
                  .onFirstCall()
      Severity: Major
      Found in source/BsLoadingOverlayDirective.spec.ts and 1 other location - About 5 hrs to fix
      source/BsLoadingOverlayDirective.spec.ts on lines 614..632

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 137.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      File BsLoadingOverlayService.spec.ts has 304 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      import * as angular from 'angular';
      import * as sinon from 'sinon';
      
      import BsLoadingOverlayModule from './BsLoadingOverlayModule';
      import {BsLoadingOverlayService} from './BsLoadingOverlayService';
      Severity: Minor
      Found in source/BsLoadingOverlayService.spec.ts - About 3 hrs to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            it('should add overlay when reference is active', () => {
                bsLoadingOverlayServiceMock.expects('isActive').once().withArgs(referenceId).returns(true);
        
                const element = getCompiledElement(template, scope);
        
        
        Severity: Major
        Found in source/BsLoadingOverlayDirective.spec.ts and 1 other location - About 3 hrs to fix
        source/BsLoadingOverlayDirective.spec.ts on lines 162..169

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 99.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                it('should add overlay when reference is active', () => {
                    bsLoadingOverlayServiceMock.expects('isActive').once().withArgs(referenceId).returns(true);
        
                    const element = getCompiledElement(template, scope);
        
        
        Severity: Major
        Found in source/BsLoadingOverlayDirective.spec.ts and 1 other location - About 3 hrs to fix
        source/BsLoadingOverlayDirective.spec.ts on lines 90..97

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 99.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                it('should not add overlay when reference is not active', () => {
                    bsLoadingOverlayServiceMock.expects('isActive').once().withArgs(referenceId).returns(false);
        
                    const element = getCompiledElement(template, scope);
        
        
        Severity: Major
        Found in source/BsLoadingOverlayDirective.spec.ts and 1 other location - About 3 hrs to fix
        source/BsLoadingOverlayDirective.spec.ts on lines 139..146

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 95.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            it('should not add overlay when reference is not active', () => {
                bsLoadingOverlayServiceMock.expects('isActive').once().withArgs(referenceId).returns(false);
        
                const element = getCompiledElement(template, scope);
        
        
        Severity: Major
        Found in source/BsLoadingOverlayDirective.spec.ts and 1 other location - About 3 hrs to fix
        source/BsLoadingOverlayDirective.spec.ts on lines 153..160

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 95.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        interface IBsLoadingOverlayHandler {
            start: () => void;
            stop: () => void;
            wrap: (promiseFunction: angular.IPromise<any> | (() => (angular.IPromise<any> | {}))) => angular.IPromise<any>;
        }
        Severity: Major
        Found in source/IBsLoadingOverlayHandler.ts and 1 other location - About 2 hrs to fix
        dist/IBsLoadingOverlayHandler.d.ts on lines 3..7

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 93.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        interface IBsLoadingOverlayHandler {
            start: () => void;
            stop: () => void;
            wrap: (promiseFunction: angular.IPromise<any> | (() => (angular.IPromise<any> | {}))) => angular.IPromise<any>;
        }
        Severity: Major
        Found in dist/IBsLoadingOverlayHandler.d.ts and 1 other location - About 2 hrs to fix
        source/IBsLoadingOverlayHandler.ts on lines 2..6

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 93.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            it('should not add overlay class when it is false in global config and not provided to directive', () => {
                defaultConfig.activeClass = undefined;
                bsLoadingOverlayServiceMock.expects('isActive').once().withArgs(referenceId).returns(true);
        
                const element = getCompiledElement(template, scope);
        Severity: Major
        Found in source/BsLoadingOverlayDirective.spec.ts and 1 other location - About 2 hrs to fix
        source/BsLoadingOverlayDirective.spec.ts on lines 542..549

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 92.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            it('should add overlay class when reference is active event if templateUrl is false', () => {
                defaultConfig.templateUrl = undefined;
                bsLoadingOverlayServiceMock.expects('isActive').once().withArgs(referenceId).returns(true);
        
                const element = getCompiledElement(template, scope);
        Severity: Major
        Found in source/BsLoadingOverlayDirective.spec.ts and 1 other location - About 2 hrs to fix
        source/BsLoadingOverlayDirective.spec.ts on lines 551..558

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 92.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    it('should emit rootScope event on stop with referenceId in options', (done) => {
                        dependencies.$rootScope.$on('bsLoadingOverlayUpdateEvent', (event, options) => {
                            expect(options.referenceId).toEqual(referenceId);
                            done();
                        });
        Severity: Major
        Found in source/BsLoadingOverlayService.spec.ts and 1 other location - About 2 hrs to fix
        source/BsLoadingOverlayService.spec.ts on lines 295..304

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 83.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    it('should emit rootScope event on start with referenceId in options', (done) => {
                        dependencies.$rootScope.$on('bsLoadingOverlayUpdateEvent', (event, options) => {
                            expect(options.referenceId).toEqual(referenceId);
                            done();
                        });
        Severity: Major
        Found in source/BsLoadingOverlayService.spec.ts and 1 other location - About 2 hrs to fix
        source/BsLoadingOverlayService.spec.ts on lines 306..315

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 83.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function exports has 59 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        module.exports = function(config) {
            config.set({
        
                // base path that will be used to resolve all patterns (eg. files, exclude)
                basePath: '',
        Severity: Major
        Found in karma.conf.js - About 2 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              it('should add overlay class when reference is active', () => {
                  bsLoadingOverlayServiceMock.expects('isActive').once().withArgs(referenceId).returns(true);
          
                  const element = getCompiledElement(template, scope);
          
          
          Severity: Major
          Found in source/BsLoadingOverlayDirective.spec.ts and 1 other location - About 2 hrs to fix
          source/BsLoadingOverlayDirective.spec.ts on lines 606..612

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 81.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  it('should add overlay custom class when reference is active', () => {
                      bsLoadingOverlayServiceMock.expects('isActive').once().withArgs(referenceId).returns(true);
          
                      const element = getCompiledElement(template, scope);
          
          
          Severity: Major
          Found in source/BsLoadingOverlayDirective.spec.ts and 1 other location - About 2 hrs to fix
          source/BsLoadingOverlayDirective.spec.ts on lines 534..540

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 81.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function BsLoadingOverlayDirective has 52 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              var BsLoadingOverlayDirective = (function () {
                  function BsLoadingOverlayDirective($compile, $rootScope, $templateRequest, $q, $timeout, bsLoadingOverlayService) {
                      var _this = this;
                      this.$compile = $compile;
                      this.$rootScope = $rootScope;
          Severity: Major
          Found in dist/angular-loading-overlay.js - About 2 hrs to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        it('should emit rootScope event on start with referenceId in options', (done) => {
                            dependencies.$rootScope.$on('bsLoadingOverlayUpdateEvent', (event, options) => {
                                expect(options.referenceId).toEqual(referenceId);
                                done();
                            });
            Severity: Major
            Found in source/BsLoadingOverlayService.spec.ts and 1 other location - About 1 hr to fix
            source/BsLoadingOverlayService.spec.ts on lines 42..49

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 72.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language