bskim45/fastlane-plugin-google_drive

View on GitHub

Showing 13 of 13 total issues

Method available_options has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

      def self.available_options
        [
          FastlaneCore::ConfigItem.new(key: :drive_keyfile,
                                      env_name: 'GDRIVE_KEY_FILE',
                                      description: 'Json config file',

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method available_options has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def self.available_options
        [
          FastlaneCore::ConfigItem.new(key: :drive_keyfile,
                                      env_name: 'GDRIVE_KEY_FILE',
                                      description: 'Json config file',

    Method available_options has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

          def self.available_options
            [
              FastlaneCore::ConfigItem.new(key: :drive_keyfile,
                                          env_name: 'GDRIVE_KEY_FILE',
                                          description: 'Json config file',

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method available_options has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def self.available_options
            [
              FastlaneCore::ConfigItem.new(key: :drive_keyfile,
                                          env_name: 'GDRIVE_KEY_FILE',
                                          description: 'Json config file',

      Method available_options has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def self.available_options
              [
                FastlaneCore::ConfigItem.new(key: :drive_keyfile,
                                             env_name: 'GDRIVE_KEY_FILE',
                                             description: 'Json config file',

        Method available_options has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

              def self.available_options
                [
                  FastlaneCore::ConfigItem.new(key: :drive_keyfile,
                                               env_name: 'GDRIVE_KEY_FILE',
                                               description: 'Json config file',

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method run has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def self.run(params)
                UI.message("Using config file: #{params[:drive_keyfile]}")
        
                session = Helper::GoogleDriveHelper.setup(
                  keyfile: params[:drive_keyfile],

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

                    FastlaneCore::ConfigItem.new(key: :drive_keyfile,
                                                 env_name: 'GDRIVE_KEY_FILE',
                                                 description: 'Json config file',
                                                 type: String,
                                                 default_value: 'drive_key.json',
          lib/fastlane/plugin/google_drive/actions/update_google_drive_file_action.rb on lines 49..56
          lib/fastlane/plugin/google_drive/actions/upload_to_google_drive_action.rb on lines 59..66

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 28.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

                    FastlaneCore::ConfigItem.new(key: :drive_keyfile,
                                                env_name: 'GDRIVE_KEY_FILE',
                                                description: 'Json config file',
                                                type: String,
                                                default_value: 'drive_key.json',
          lib/fastlane/plugin/google_drive/actions/create_google_drive_folder_action.rb on lines 50..57
          lib/fastlane/plugin/google_drive/actions/upload_to_google_drive_action.rb on lines 59..66

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 28.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

                    FastlaneCore::ConfigItem.new(key: :drive_keyfile,
                                                env_name: 'GDRIVE_KEY_FILE',
                                                description: 'Json config file',
                                                type: String,
                                                default_value: 'drive_key.json',
          lib/fastlane/plugin/google_drive/actions/create_google_drive_folder_action.rb on lines 50..57
          lib/fastlane/plugin/google_drive/actions/update_google_drive_file_action.rb on lines 49..56

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 28.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                    FastlaneCore::ConfigItem.new(key: :folder_id,
                                                env_name: "GDRIVE_UPLOAD_FOLDER_ID",
                                                description: "Upload target folder id",
                                                optional: false,
                                                type: String,
          lib/fastlane/plugin/google_drive/actions/create_google_drive_folder_action.rb on lines 64..71
          lib/fastlane/plugin/google_drive/actions/update_google_drive_file_action.rb on lines 63..70

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 27.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                    FastlaneCore::ConfigItem.new(key: :folder_id,
                                                 env_name: "GDRIVE_UPLOAD_FOLDER_ID",
                                                 description: "Upload target folder id",
                                                 optional: false,
                                                 type: String,
          lib/fastlane/plugin/google_drive/actions/update_google_drive_file_action.rb on lines 63..70
          lib/fastlane/plugin/google_drive/actions/upload_to_google_drive_action.rb on lines 73..80

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 27.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                    FastlaneCore::ConfigItem.new(key: :file_id,
                                                env_name: "GDRIVE_UPDATE_FILE_ID",
                                                description: "Target file id to update the content",
                                                optional: false,
                                                type: String,
          lib/fastlane/plugin/google_drive/actions/create_google_drive_folder_action.rb on lines 64..71
          lib/fastlane/plugin/google_drive/actions/upload_to_google_drive_action.rb on lines 73..80

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 27.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language