Sign upLogin

bueltge/wp-rest-api-filter-items

View on GitHub
Star

Showing 85 of 85 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

<?php # -*- coding: utf-8 -*-

namespace RestApiFilterItems\Items;

use RestApiFilterItems\Core\Filter;
Severity: Major
Found in inc/Items/Post.php and 2 other locations - About 1 hr to fix
inc/Items/Comments.php on lines 1..44
inc/Items/Taxonomy.php on lines 1..44

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 115.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

<?php # -*- coding: utf-8 -*-

namespace RestApiFilterItems\Items;

use RestApiFilterItems\Core\Filter;
Severity: Major
Found in inc/Items/Taxonomy.php and 2 other locations - About 1 hr to fix
inc/Items/Comments.php on lines 1..44
inc/Items/Post.php on lines 1..49

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 115.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

<?php # -*- coding: utf-8 -*-

namespace RestApiFilterItems\Items;

use RestApiFilterItems\Core\Filter;
Severity: Major
Found in inc/Items/Comments.php and 2 other locations - About 1 hr to fix
inc/Items/Post.php on lines 1..49
inc/Items/Taxonomy.php on lines 1..44

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 115.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

The parameter $file_loader is not named in camelCase.
Open

    function __construct( $base_dir, $base_ns = '', Loader\FileLoaderInterface $file_loader = NULL ) {

        // trim potential trailing slashes
        $this->base_dir = rtrim( (string) $base_dir, '\\/' );
Severity: Minor
Found in lib/Requisite/Rule/NamespaceDirectoryMapper.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The property $base_ns is not named in camelCase.
Open

class NamespaceDirectoryMapper implements AutoLoadRuleInterface {

    /**
     * @type Loader\FileLoaderInterface
     */
Severity: Minor
Found in lib/Requisite/Rule/NamespaceDirectoryMapper.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $file_loader is not named in camelCase.
Open

class NamespaceDirectoryMapper implements AutoLoadRuleInterface {

    /**
     * @type Loader\FileLoaderInterface
     */
Severity: Minor
Found in lib/Requisite/Rule/NamespaceDirectoryMapper.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $base_dir is not named in camelCase.
Open

class NamespaceDirectoryMapper implements AutoLoadRuleInterface {

    /**
     * @type Loader\FileLoaderInterface
     */
Severity: Minor
Found in lib/Requisite/Rule/NamespaceDirectoryMapper.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $base_dir is not named in camelCase.
Open

class DirectoryCacheFileLoader implements FileLoaderInterface {

    /**
     * @type array
     */
Severity: Minor
Found in lib/Requisite/Loader/DirectoryCacheFileLoader.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The parameter $base_dir is not named in camelCase.
Open

    public static function init( $base_dir = '' ) {

        if ( self::$is_loaded )
            return;
Severity: Minor
Found in lib/Requisite/Requisite.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $base_dir is not named in camelCase.
Open

    function __construct( $base_dir, $extension = '.php' ) {

        $this->base_dir  = (string) $base_dir;
        $this->extension = (string) $extension;
    }
Severity: Minor
Found in lib/Requisite/Loader/DirectoryCacheFileLoader.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $base_dir is not named in camelCase.
Open

    function __construct( $base_dir, $base_ns = '', Loader\FileLoaderInterface $file_loader = NULL ) {

        // trim potential trailing slashes
        $this->base_dir = rtrim( (string) $base_dir, '\\/' );
Severity: Minor
Found in lib/Requisite/Rule/NamespaceDirectoryMapper.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The property $is_loaded is not named in camelCase.
Open

class Requisite {

    /**
     * @type bool
     */
Severity: Minor
Found in lib/Requisite/Requisite.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The parameter $base_ns is not named in camelCase.
Open

    function __construct( $base_dir, $base_ns = '', Loader\FileLoaderInterface $file_loader = NULL ) {

        // trim potential trailing slashes
        $this->base_dir = rtrim( (string) $base_dir, '\\/' );
Severity: Minor
Found in lib/Requisite/Rule/NamespaceDirectoryMapper.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The method __construct has a boolean flag argument $append, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function __construct( $append = TRUE, $throws = FALSE ) {
Severity: Minor
Found in lib/Requisite/SPLAutoLoader.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method __construct has a boolean flag argument $throws, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function __construct( $append = TRUE, $throws = FALSE ) {
Severity: Minor
Found in lib/Requisite/SPLAutoLoader.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Avoid using static access to class '\Requisite\Requisite' in method 'init_requisite'.
Open

    Requisite\Requisite::init();
Severity: Minor
Found in inc/init-requisite.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

__construct accesses the super-global variable $_GET.
Open

    public function __construct() {

        if ( ! isset( $_GET[ 'items' ] ) ) {
            return;
        }
Severity: Minor
Found in inc/Items/Comments.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

__construct accesses the super-global variable $_GET.
Open

    public function __construct() {

        if ( ! isset( $_GET[ 'items' ] ) ) {
            return;
        }
Severity: Minor
Found in inc/Items/Comments.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

__construct accesses the super-global variable $_GET.
Open

    public function __construct() {

        if ( ! isset( $_GET[ 'items' ] ) ) {
            return;
        }
Severity: Minor
Found in inc/Items/Taxonomy.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

__construct accesses the super-global variable $_GET.
Open

    public function __construct() {

        if ( ! isset( $_GET[ 'items' ] ) ) {
            return;
        }
Severity: Minor
Found in inc/Items/Post.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

Severity
Category
Status
Source
Language