Sign upLogin

bugsnag/bugsnag-js

View on GitHub
Star
packages/react-native-cli/src/lib/Gradle.ts

Summary

Maintainability
D
2 days
Test Coverage

Function getSuggestedBugsnagGradleVersion has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

export async function getSuggestedBugsnagGradleVersion (projectRoot: string, logger: Logger): Promise<string> {
  let fileContents: string
  try {
    fileContents = await fs.readFile(path.join(projectRoot, 'android', 'build.gradle'), 'utf8')
  } catch (e) {
Severity: Minor
Found in packages/react-native-cli/src/lib/Gradle.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function addBuildEndpoint has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export async function addBuildEndpoint (projectRoot: string, buildEndpoint: string, logger: Logger): Promise<void> {
  try {
    const appBuildGradlePath = path.join(projectRoot, 'android', 'app', 'build.gradle')

    await insertBugsnagConfigBlock(appBuildGradlePath, logger)
Severity: Minor
Found in packages/react-native-cli/src/lib/Gradle.ts - About 1 hr to fix

    Function addUploadEndpoint has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export async function addUploadEndpoint (projectRoot: string, uploadEndpoint: string, logger: Logger): Promise<void> {
  try {
    const appBuildGradlePath = path.join(projectRoot, 'android', 'app', 'build.gradle')

    await insertBugsnagConfigBlock(appBuildGradlePath, logger)
    Severity: Minor
    Found in packages/react-native-cli/src/lib/Gradle.ts - About 1 hr to fix

      Function getSuggestedBugsnagGradleVersion has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export async function getSuggestedBugsnagGradleVersion (projectRoot: string, logger: Logger): Promise<string> {
  let fileContents: string
  try {
    fileContents = await fs.readFile(path.join(projectRoot, 'android', 'build.gradle'), 'utf8')
  } catch (e) {
      Severity: Minor
      Found in packages/react-native-cli/src/lib/Gradle.ts - About 1 hr to fix

        Function modifyAppBuildGradle has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export async function modifyAppBuildGradle (projectRoot: string, logger: Logger): Promise<void> {
  logger.debug('Looking for android/app/build.gradle')
  const appBuildGradlePath = path.join(projectRoot, 'android', 'app', 'build.gradle')
  logger.debug('Applying com.bugsnag.android.gradle plugin')
        Severity: Minor
        Found in packages/react-native-cli/src/lib/Gradle.ts - About 1 hr to fix

          Function modifyRootBuildGradle has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export async function modifyRootBuildGradle (projectRoot: string, pluginVersion: string, logger: Logger): Promise<void> {
  logger.debug('Looking for android/build.gradle')
  const topLevelBuildGradlePath = path.join(projectRoot, 'android', 'build.gradle')
  logger.debug('Adding \'bugsnag-android-gradle-plugin\' to the build script classpath')
  try {
          Severity: Minor
          Found in packages/react-native-cli/src/lib/Gradle.ts - About 1 hr to fix

            Function insertValueAfterPattern has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            async function insertValueAfterPattern (file: string, patterns: RegExp[], value: string, presencePattern: RegExp, logger: Logger): Promise<void> {
            Severity: Minor
            Found in packages/react-native-cli/src/lib/Gradle.ts - About 35 mins to fix

              Avoid too many return statements within this function.
              Open

                    return '7.+'
              Severity: Major
              Found in packages/react-native-cli/src/lib/Gradle.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return '8.+'
                Severity: Major
                Found in packages/react-native-cli/src/lib/Gradle.ts - About 30 mins to fix

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                    try {
    const appBuildGradlePath = path.join(projectRoot, 'android', 'app', 'build.gradle')

    await insertBugsnagConfigBlock(appBuildGradlePath, logger)
                  Severity: Major
                  Found in packages/react-native-cli/src/lib/Gradle.ts and 2 other locations - About 3 hrs to fix
                  packages/react-native-cli/src/lib/Gradle.ts on lines 101..129
                  packages/react-native-cli/src/lib/Gradle.ts on lines 219..259

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 98.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                    try {
    const appBuildGradlePath = path.join(projectRoot, 'android', 'app', 'build.gradle')

    await insertBugsnagConfigBlock(appBuildGradlePath, logger)
                  Severity: Major
                  Found in packages/react-native-cli/src/lib/Gradle.ts and 2 other locations - About 3 hrs to fix
                  packages/react-native-cli/src/lib/Gradle.ts on lines 101..129
                  packages/react-native-cli/src/lib/Gradle.ts on lines 175..215

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 98.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                    try {
    await insertValueAfterPattern(
      appBuildGradlePath,
      [/^apply from: ["']\.\.\/\.\.\/node_modules\/react-native\/react\.gradle["']$/m, /^apply from: file\(["']..\/\.\.\/node_modules\/@react-native-community\/cli-platform-android\/native_modules\.gradle["']\); applyNativeModulesAppBuildGradle\(project\)$/m],
      GRADLE_PLUGIN_APPLY,
                  Severity: Major
                  Found in packages/react-native-cli/src/lib/Gradle.ts and 2 other locations - About 3 hrs to fix
                  packages/react-native-cli/src/lib/Gradle.ts on lines 175..215
                  packages/react-native-cli/src/lib/Gradle.ts on lines 219..259

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 98.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status