bukalapak/bukalapak.js

View on GitHub

Showing 3 of 3 total issues

Function formatRequest has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  formatRequest (reqUrl, options) {
    let appendTokenToUrl = (url, token) => {
      let qs = urlParse(url).query;
      let sep = isBlank(qs) ? '?' : '&';
      return url + sep + `access_token=${token.access_token}`;
Severity: Minor
Found in src/auth.js - About 1 hr to fix

    Function constructor has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      constructor (client, options) {
        this.client = client;
        this.options = {
          isBlank (key) { return isBlank(this[key]); },
          validate (keys, message) {
    Severity: Minor
    Found in src/auth.js - About 1 hr to fix

      Function formatRequest has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        formatRequest (reqUrl, options) {
          let appendTokenToUrl = (url, token) => {
            let qs = urlParse(url).query;
            let sep = isBlank(qs) ? '?' : '&';
            return url + sep + `access_token=${token.access_token}`;
      Severity: Minor
      Found in src/auth.js - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language