Sign upLogin

buren/site_mapper

View on GitHub
Star

Showing 4 of 4 total issues

Method allowed? has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

      def allowed?(uri, user_agent)
        return true unless @parsed
        allowed = true
        path    = uri.request_uri
Severity: Minor
Found in lib/site_mapper/robots.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def parse(body)
        agent = /.*/
        body  = body || "User-agent: *\nAllow: /\n"
        body  = body.downcase
        body.each_line.each do |line|
Severity: Minor
Found in lib/site_mapper/robots.rb - About 1 hr to fix

    Method eligible_url? has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def eligible_url?(href)
      return false if href.nil? || href.empty?
      dont_start   = %w(javascript: callto: mailto: tel: skype: facetime: wtai: #)
      dont_include = %w(/email-protection#)
      err_include  = %w(/sorry/IndexRedirect?)
    Severity: Minor
    Found in lib/site_mapper/crawl_url.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method parse has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

          def parse(body)
        agent = /.*/
        body  = body || "User-agent: *\nAllow: /\n"
        body  = body.downcase
        body.each_line.each do |line|
    Severity: Minor
    Found in lib/site_mapper/robots.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language