Sign upLogin

burke/zeus

View on GitHub
Star

Showing 28 of 28 total issues

Method SlaveNode.forceKillPid has 6 return statements (exceeds 4 allowed).
Open

func (s *SlaveNode) forceKillPid(pid int) error {
    if pid <= 0 {
        return nil
    }
Severity: Major
Found in go/processtree/slavenode.go - About 40 mins to fix

    Function sendClientPidAndArgumentsToCommand has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    func sendClientPidAndArgumentsToCommand(commandUsock *unixsocket.Usock, clientPid int, argCount int, argFD int, err error) error {
    Severity: Minor
    Found in go/clienthandler/clienthandler.go - About 35 mins to fix

      Function buildFileMonitor has 5 return statements (exceeds 4 allowed).
      Open

      func buildFileMonitor(fileChangeDelay time.Duration) (filemonitor.FileMonitor, error) {
    if portStr := os.Getenv(listenerPortVar); portStr != "" {
        port, err := strconv.Atoi(portStr)
        if err != nil {
            return nil, fmt.Errorf("%s must be an integer or empty string: %v", listenerPortVar, err)
      Severity: Major
      Found in go/zeusmaster/zeusmaster.go - About 35 mins to fix

        Function extractFileDescriptorFromOOB has 5 return statements (exceeds 4 allowed).
        Open

        func extractFileDescriptorFromOOB(oob []byte) (int, error) {
    scms, err := syscall.ParseSocketControlMessage(oob)
    if err != nil {
        return -1, err
    }
        Severity: Major
        Found in go/unixsocket/oobreader.go - About 35 mins to fix

          Method suites has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

                def suites
        # Since we're not using `ruby -Itest -Ilib` to run the tests, we need to add this directory to the `LOAD_PATH`
        $:.unshift "./test", "./lib"

        if framework == :testunit1
          Severity: Minor
          Found in rubygem/lib/zeus/m.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  def process_watched_files(buf)
          lines = buf.sub(/.*\z/, '').split(/\n/)
          remaining = buf.sub(/\A.*\n/m, '')

          lines.each do |line|
          Severity: Minor
          Found in vagrant/lib/vagrant-zeus/commands/zeus-file-monitor.rb and 1 other location - About 25 mins to fix
          vagrant/lib/vagrant-zeus/commands/zeus-file-monitor.rb on lines 76..87

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 31.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  def process_modified_files(buf)
          lines = buf.sub(/.*\z/, '').split(/\n/)
          remaining = buf.sub(/\A.*\n/m, '')

          lines.each do |line|
          Severity: Minor
          Found in vagrant/lib/vagrant-zeus/commands/zeus-file-monitor.rb and 1 other location - About 25 mins to fix
          vagrant/lib/vagrant-zeus/commands/zeus-file-monitor.rb on lines 90..101

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 31.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method fileListener.handleConnection has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
          Open

          func (f *fileListener) handleConnection(conn net.Conn, ch chan string) {
    // Handle writes
    stop := make(chan struct{})
    go func() {
        for {
          Severity: Minor
          Found in go/filemonitor/filelistener.go - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language