Sign upLogin

busy-web/ember-date-time

View on GitHub
Star
addon/components/ember-date-time-picker.js

Summary

Maintainability
F
3 days
Test Coverage

Function setupTime has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    setupTime() {
        let timestamp = get(this, 'timestamp');
        let unix = get(this, 'unix');
        let minDate = get(this, 'minDate');
        let maxDate = get(this, 'maxDate');
Severity: Minor
Found in addon/components/ember-date-time-picker.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File ember-date-time-picker.js has 288 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * @module Components
 *
 */
import $ from 'jquery';
Severity: Minor
Found in addon/components/ember-date-time-picker.js - About 2 hrs to fix

    Function setActiveState has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        setActiveState(options={}) {
        if (isNone(get(this, 'stateManager'))) {
            this.setState();
        }
    Severity: Minor
    Found in addon/components/ember-date-time-picker.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function setActiveState has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        setActiveState(options={}) {
        if (isNone(get(this, 'stateManager'))) {
            this.setState();
        }
    Severity: Minor
    Found in addon/components/ember-date-time-picker.js - About 1 hr to fix

      Function setupTime has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          setupTime() {
        let timestamp = get(this, 'timestamp');
        let unix = get(this, 'unix');
        let minDate = get(this, 'minDate');
        let maxDate = get(this, 'maxDate');
      Severity: Minor
      Found in addon/components/ember-date-time-picker.js - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                            if (!isNone(maxDate)) { max = _time.utcToLocal(maxDate).timestamp(); }
        Severity: Major
        Found in addon/components/ember-date-time-picker.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                              if (!isNone(minDate)) { min = _time.utcToLocal(minDate).timestamp(); }
          Severity: Major
          Found in addon/components/ember-date-time-picker.js - About 45 mins to fix

            Function focusState has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                focusState(section) {
        let el = this.$(`input`);
        if (el && el.length) {
            let index;
            if (!isEmpty(section)) {
            Severity: Minor
            Found in addon/components/ember-date-time-picker.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    focusAction(evt, section) {
            if (!this.get('stateChangeInProgress')) {
                this.set('stateChangeInProgress', true);
                if (section === `m-${HOUR_FLAG}`) {
                    section = HOUR_FLAG;
            Severity: Major
            Found in addon/components/ember-date-time-picker.js and 1 other location - About 3 hrs to fix
            addon/components/ember-date-time-picker.js on lines 394..404

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 108.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    stateChange(section) {
            if (!this.get('stateChangeInProgress')) {
                this.set('stateChangeInProgress', true);
                if (section === `m-${HOUR_FLAG}`) {
                    section = HOUR_FLAG;
            Severity: Major
            Found in addon/components/ember-date-time-picker.js and 1 other location - About 3 hrs to fix
            addon/components/ember-date-time-picker.js on lines 412..422

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 108.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            if (get(this, 'utc')) {
                    time = _time.utcToLocal(timestamp).timestamp();
                    if (!isNone(minDate)) { min = _time.utcToLocal(minDate).timestamp(); }
                    if (!isNone(maxDate)) { max = _time.utcToLocal(maxDate).timestamp(); }
                }
            Severity: Major
            Found in addon/components/ember-date-time-picker.js and 1 other location - About 3 hrs to fix
            addon/components/ember-date-time-picker.js on lines 197..201

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 104.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            if (get(this, 'utc')) {
                    time = _time.utcToLocal(time).timestamp();
                    if (!isNone(minDate)) { min = _time.utcToLocal(min).timestamp(); }
                    if (!isNone(maxDate)) { max = _time.utcToLocal(max).timestamp(); }
                }
            Severity: Major
            Found in addon/components/ember-date-time-picker.js and 1 other location - About 3 hrs to fix
            addon/components/ember-date-time-picker.js on lines 203..207

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 104.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status