Sign upLogin

busy-web/ember-date-time

View on GitHub
Star
addon/components/private/date-picker.js

Summary

Maintainability
C
1 day
Test Coverage

Function buildDaysArrayForMonth has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

  buildDaysArrayForMonth: function() {
        const calendarDate = get(this, 'calendarDate');
    const minDate =    get(this, 'stateManager.minDate');
    const maxDate = get(this, 'stateManager.maxDate');
        let [ startRange, endRange ] = (get(this, 'stateManager.range') || []);
Severity: Minor
Found in addon/components/private/date-picker.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function buildDaysArrayForMonth has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  buildDaysArrayForMonth: function() {
        const calendarDate = get(this, 'calendarDate');
    const minDate =    get(this, 'stateManager.minDate');
    const maxDate = get(this, 'stateManager.maxDate');
        let [ startRange, endRange ] = (get(this, 'stateManager.range') || []);
Severity: Major
Found in addon/components/private/date-picker.js - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        subtractMonth() {
            // get next date
            const calTime = getPrevDate(get(this, 'calendarDate'));

            if (!this.isBeforeMin(calTime)) {
    Severity: Major
    Found in addon/components/private/date-picker.js and 1 other location - About 1 hr to fix
    addon/components/private/date-picker.js on lines 459..470

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 73.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            addMonth() {
            // get next date
            const calTime = getNextDate(get(this, 'calendarDate'));

            if (!this.isAfterMax(calTime)) {
    Severity: Major
    Found in addon/components/private/date-picker.js and 1 other location - About 1 hr to fix
    addon/components/private/date-picker.js on lines 441..452

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 73.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        isAfterMax(time) {
        // if the timestamp gets set to a date after the
        // maxDate then allow the forward arrow to go forward as
        // far as the current timestamp
        if (_time.isDateAfter(get(this, 'timestamp'), time)) {
    Severity: Minor
    Found in addon/components/private/date-picker.js and 1 other location - About 55 mins to fix
    addon/components/private/date-picker.js on lines 383..391

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        isBeforeMin(time) {
        // if the timestamp gets set to a date before the
        // minDate then allow the back arrow to go back as
        // far as the current timestamp
        if (_time.isDateBefore(get(this, 'timestamp'), time)) {
    Severity: Minor
    Found in addon/components/private/date-picker.js and 1 other location - About 55 mins to fix
    addon/components/private/date-picker.js on lines 393..401

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status