Sign upLogin

bykovme/nswallet

View on GitHub
Star

Showing 488 of 488 total issues

File FontAwesome.cs has 1371 lines of code (exceeds 250 allowed). Consider refactoring.
Open

using System;
namespace NSWallet.NetStandard.Helpers.Fonts
{
    public class FontAwesome
    {
Severity: Major
Found in src/NSWallet/NSWallet/Helpers/Fonts/FontAwesome.cs - About 3 days to fix

    File MainScreenViewModel.cs has 1266 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    using System;
using System.Collections.Generic;
using System.ComponentModel;
using NSWallet.Shared;
using Xamarin.Forms;
    Severity: Major
    Found in src/NSWallet/NSWallet/ViewModel/MainScreen/MainScreenViewModel.cs - About 3 days to fix

      File SettingsScreenViewModel.cs has 1180 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      using System;
using System.ComponentModel;
using NSWallet.Shared;
using NSWallet.Helpers;
using Xamarin.Forms;
      Severity: Major
      Found in src/NSWallet/NSWallet/ViewModel/SettingsScreen/SettingsScreenViewModel.cs - About 3 days to fix

        File ManageFieldViewModel.cs has 832 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        using System;
using System.Collections.Generic;
using System.Linq;
using System.Text.RegularExpressions;
using System.Threading.Tasks;
        Severity: Major
        Found in src/NSWallet/NSWallet/ViewModel/MainScreen/Fields/ManageFieldViewModel.cs - About 2 days to fix

          File NSWalletDB.cs has 730 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          using SQLite;
using System;
using System.Linq;
using NSWallet.Shared.Helpers.Logs.AppLog;
using System.Collections.Generic;
          Severity: Major
          Found in src/NSWallet/NSWallet.Shared/Database/NSWalletDB.cs - About 1 day to fix

            File Settings.cs has 562 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            using System;
using NSWallet.Shared;
using Plugin.Settings;
using Plugin.Settings.Abstractions;
            Severity: Major
            Found in src/NSWallet/NSWallet/Helpers/Settings.cs - About 1 day to fix

              File MainScreenView.cs has 558 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              using System;
using System.Linq;
using FFImageLoading.Forms;
using ImageCircle.Forms.Plugin.Abstractions;
using NSWallet.Consts;
              Severity: Major
              Found in src/NSWallet/NSWallet/Views/MainScreen/MainScreenView.cs - About 1 day to fix

                File PremiumManagement.cs has 553 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                using System;
using System.Collections.Generic;
using System.Diagnostics;
using System.Linq;
using System.Threading.Tasks;
                Severity: Major
                Found in src/NSWallet/NSWallet/Premium/PremiumManagement.cs - About 1 day to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                              return new Dictionary<string, string> {
                { "accesspoint", "category_internet" },
                { "airplane", "category_travelling" },
                { "amazon", "category_internet" },
                { "americanexpress", "category_finances" },
                  Severity: Major
                  Found in src/NSWallet/NSWallet/ViewModel/MainScreen/ItemCreation/IconGroups.cs and 1 other location - About 1 day to fix
                  src/NSWallet/NSWallet/Helpers/IconGroupsHandler.cs on lines 10..154

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 583.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          public static Dictionary<string, string> IconsWithGroups = new Dictionary<string, string> {
            { "document",  "group_common" },
            { "accesspoint",  "group_common" },
            { "airplane",  "group_common" },
            { "amazon",  "group_stores" },
                  Severity: Major
                  Found in src/NSWallet/NSWallet/Helpers/IconGroupsHandler.cs and 1 other location - About 1 day to fix
                  src/NSWallet/NSWallet/ViewModel/MainScreen/ItemCreation/IconGroups.cs on lines 83..227

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 583.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  File DataAccessLayer.cs has 514 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  using System;
using System.Collections.Generic;
using System.Diagnostics;
using System.IO;
using System.Threading.Tasks;
                  Severity: Major
                  Found in src/NSWallet/NSWallet.Shared/DataAccess/DataAccessLayer.cs - About 1 day to fix

                    File SettingsScreenView.cs has 505 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    using System.Collections.Generic;
using FFImageLoading.Forms;
using NSWallet.Controls.EntryPopup;
using NSWallet.Helpers;
using NSWallet.NetStandard;
                    Severity: Major
                    Found in src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs - About 1 day to fix

                      Method ExecuteLoginCommand has a Cognitive Complexity of 64 (exceeds 20 allowed). Consider refactoring.
                      Open

                              protected void ExecuteLoginCommand(object obj)
        {
            if (LicenseController.CheckPrivacyPolicy()) {
                if (LicenseController.CheckTermsOfUse()) {
                    AnimationStatus = 0; // 0 - Nothing happened
                      Severity: Minor
                      Found in src/NSWallet/NSWallet/ViewModel/LoginScreen/LoginScreenViewModel.cs - About 7 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                      using Xamarin.Forms;

namespace NSWallet
{
    public class RedTheme : DefaultTheme
                      Severity: Major
                      Found in src/NSWallet/NSWallet/Themes/RedTheme.cs and 1 other location - About 7 hrs to fix
                      src/NSWallet/NSWallet/Themes/GreenTheme.cs on lines 1..46

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 476.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                      using Xamarin.Forms;

namespace NSWallet
{
    public class GreenTheme : DefaultTheme
                      Severity: Major
                      Found in src/NSWallet/NSWallet/Themes/GreenTheme.cs and 1 other location - About 7 hrs to fix
                      src/NSWallet/NSWallet/Themes/RedTheme.cs on lines 1..46

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 476.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Method OnBindingContextChanged has a Cognitive Complexity of 57 (exceeds 20 allowed). Consider refactoring.
                      Open

                              protected override void OnBindingContextChanged()
        {
            base.OnBindingContextChanged();

            var container = BindingContext as IList;
                      Severity: Minor
                      Found in src/NSWallet/NSWallet/Controls/FlowListView/FlowListViewInternalCell.cs - About 6 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Class SettingsScreenViewModel has 46 methods (exceeds 20 allowed). Consider refactoring.
                      Open

                          public class SettingsScreenViewModel : INotifyPropertyChanged
    {
        public event PropertyChangedEventHandler PropertyChanged;

        //public Action PremiumAlertCallback { get; set; }
                      Severity: Minor
                      Found in src/NSWallet/NSWallet/ViewModel/SettingsScreen/SettingsScreenViewModel.cs - About 6 hrs to fix

                        File ManageFieldView.cs has 427 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        using FFImageLoading.Forms;
using NSWallet.Consts;
using NSWallet.Helpers;
using NSWallet.NetStandard;
using NSWallet.NetStandard.Helpers.Fonts;
                        Severity: Minor
                        Found in src/NSWallet/NSWallet/Views/MainScreen/Fields/ManageFieldView.cs - About 6 hrs to fix

                          File IconScreenViewModel.cs has 417 lines of code (exceeds 250 allowed). Consider refactoring.
                          Open

                          using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Threading.Tasks;
using NSWallet.Helpers;
                          Severity: Minor
                          Found in src/NSWallet/NSWallet/ViewModel/Icons/IconScreenViewModel.cs - About 6 hrs to fix

                            Method GetIconsWithGroups has 147 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                    public static Dictionary<string, string> GetIconsWithGroups()
        {
            return new Dictionary<string, string> {
                { "accesspoint", "category_internet" },
                { "airplane", "category_travelling" },
                            Severity: Major
                            Found in src/NSWallet/NSWallet/ViewModel/MainScreen/ItemCreation/IconGroups.cs - About 5 hrs to fix
                              Severity
                              Category
                              Status
                              Source
                              Language