byt3bl33d3r/MITMf

View on GitHub
core/servers/HTTP.py

Summary

Maintainability
D
2 days
Test Coverage

Function PacketSequence has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

def PacketSequence(data, client):
    NTLM_Auth = re.findall('(?<=Authorization: NTLM )[^\\r]*', data)
    Basic_Auth = re.findall('(?<=Authorization: Basic )[^\\r]*', data)

    # Serve the .exe if needed
Severity: Minor
Found in core/servers/HTTP.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File HTTP.py has 260 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#!/usr/bin/env python
# This file is part of Responder
# Original work by Laurent Gaffie - Trustwave Holdings
#
# This program is free software: you can redistribute it and/or modify
Severity: Minor
Found in core/servers/HTTP.py - About 2 hrs to fix

    Function handle has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        def handle(self):
            try:
                while True:
                    self.request.settimeout(1)
                    data = self.request.recv(8092)
    Severity: Minor
    Found in core/servers/HTTP.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function handle has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def handle(self):
            try:
                while True:
                    data = self.exchange.recv(8092)
                    self.exchange.settimeout(0.5)
    Severity: Minor
    Found in core/servers/HTTP.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

                return str(Buffer)
    Severity: Major
    Found in core/servers/HTTP.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                      return str(Buffer)
      Severity: Major
      Found in core/servers/HTTP.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return WPAD_Custom
        Severity: Major
        Found in core/servers/HTTP.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return str(Response)
          Severity: Major
          Found in core/servers/HTTP.py - About 30 mins to fix

            Similar blocks of code found in 6 locations. Consider refactoring.
            Open

            class ThreadingTCPServer(ThreadingMixIn, TCPServer):
                
                allow_reuse_address = 1
            
                def server_bind(self):
            Severity: Major
            Found in core/servers/HTTP.py and 5 other locations - About 3 hrs to fix
            core/poisoners/NBTNS.py on lines 35..45
            core/servers/FTP.py on lines 40..50
            core/servers/IMAP.py on lines 41..51
            core/servers/POP3.py on lines 42..52
            core/servers/SMTP.py on lines 45..55

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 62.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            if Buffer and settings.Config.Force_WPAD_Auth == False:
                                self.exchange.send(Buffer)
                                if settings.Config.Verbose:
                                    log.info("{} [HTTPS] Sent WPAD (no auth) file".format(self.client_address[0]))
            Severity: Major
            Found in core/servers/HTTP.py and 1 other location - About 1 hr to fix
            core/servers/HTTP.py on lines 285..288

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 43.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            if Buffer and settings.Config.Force_WPAD_Auth == False:
                                self.request.send(Buffer)
                                if settings.Config.Verbose:
                                    log.info("{} [HTTP] Sent WPAD (no auth) file".format(self.client_address[0]))
            Severity: Major
            Found in core/servers/HTTP.py and 1 other location - About 1 hr to fix
            core/servers/HTTP.py on lines 323..326

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 43.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status