Sign upLogin

byt3bl33d3r/MITMf

View on GitHub
Star
core/sslstrip/CookieCleaner.py

Summary

Maintainability
F
5 days
Test Coverage

Function getExpireHeaders has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def getExpireHeaders(self, method, client, host, headers, path):
Severity: Minor
Found in core/sslstrip/CookieCleaner.py - About 35 mins to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    class CookieCleaner:
    '''This class cleans cookies we haven't seen before.  The basic idea is to
    kill sessions, which isn't entirely straight-forward.  Since we want this to
    be generalized, there's no way for us to know exactly what cookie we're trying
    to kill, which also means we don't know what domain or path it has been set for.
    Severity: Major
    Found in core/sslstrip/CookieCleaner.py and 1 other location - About 5 days to fix
    core/ferretng/CookieCleaner.py on lines 20..101

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 537.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status