Sign upLogin

byt3bl33d3r/MITMf

View on GitHub
Star

Showing 608 of 608 total issues

Avoid deeply nested control flow statements.
Open

                if (/Mac/.test(navigator.oscpu)) {
                    os_name = oses_mac_osx;
                } else {
                    os_name = oses_windows; // browsershots: Firefox 11.0 / Windows XP
                }
Severity: Major
Found in core/javascript/plugindetect.js - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                  if(m3[2]){
                stop = parseFloat(m3[2]);
                if(m3[3]){ // percentage
                  stop /= 100;
                }
    Severity: Major
    Found in core/javascript/screenshot.js - About 45 mins to fix

      Function _host_filter has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def _host_filter(self, host):

        if self.white_domains[0] != '':
            if host in self.white_domains:
                return True
      Severity: Minor
      Found in plugins/inject.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

                                  for d in range(x[6], x[7]+1):
                                ret.append('%d.%d.%d.%d' % (a, b, c, d))
            return ret
      Severity: Major
      Found in core/responder/settings.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                with open(file2, 'rb') as f:
                            new_tar_file.addfile(info, f)
                        os.remove(file2)
        Severity: Major
        Found in plugins/filepwn.py - About 45 mins to fix

          Function proxyViaSSL has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def proxyViaSSL(self, host, method, path, postData, headers, port):
          Severity: Minor
          Found in core/ferretng/ClientRequest.py - About 45 mins to fix

            Function proxyViaSSL has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def proxyViaSSL(self, host, method, path, postData, headers, port):
            Severity: Minor
            Found in core/sslstrip/ClientRequest.py - About 45 mins to fix

              Function parse_basic_auth has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

              def parse_basic_auth(src_ip_port, dst_ip_port, headers, authorization_header):
    '''
    Parse basic authentication over HTTP
    '''
    if authorization_header:
              Severity: Minor
              Found in core/netcreds.py - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid deeply nested control flow statements.
              Open

                                  if len(http_url_req) > 98:
                        http_url_req = http_url_req[:99] + '...'
                printer(src_ip_port, None, http_url_req)
              Severity: Major
              Found in core/netcreds.py - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                        if dominio in real:
                            v=" Domain=%s"%real[dominio]
                            log.debug("New cookie domain parameter: %s"%v)
                    newvalues.append(v)
                Severity: Major
                Found in core/sslstrip/SSLServerConnection.py - About 45 mins to fix

                  Function get_login_pass has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                  def get_login_pass(body):
    '''
    Regex out logins and passwords from a string
    '''
    user = None
                  Severity: Minor
                  Found in core/netcreds.py - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function proxyViaHTTP has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      def proxyViaHTTP(self, host, method, path, postData, headers, port):
                  Severity: Minor
                  Found in core/ferretng/ClientRequest.py - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                            if targetmac is not None: 
                            try:
                                #log.debug("Poisoning {} <-> {}".format(targetip, self.gatewayip))
                                self.s2.send(Ether(src=self.mymac, dst=targetmac)/ARP(pdst=targetip, psrc=self.gatewayip, hwdst=targetmac, op=arpmode))
                                self.s2.send(Ether(src=self.mymac, dst=self.gatewaymac)/ARP(pdst=self.gatewayip, psrc=targetip, hwdst=self.gatewaymac, op=arpmode))
                    Severity: Major
                    Found in core/poisoners/ARP.py - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                                  if qtype == "AAAA":
                                ipv6 = IP(fake_record)
                                ipv6_bin = ipv6.strBin()
                                fake_record = [int(ipv6_bin[i:i+8],2) for i in xrange(0,len(ipv6_bin),8)]
                      Severity: Major
                      Found in core/servers/DNS.py - About 45 mins to fix

                        Function proxyViaHTTP has 6 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            def proxyViaHTTP(self, host, method, path, postData, headers, port):
                        Severity: Minor
                        Found in core/sslstrip/ClientRequest.py - About 45 mins to fix

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                              def handleResponseEnd(self):
        if (self.isImageRequest):
            self.shutdown()
        else:
            #Gets rid of some generic errors
                          Severity: Minor
                          Found in core/sslstrip/ServerConnection.py and 1 other location - About 45 mins to fix
                          core/ferretng/ServerConnection.py on lines 141..147

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 35.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              def handleHostResolvedError(self, error):
        log.debug("[ClientRequest] Host resolution error: {}".format(error))
        try:
            self.finish()
        except:
                          Severity: Minor
                          Found in core/ferretng/ClientRequest.py and 1 other location - About 45 mins to fix
                          core/sslstrip/ClientRequest.py on lines 178..182

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 35.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                      for server in [server1, server2]:
                t = threading.Thread(name='SMTP', target=server.serve_forever)
                t.setDaemon(True)
                t.start()
                          Severity: Minor
                          Found in core/servers/SMTP.py and 1 other location - About 45 mins to fix
                          core/mitmfapi.py on lines 97..100

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 35.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                              def handleResponsePart(self, data):
        if (self.isImageRequest):
            self.client.write(data)
        else:
            HTTPClient.handleResponsePart(self, data)
                          Severity: Minor
                          Found in core/sslstrip/ServerConnection.py and 1 other location - About 45 mins to fix
                          core/ferretng/ServerConnection.py on lines 135..139

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 35.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  if (not self.cookieCleaner.isClean(self.method, client, host, headers)):
            log.debug("[ClientRequest] Sending expired cookies")
            self.sendExpiredCookies(host, path, self.cookieCleaner.getExpireHeaders(self.method, client, host, headers, path))
                          Severity: Minor
                          Found in core/ferretng/ClientRequest.py and 1 other location - About 45 mins to fix
                          core/sslstrip/ClientRequest.py on lines 157..159

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 35.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Severity
                          Category
                          Status
                          Source
                          Language