Sign upLogin

cadwallion/brewscribe

View on GitHub
Star

Showing 5 of 5 total issues

Method xml_node_to_hash has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

    def xml_node_to_hash node
      if node
        if node.element?
          if node.children.size > 0
            result_hash = {}
Severity: Minor
Found in lib/brewscribe/document.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method xml_node_to_hash has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def xml_node_to_hash node
      if node
        if node.element?
          if node.children.size > 0
            result_hash = {}
Severity: Minor
Found in lib/brewscribe/document.rb - About 1 hr to fix

    Method from_data has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def self.from_data data
      list = new

      case data[:grain]
      when Array
    Severity: Minor
    Found in lib/brewscribe/ingredient_list.rb - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                    elsif result_hash[key]
                if result_hash[key].is_a? Array
                  result_hash[key] << result
                else
                  result_hash[key] = [result_hash[key]] << result
      Severity: Major
      Found in lib/brewscribe/document.rb - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                        return result if !child.next && !child.previous
        Severity: Major
        Found in lib/brewscribe/document.rb - About 45 mins to fix
          Severity
          Category
          Status
          Source
          Language