caidooss/grafana-auth-proxy

View on GitHub

Showing 8 of 8 total issues

Function main has 94 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func main() {
    var err error

    // Load .env file
    err = godotenv.Load(".env")
Severity: Major
Found in main.go - About 2 hrs to fix

    Function createRequestsHandler has 54 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func createRequestsHandler(c *cli.Context) (*RequestsHandler, error) {
        // Prepare token extractor
        extractors := make([]extraction.Extractor, 0, 2)
    
        cookieName := c.String("cookie")
    Severity: Minor
    Found in main.go - About 1 hr to fix

      Function createRequestsHandler has 9 return statements (exceeds 4 allowed).
      Open

      func createRequestsHandler(c *cli.Context) (*RequestsHandler, error) {
          // Prepare token extractor
          extractors := make([]extraction.Extractor, 0, 2)
      
          cookieName := c.String("cookie")
      Severity: Major
      Found in main.go - About 55 mins to fix

        Method TokenValidator.Validate has 6 return statements (exceeds 4 allowed).
        Open

        func (tv *TokenValidator) Validate(tokenString string) (*jwt.Token, error) {
            // Extract token
            token, err := jwt.Parse(tokenString, tv.getTokenAssociatedPublicKey)
            if err != nil {
                switch err.(type) {
        Severity: Major
        Found in pkg/validation/validation.go - About 40 mins to fix

          Method TokenValidator.getTokenAssociatedPublicKey has 6 return statements (exceeds 4 allowed).
          Open

          func (tv *TokenValidator) getTokenAssociatedPublicKey(token *jwt.Token) (interface{}, error) {
              // Verify ALG: it should at least be not "none". We decided to restrict it further to a set of trusted algorithms.
              // See vulnerability: https://auth0.com/blog/critical-vulnerabilities-in-json-web-token-libraries/
              algHeader := token.Header["alg"]
              if algHeader == nil {
          Severity: Major
          Found in pkg/validation/validation.go - About 40 mins to fix

            Method headerExtractor.Extract has 5 return statements (exceeds 4 allowed).
            Open

            func (he *headerExtractor) Extract(r *http.Request) (string, error) {
                // Extract header
                header := r.Header.Get(he.headerName)
                if header == "" {
                    return "", errors.New(fmt.Sprintf("no header %s", he.headerName))
            Severity: Major
            Found in pkg/extraction/header.go - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              func loadPublicKeyFromDisk(location string) *rsa.PublicKey {
                  keyData, e := ioutil.ReadFile(location)
                  if e != nil {
                      panic(e.Error())
                  }
              Severity: Minor
              Found in pkg/authtest/keys.go and 1 other location - About 35 mins to fix
              pkg/authtest/keys.go on lines 31..43

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 105.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              func loadPrivateKeyFromDisk(location string) *rsa.PrivateKey {
                  keyData, e := ioutil.ReadFile(location)
                  if e != nil {
                      panic(e.Error())
                  }
              Severity: Minor
              Found in pkg/authtest/keys.go and 1 other location - About 35 mins to fix
              pkg/authtest/keys.go on lines 45..57

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 105.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Severity
              Category
              Status
              Source
              Language