Sign upLogin

calblueprint/bizworld

View on GitHub
Star
app/assets/javascripts/components/classrooms/edit_classroom_questions.jsx

Summary

Maintainability
D
1 day
Test Coverage

Function render has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render() {
        const questions = this.state.questions.map((question) => {
            return <AdminAdditionalInfoQuestion question  = {question}
                                         key       = {question.id}
                                         success   = {this._fetchQuestions} />
Severity: Minor
Found in app/assets/javascripts/components/classrooms/edit_classroom_questions.jsx - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        _renderSaveContainer() {
        let saveContainer;
        if (this.state.editable) {
            saveContainer = (
                <div className="edit-button-container">
    Severity: Major
    Found in app/assets/javascripts/components/classrooms/edit_classroom_questions.jsx and 1 other location - About 4 hrs to fix
    app/assets/javascripts/templates/default_question.jsx on lines 137..151

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 127.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        _renderEditButton() {
        let editButton;
        if (!this.state.editable) {
            editButton = (
                <a className="edit-question-button"
    Severity: Major
    Found in app/assets/javascripts/components/classrooms/edit_classroom_questions.jsx and 1 other location - About 2 hrs to fix
    app/assets/javascripts/components/classrooms/edit_classroom_questions.jsx on lines 127..139

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 80.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        _renderDeleteButton() {
        let deleteButton;
        if (!this.state.editable) {
            deleteButton = (
                <a className="delete-question-button"
    Severity: Major
    Found in app/assets/javascripts/components/classrooms/edit_classroom_questions.jsx and 1 other location - About 2 hrs to fix
    app/assets/javascripts/components/classrooms/edit_classroom_questions.jsx on lines 113..125

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 80.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            if (this.state.editable) {
            hintContainer = (
                <div>
                    <input type="text"
                        defaultValue={this.props.question.hint}
    Severity: Major
    Found in app/assets/javascripts/components/classrooms/edit_classroom_questions.jsx and 1 other location - About 1 hr to fix
    app/assets/javascripts/components/classrooms/edit_classroom_questions.jsx on lines 179..193

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 65.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            if (this.state.editable) {
            titleContainer = (
                <div>
                    <input type="text"
                        defaultValue={this.props.question.title}
    Severity: Major
    Found in app/assets/javascripts/components/classrooms/edit_classroom_questions.jsx and 1 other location - About 1 hr to fix
    app/assets/javascripts/components/classrooms/edit_classroom_questions.jsx on lines 159..173

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 65.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

                        <div className="edit-classroom-questions-header-container">
                        <h4>Edit Classroom Additional Info Questions</h4>
                        <input type="button" value="New Question"
                                    className="button-small submit-button"
                                    onClick={this._createNewQuestion} />
    Severity: Major
    Found in app/assets/javascripts/components/classrooms/edit_classroom_questions.jsx and 4 other locations - About 1 hr to fix
    app/assets/javascripts/components/authentication/change_password_form.jsx on lines 32..37
    app/assets/javascripts/components/authentication/change_password_form.jsx on lines 45..50
    app/assets/javascripts/components/authentication/change_password_form.jsx on lines 51..56
    app/assets/javascripts/components/classrooms/create_student.jsx on lines 45..48

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 64.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        constructor(props) {
        super(props);
        this.state = { questions : this.props.questions, isLoading : false };
    }
    Severity: Minor
    Found in app/assets/javascripts/components/classrooms/edit_classroom_questions.jsx and 1 other location - About 35 mins to fix
    app/assets/javascripts/components/classrooms/class_info.jsx on lines 9..15

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 12 locations. Consider refactoring.
    Open

    AdminAdditionalInfoQuestion.propTypes = {
    success  : React.PropTypes.func.isRequired,
    question : React.PropTypes.object.isRequired
};
    Severity: Major
    Found in app/assets/javascripts/components/classrooms/edit_classroom_questions.jsx and 11 other locations - About 35 mins to fix
    app/assets/javascripts/components/admins/filters.jsx on lines 77..80
    app/assets/javascripts/components/authentication/login.jsx on lines 53..56
    app/assets/javascripts/components/authentication/register.jsx on lines 70..73
    app/assets/javascripts/components/classrooms/create_student.jsx on lines 62..65
    app/assets/javascripts/components/classrooms/students_table.jsx on lines 152..155
    app/assets/javascripts/components/classrooms/upload_modal.jsx on lines 40..43
    app/assets/javascripts/components/classrooms/upload_roster.jsx on lines 84..87
    app/assets/javascripts/components/common/program_filter.jsx on lines 42..45
    app/assets/javascripts/components/forms/additional_questions.jsx on lines 74..77
    app/assets/javascripts/components/forms/student_questions.jsx on lines 81..84
    app/assets/javascripts/components/teachers/teacher_account_info.jsx on lines 75..78

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status