Sign upLogin

calblueprint/bizworld

View on GitHub
Star
app/assets/javascripts/components/common/program_filter.jsx

Summary

Maintainability
A
3 hrs
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        const programNames = this.state.programs.map((program) => {
            return (
                <option key={program.id} value={program.id}>
                    {program.name}
                </option>
Severity: Major
Found in app/assets/javascripts/components/common/program_filter.jsx and 1 other location - About 1 hr to fix
app/assets/javascripts/components/teachers/create_classroom.jsx on lines 21..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    _fetchPrograms(params) {
        const success = (data) => { this.setState({ programs : data }) }
        APIRequester.getJSON(APIConstants.programs.collection, success, params);
    }
Severity: Major
Found in app/assets/javascripts/components/common/program_filter.jsx and 1 other location - About 1 hr to fix
app/assets/javascripts/components/teachers/create_classroom.jsx on lines 15..18

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

ProgramFilter.propTypes = {
    onChange : React.PropTypes.func.isRequired,
    showAll  : React.PropTypes.bool.isRequired
};
Severity: Major
Found in app/assets/javascripts/components/common/program_filter.jsx and 11 other locations - About 35 mins to fix
app/assets/javascripts/components/admins/filters.jsx on lines 77..80
app/assets/javascripts/components/authentication/login.jsx on lines 53..56
app/assets/javascripts/components/authentication/register.jsx on lines 70..73
app/assets/javascripts/components/classrooms/create_student.jsx on lines 62..65
app/assets/javascripts/components/classrooms/edit_classroom_questions.jsx on lines 224..227
app/assets/javascripts/components/classrooms/students_table.jsx on lines 152..155
app/assets/javascripts/components/classrooms/upload_modal.jsx on lines 40..43
app/assets/javascripts/components/classrooms/upload_roster.jsx on lines 84..87
app/assets/javascripts/components/forms/additional_questions.jsx on lines 74..77
app/assets/javascripts/components/forms/student_questions.jsx on lines 81..84
app/assets/javascripts/components/teachers/teacher_account_info.jsx on lines 75..78

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status