canax/router

View on GitHub
src/Route/RouteHandler.php

Summary

Maintainability
D
2 days
Test Coverage

The class RouteHandler has an overall complexity of 80 which is very high. The configured complexity threshold is 50.
Open

class RouteHandler
{
    /**
     * @var ContainerInterface $di the dependency/service container.
     */
Severity: Minor
Found in src/Route/RouteHandler.php by phpmd

File RouteHandler.php has 270 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Anax\Route;

use Anax\Commons\ContainerInjectableInterface;
Severity: Minor
Found in src/Route/RouteHandler.php - About 2 hrs to fix

    Method handleAsControllerAction has 54 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function handleAsControllerAction(array $callable)
        {
            $class = $callable[0];
            $action = $callable[1];
            $args = $callable[2];
    Severity: Major
    Found in src/Route/RouteHandler.php - About 2 hrs to fix

      Function handleAsControllerAction has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function handleAsControllerAction(array $callable)
          {
              $class = $callable[0];
              $action = $callable[1];
              $args = $callable[2];
      Severity: Minor
      Found in src/Route/RouteHandler.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function handleAsInvocableClass has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function handleAsInvocableClass(string $class)
          {
              $obj = new $class();
              // $class = $callable[0];
              $action = "__invoke";
      Severity: Minor
      Found in src/Route/RouteHandler.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method handleAsInvocableClass has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function handleAsInvocableClass(string $class)
          {
              $obj = new $class();
              // $class = $callable[0];
              $action = "__invoke";
      Severity: Minor
      Found in src/Route/RouteHandler.php - About 1 hr to fix

        Function handle has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            public function handle(
                ?string $method,
                ?string $path,
                $action,
                array $arguments = [],
        Severity: Minor
        Found in src/Route/RouteHandler.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method handle has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function handle(
                ?string $method,
                ?string $path,
                $action,
                array $arguments = [],
        Severity: Minor
        Found in src/Route/RouteHandler.php - About 1 hr to fix

          Method isControllerAction has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function isControllerAction(
                  ?string $method,
                  ?string $path,
                  string $class
              ) {
          Severity: Minor
          Found in src/Route/RouteHandler.php - About 1 hr to fix

            Function isControllerAction has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function isControllerAction(
                    ?string $method,
                    ?string $path,
                    string $class
                ) {
            Severity: Minor
            Found in src/Route/RouteHandler.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Consider simplifying this complex logical expression.
            Open

                    if ($di
                        && is_array($action)
                        && isset($action[0])
                        && isset($action[1])
                        && is_string($action[0])
            Severity: Major
            Found in src/Route/RouteHandler.php - About 1 hr to fix

              Consider simplifying this complex logical expression.
              Open

                      if (is_array($action)
                          && isset($action[0])
                          && isset($action[1])
                          && is_string($action[0])
                          && is_string($action[1])
              Severity: Major
              Found in src/Route/RouteHandler.php - About 40 mins to fix

                Method handle has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        ?string $method,
                        ?string $path,
                        $action,
                        array $arguments = [],
                        ContainerInterface $di = null
                Severity: Minor
                Found in src/Route/RouteHandler.php - About 35 mins to fix

                  Function getHandlerType has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function getHandlerType(
                          $action,
                          ContainerInterface $di = null
                      ) {
                          if (is_null($action)) {
                  Severity: Minor
                  Found in src/Route/RouteHandler.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Avoid too many return statements within this method.
                  Open

                                  return $this->handleAsInvocableClass($action);
                  Severity: Major
                  Found in src/Route/RouteHandler.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return "not found";
                    Severity: Major
                    Found in src/Route/RouteHandler.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                  return $this->handleUsingDi($action, $arguments, $di);
                      Severity: Major
                      Found in src/Route/RouteHandler.php - About 30 mins to fix

                        The method handleAsControllerAction() has an NPath complexity of 648. The configured NPath complexity threshold is 200.
                        Open

                            protected function handleAsControllerAction(array $callable)
                            {
                                $class = $callable[0];
                                $action = $callable[1];
                                $args = $callable[2];
                        Severity: Minor
                        Found in src/Route/RouteHandler.php by phpmd

                        NPathComplexity

                        Since: 0.1

                        The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                        Example

                        class Foo {
                            function bar() {
                                // lots of complicated code
                            }
                        }

                        Source https://phpmd.org/rules/codesize.html#npathcomplexity

                        The method handle() has an NPath complexity of 360. The configured NPath complexity threshold is 200.
                        Open

                            public function handle(
                                ?string $method,
                                ?string $path,
                                $action,
                                array $arguments = [],
                        Severity: Minor
                        Found in src/Route/RouteHandler.php by phpmd

                        NPathComplexity

                        Since: 0.1

                        The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                        Example

                        class Foo {
                            function bar() {
                                // lots of complicated code
                            }
                        }

                        Source https://phpmd.org/rules/codesize.html#npathcomplexity

                        The method handleAsInvocableClass() has an NPath complexity of 216. The configured NPath complexity threshold is 200.
                        Open

                            protected function handleAsInvocableClass(string $class)
                            {
                                $obj = new $class();
                                // $class = $callable[0];
                                $action = "__invoke";
                        Severity: Minor
                        Found in src/Route/RouteHandler.php by phpmd

                        NPathComplexity

                        Since: 0.1

                        The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                        Example

                        class Foo {
                            function bar() {
                                // lots of complicated code
                            }
                        }

                        Source https://phpmd.org/rules/codesize.html#npathcomplexity

                        The method getHandlerType() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
                        Open

                            public function getHandlerType(
                                $action,
                                ContainerInterface $di = null
                            ) {
                                if (is_null($action)) {
                        Severity: Minor
                        Found in src/Route/RouteHandler.php by phpmd

                        CyclomaticComplexity

                        Since: 0.1

                        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                        Example

                        // Cyclomatic Complexity = 11
                        class Foo {
                        1   public function example() {
                        2       if ($a == $b) {
                        3           if ($a1 == $b1) {
                                        fiddle();
                        4           } elseif ($a2 == $b2) {
                                        fiddle();
                                    } else {
                                        fiddle();
                                    }
                        5       } elseif ($c == $d) {
                        6           while ($c == $d) {
                                        fiddle();
                                    }
                        7        } elseif ($e == $f) {
                        8           for ($n = 0; $n < $h; $n++) {
                                        fiddle();
                                    }
                                } else {
                                    switch ($z) {
                        9               case 1:
                                            fiddle();
                                            break;
                        10              case 2:
                                            fiddle();
                                            break;
                        11              case 3:
                                            fiddle();
                                            break;
                                        default:
                                            fiddle();
                                            break;
                                    }
                                }
                            }
                        }

                        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                        The method handleAsInvocableClass() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
                        Open

                            protected function handleAsInvocableClass(string $class)
                            {
                                $obj = new $class();
                                // $class = $callable[0];
                                $action = "__invoke";
                        Severity: Minor
                        Found in src/Route/RouteHandler.php by phpmd

                        CyclomaticComplexity

                        Since: 0.1

                        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                        Example

                        // Cyclomatic Complexity = 11
                        class Foo {
                        1   public function example() {
                        2       if ($a == $b) {
                        3           if ($a1 == $b1) {
                                        fiddle();
                        4           } elseif ($a2 == $b2) {
                                        fiddle();
                                    } else {
                                        fiddle();
                                    }
                        5       } elseif ($c == $d) {
                        6           while ($c == $d) {
                                        fiddle();
                                    }
                        7        } elseif ($e == $f) {
                        8           for ($n = 0; $n < $h; $n++) {
                                        fiddle();
                                    }
                                } else {
                                    switch ($z) {
                        9               case 1:
                                            fiddle();
                                            break;
                        10              case 2:
                                            fiddle();
                                            break;
                        11              case 3:
                                            fiddle();
                                            break;
                                        default:
                                            fiddle();
                                            break;
                                    }
                                }
                            }
                        }

                        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                        The method handleAsControllerAction() has a Cyclomatic Complexity of 15. The configured cyclomatic complexity threshold is 10.
                        Open

                            protected function handleAsControllerAction(array $callable)
                            {
                                $class = $callable[0];
                                $action = $callable[1];
                                $args = $callable[2];
                        Severity: Minor
                        Found in src/Route/RouteHandler.php by phpmd

                        CyclomaticComplexity

                        Since: 0.1

                        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                        Example

                        // Cyclomatic Complexity = 11
                        class Foo {
                        1   public function example() {
                        2       if ($a == $b) {
                        3           if ($a1 == $b1) {
                                        fiddle();
                        4           } elseif ($a2 == $b2) {
                                        fiddle();
                                    } else {
                                        fiddle();
                                    }
                        5       } elseif ($c == $d) {
                        6           while ($c == $d) {
                                        fiddle();
                                    }
                        7        } elseif ($e == $f) {
                        8           for ($n = 0; $n < $h; $n++) {
                                        fiddle();
                                    }
                                } else {
                                    switch ($z) {
                        9               case 1:
                                            fiddle();
                                            break;
                        10              case 2:
                                            fiddle();
                                            break;
                        11              case 3:
                                            fiddle();
                                            break;
                                        default:
                                            fiddle();
                                            break;
                                    }
                                }
                            }
                        }

                        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                        The method handleAsCallable() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
                        Open

                            protected function handleAsCallable(
                                $action,
                                array $arguments
                            ) {
                                if (is_array($action)
                        Severity: Minor
                        Found in src/Route/RouteHandler.php by phpmd

                        CyclomaticComplexity

                        Since: 0.1

                        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                        Example

                        // Cyclomatic Complexity = 11
                        class Foo {
                        1   public function example() {
                        2       if ($a == $b) {
                        3           if ($a1 == $b1) {
                                        fiddle();
                        4           } elseif ($a2 == $b2) {
                                        fiddle();
                                    } else {
                                        fiddle();
                                    }
                        5       } elseif ($c == $d) {
                        6           while ($c == $d) {
                                        fiddle();
                                    }
                        7        } elseif ($e == $f) {
                        8           for ($n = 0; $n < $h; $n++) {
                                        fiddle();
                                    }
                                } else {
                                    switch ($z) {
                        9               case 1:
                                            fiddle();
                                            break;
                        10              case 2:
                                            fiddle();
                                            break;
                        11              case 3:
                                            fiddle();
                                            break;
                                        default:
                                            fiddle();
                                            break;
                                    }
                                }
                            }
                        }

                        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                        The method handle() has a Cyclomatic Complexity of 15. The configured cyclomatic complexity threshold is 10.
                        Open

                            public function handle(
                                ?string $method,
                                ?string $path,
                                $action,
                                array $arguments = [],
                        Severity: Minor
                        Found in src/Route/RouteHandler.php by phpmd

                        CyclomaticComplexity

                        Since: 0.1

                        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                        Example

                        // Cyclomatic Complexity = 11
                        class Foo {
                        1   public function example() {
                        2       if ($a == $b) {
                        3           if ($a1 == $b1) {
                                        fiddle();
                        4           } elseif ($a2 == $b2) {
                                        fiddle();
                                    } else {
                                        fiddle();
                                    }
                        5       } elseif ($c == $d) {
                        6           while ($c == $d) {
                                        fiddle();
                                    }
                        7        } elseif ($e == $f) {
                        8           for ($n = 0; $n < $h; $n++) {
                                        fiddle();
                                    }
                                } else {
                                    switch ($z) {
                        9               case 1:
                                            fiddle();
                                            break;
                        10              case 2:
                                            fiddle();
                                            break;
                        11              case 3:
                                            fiddle();
                                            break;
                                        default:
                                            fiddle();
                                            break;
                                    }
                                }
                            }
                        }

                        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                        Missing class import via use statement (line '184', column '21').
                        Open

                                $refl = new \ReflectionMethod($obj, $action);
                        Severity: Minor
                        Found in src/Route/RouteHandler.php by phpmd

                        MissingImport

                        Since: 2.7.0

                        Importing all external classes in a file through use statements makes them clearly visible.

                        Example

                        function make() {
                            return new \stdClass();
                        }

                        Source http://phpmd.org/rules/cleancode.html#MissingImport

                        Missing class import via use statement (line '173', column '25').
                        Open

                                    $refl = new \ReflectionMethod($class, "initialize");
                        Severity: Minor
                        Found in src/Route/RouteHandler.php by phpmd

                        MissingImport

                        Since: 2.7.0

                        Importing all external classes in a file through use statements makes them clearly visible.

                        Example

                        function make() {
                            return new \stdClass();
                        }

                        Source http://phpmd.org/rules/cleancode.html#MissingImport

                        Missing class import via use statement (line '372', column '25').
                        Open

                                    $refl = new \ReflectionMethod($action[0], $action[1]);
                        Severity: Minor
                        Found in src/Route/RouteHandler.php by phpmd

                        MissingImport

                        Since: 2.7.0

                        Importing all external classes in a file through use statements makes them clearly visible.

                        Example

                        function make() {
                            return new \stdClass();
                        }

                        Source http://phpmd.org/rules/cleancode.html#MissingImport

                        Missing class import via use statement (line '157', column '21').
                        Open

                                $refl = new \ReflectionClass($class);
                        Severity: Minor
                        Found in src/Route/RouteHandler.php by phpmd

                        MissingImport

                        Since: 2.7.0

                        Importing all external classes in a file through use statements makes them clearly visible.

                        Example

                        function make() {
                            return new \stdClass();
                        }

                        Source http://phpmd.org/rules/cleancode.html#MissingImport

                        Missing class import via use statement (line '382', column '19').
                        Open

                                    : new \ReflectionFunction($action);
                        Severity: Minor
                        Found in src/Route/RouteHandler.php by phpmd

                        MissingImport

                        Since: 2.7.0

                        Importing all external classes in a file through use statements makes them clearly visible.

                        Example

                        function make() {
                            return new \stdClass();
                        }

                        Source http://phpmd.org/rules/cleancode.html#MissingImport

                        Missing class import via use statement (line '381', column '19').
                        Open

                                    ? new \ReflectionMethod($action[0], $action[1])
                        Severity: Minor
                        Found in src/Route/RouteHandler.php by phpmd

                        MissingImport

                        Since: 2.7.0

                        Importing all external classes in a file through use statements makes them clearly visible.

                        Example

                        function make() {
                            return new \stdClass();
                        }

                        Source http://phpmd.org/rules/cleancode.html#MissingImport

                        Missing class import via use statement (line '307', column '25').
                        Open

                                    $refl = new \ReflectionMethod($class, "initialize");
                        Severity: Minor
                        Found in src/Route/RouteHandler.php by phpmd

                        MissingImport

                        Since: 2.7.0

                        Importing all external classes in a file through use statements makes them clearly visible.

                        Example

                        function make() {
                            return new \stdClass();
                        }

                        Source http://phpmd.org/rules/cleancode.html#MissingImport

                        Missing class import via use statement (line '318', column '21').
                        Open

                                $refl = new \ReflectionMethod($obj, $action);
                        Severity: Minor
                        Found in src/Route/RouteHandler.php by phpmd

                        MissingImport

                        Since: 2.7.0

                        Importing all external classes in a file through use statements makes them clearly visible.

                        Example

                        function make() {
                            return new \stdClass();
                        }

                        Source http://phpmd.org/rules/cleancode.html#MissingImport

                        Missing class import via use statement (line '136', column '19').
                        Open

                                $rc = new \ReflectionClass($action);
                        Severity: Minor
                        Found in src/Route/RouteHandler.php by phpmd

                        MissingImport

                        Since: 2.7.0

                        Importing all external classes in a file through use statements makes them clearly visible.

                        Example

                        function make() {
                            return new \stdClass();
                        }

                        Source http://phpmd.org/rules/cleancode.html#MissingImport

                        Missing class import via use statement (line '246', column '29').
                        Open

                                        $refl = new \ReflectionMethod($class, $target);
                        Severity: Minor
                        Found in src/Route/RouteHandler.php by phpmd

                        MissingImport

                        Since: 2.7.0

                        Importing all external classes in a file through use statements makes them clearly visible.

                        Example

                        function make() {
                            return new \stdClass();
                        }

                        Source http://phpmd.org/rules/cleancode.html#MissingImport

                        Missing class import via use statement (line '291', column '21').
                        Open

                                $refl = new \ReflectionClass($class);
                        Severity: Minor
                        Found in src/Route/RouteHandler.php by phpmd

                        MissingImport

                        Since: 2.7.0

                        Importing all external classes in a file through use statements makes them clearly visible.

                        Example

                        function make() {
                            return new \stdClass();
                        }

                        Source http://phpmd.org/rules/cleancode.html#MissingImport

                        Missing class import via use statement (line '259', column '29').
                        Open

                                        $refl = new \ReflectionMethod($class, $target);
                        Severity: Minor
                        Found in src/Route/RouteHandler.php by phpmd

                        MissingImport

                        Since: 2.7.0

                        Importing all external classes in a file through use statements makes them clearly visible.

                        Example

                        function make() {
                            return new \stdClass();
                        }

                        Source http://phpmd.org/rules/cleancode.html#MissingImport

                        Avoid unused local variables such as '$paramIsVariadic'.
                        Open

                                $paramIsVariadic = false;
                        Severity: Minor
                        Found in src/Route/RouteHandler.php by phpmd

                        UnusedLocalVariable

                        Since: 0.2

                        Detects when a local variable is declared and/or assigned, but not used.

                        Example

                        class Foo {
                            public function doSomething()
                            {
                                $i = 5; // Unused
                            }
                        }

                        Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                                if ($this->di && $refl->implementsInterface($diInterface)) {
                                    $obj->setDI($this->di);
                                } elseif ($this->di && $refl->implementsInterface($appInterface)) {
                                    if (!$this->di->has("app")) {
                                        throw new ConfigurationException(
                        Severity: Minor
                        Found in src/Route/RouteHandler.php and 1 other location - About 30 mins to fix
                        src/Route/RouteHandler.php on lines 295..304

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 90.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                                if ($this->di && $refl->implementsInterface($diInterface)) {
                                    $obj->setDI($this->di);
                                } elseif ($this->di && $refl->implementsInterface($appInterface)) {
                                    if (!$this->di->has("app")) {
                                        throw new ConfigurationException(
                        Severity: Minor
                        Found in src/Route/RouteHandler.php and 1 other location - About 30 mins to fix
                        src/Route/RouteHandler.php on lines 161..170

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 90.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Avoid variables with short names like $di. Configured minimum length is 3.
                        Open

                            protected $di;
                        Severity: Minor
                        Found in src/Route/RouteHandler.php by phpmd

                        ShortVariable

                        Since: 0.2

                        Detects when a field, local, or parameter has a very short name.

                        Example

                        class Something {
                            private $q = 15; // VIOLATION - Field
                            public static function main( array $as ) { // VIOLATION - Formal
                                $r = 20 + $this->q; // VIOLATION - Local
                                for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                    $r += $this->q;
                                }
                            }
                        }

                        Source https://phpmd.org/rules/naming.html#shortvariable

                        Avoid variables with short names like $di. Configured minimum length is 3.
                        Open

                                ContainerInterface $di = null
                        Severity: Minor
                        Found in src/Route/RouteHandler.php by phpmd

                        ShortVariable

                        Since: 0.2

                        Detects when a field, local, or parameter has a very short name.

                        Example

                        class Something {
                            private $q = 15; // VIOLATION - Field
                            public static function main( array $as ) { // VIOLATION - Formal
                                $r = 20 + $this->q; // VIOLATION - Local
                                for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                    $r += $this->q;
                                }
                            }
                        }

                        Source https://phpmd.org/rules/naming.html#shortvariable

                        Avoid variables with short names like $rc. Configured minimum length is 3.
                        Open

                                $rc = new \ReflectionClass($action);
                        Severity: Minor
                        Found in src/Route/RouteHandler.php by phpmd

                        ShortVariable

                        Since: 0.2

                        Detects when a field, local, or parameter has a very short name.

                        Example

                        class Something {
                            private $q = 15; // VIOLATION - Field
                            public static function main( array $as ) { // VIOLATION - Formal
                                $r = 20 + $this->q; // VIOLATION - Local
                                for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                    $r += $this->q;
                                }
                            }
                        }

                        Source https://phpmd.org/rules/naming.html#shortvariable

                        Avoid variables with short names like $di. Configured minimum length is 3.
                        Open

                                ContainerInterface $di = null
                        Severity: Minor
                        Found in src/Route/RouteHandler.php by phpmd

                        ShortVariable

                        Since: 0.2

                        Detects when a field, local, or parameter has a very short name.

                        Example

                        class Something {
                            private $q = 15; // VIOLATION - Field
                            public static function main( array $as ) { // VIOLATION - Formal
                                $r = 20 + $this->q; // VIOLATION - Local
                                for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                    $r += $this->q;
                                }
                            }
                        }

                        Source https://phpmd.org/rules/naming.html#shortvariable

                        Avoid variables with short names like $di. Configured minimum length is 3.
                        Open

                                ContainerInterface $di
                        Severity: Minor
                        Found in src/Route/RouteHandler.php by phpmd

                        ShortVariable

                        Since: 0.2

                        Detects when a field, local, or parameter has a very short name.

                        Example

                        class Something {
                            private $q = 15; // VIOLATION - Field
                            public static function main( array $as ) { // VIOLATION - Formal
                                $r = 20 + $this->q; // VIOLATION - Local
                                for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                    $r += $this->q;
                                }
                            }
                        }

                        Source https://phpmd.org/rules/naming.html#shortvariable

                        There are no issues that match your filters.

                        Category
                        Status