canax/router

View on GitHub
src/Route/RouteMatcher.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method match has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function match(
        ?string $mount,
        ?string $relativePath,
        ?string $absolutePath,
        ?string $query,
Severity: Minor
Found in src/Route/RouteMatcher.php - About 1 hr to fix

    Function match has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public function match(
            ?string $mount,
            ?string $relativePath,
            ?string $absolutePath,
            ?string $query,
    Severity: Minor
    Found in src/Route/RouteMatcher.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method match has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            ?string $mount,
            ?string $relativePath,
            ?string $absolutePath,
            ?string $query,
            ?array $methodSupported,
    Severity: Minor
    Found in src/Route/RouteMatcher.php - About 45 mins to fix

      Function checkPartAsArgument has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          private function checkPartAsArgument($rulePart, $queryPart, &$args)
          {
              if (substr($rulePart, -1) == "}"
                  && !is_null($queryPart)
              ) {
      Severity: Minor
      Found in src/Route/RouteMatcher.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                      return false;
      Severity: Major
      Found in src/Route/RouteMatcher.php - About 30 mins to fix

        The method match() has an NPath complexity of 408. The configured NPath complexity threshold is 200.
        Open

            public function match(
                ?string $mount,
                ?string $relativePath,
                ?string $absolutePath,
                ?string $query,
        Severity: Minor
        Found in src/Route/RouteMatcher.php by phpmd

        NPathComplexity

        Since: 0.1

        The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

        Example

        class Foo {
            function bar() {
                // lots of complicated code
            }
        }

        Source https://phpmd.org/rules/codesize.html#npathcomplexity

        The method match() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
        Open

            public function match(
                ?string $mount,
                ?string $relativePath,
                ?string $absolutePath,
                ?string $query,
        Severity: Minor
        Found in src/Route/RouteMatcher.php by phpmd

        CyclomaticComplexity

        Since: 0.1

        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

        Example

        // Cyclomatic Complexity = 11
        class Foo {
        1   public function example() {
        2       if ($a == $b) {
        3           if ($a1 == $b1) {
                        fiddle();
        4           } elseif ($a2 == $b2) {
                        fiddle();
                    } else {
                        fiddle();
                    }
        5       } elseif ($c == $d) {
        6           while ($c == $d) {
                        fiddle();
                    }
        7        } elseif ($e == $f) {
        8           for ($n = 0; $n < $h; $n++) {
                        fiddle();
                    }
                } else {
                    switch ($z) {
        9               case 1:
                            fiddle();
                            break;
        10              case 2:
                            fiddle();
                            break;
        11              case 3:
                            fiddle();
                            break;
                        default:
                            fiddle();
                            break;
                    }
                }
            }
        }

        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

        Avoid excessively long variable names like $matchedQueryToMountPath. Keep variable name length under 20.
        Open

                $matchedQueryToMountPath = strncmp($query, $mount, $charsToMatch) === 0 ? true : false;
        Severity: Minor
        Found in src/Route/RouteMatcher.php by phpmd

        LongVariable

        Since: 0.2

        Detects when a field, formal or local variable is declared with a long name.

        Example

        class Something {
            protected $reallyLongIntName = -3; // VIOLATION - Field
            public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
                $otherReallyLongName = -5; // VIOLATION - Local
                for ($interestingIntIndex = 0; // VIOLATION - For
                     $interestingIntIndex < 10;
                     $interestingIntIndex++ ) {
                }
            }
        }

        Source https://phpmd.org/rules/naming.html#longvariable

        There are no issues that match your filters.

        Category
        Status