Sign upLogin

cantino/huginn

View on GitHub
Star
app/models/agents/ftpsite_agent.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method validate_options has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    def validate_options
      # Check for required fields
      begin
        if !options['url'].include?('{{')
          url = interpolated['url']
Severity: Minor
Found in app/models/agents/ftpsite_agent.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validate_options has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def validate_options
      # Check for required fields
      begin
        if !options['url'].include?('{{')
          url = interpolated['url']
Severity: Minor
Found in app/models/agents/ftpsite_agent.rb - About 1 hr to fix

    Method open_ftp has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def open_ftp(uri)
      ftp = Net::FTP.new

      log "Connecting to #{uri.host}#{':%d' % uri.port if uri.port != uri.default_port}"
      ftp.connect(uri.host, uri.port)
    Severity: Minor
    Found in app/models/agents/ftpsite_agent.rb - About 1 hr to fix

      Method open_ftp has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def open_ftp(uri)
      ftp = Net::FTP.new

      log "Connecting to #{uri.host}#{':%d' % uri.port if uri.port != uri.default_port}"
      ftp.connect(uri.host, uri.port)
      Severity: Minor
      Found in app/models/agents/ftpsite_agent.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status