Sign upLogin

cantino/huginn

View on GitHub
Star
app/models/agents/twilio_agent.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method receive has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def receive(incoming_events)
      memory['pending_calls'] ||= {}
      interpolate_with_each(incoming_events) do |event|
        message = (event.payload['message'].presence || event.payload['text'].presence || event.payload['sms'].presence).to_s
        if message.present?
Severity: Minor
Found in app/models/agents/twilio_agent.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

      unless options['account_sid'].present? && options['auth_token'].present? && options['sender_cell'].present? && options['receiver_cell'].present? && options['expected_receive_period_in_days'].present? && options['receive_call'].present? && options['receive_text'].present?
        errors.add(:base,
                   'account_sid, auth_token, sender_cell, receiver_cell, receive_text, receive_call and expected_receive_period_in_days are all required')
      end
Severity: Major
Found in app/models/agents/twilio_agent.rb - About 1 hr to fix

    There are no issues that match your filters.

    Category
    Status