Sign upLogin

capocchi/DEVSimPy

View on GitHub
Star
DEVSKernel/PyPDEVS/old/simulator.py

Summary

Maintainability
D
1 day
Test Coverage

Function simulate has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

    def simulate(self,
                 termination_condition=None,
                 termination_time=float('inf'),
                 verbose=False,
                 xml=False,
Severity: Minor
Found in DEVSKernel/PyPDEVS/old/simulator.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File simulator.py has 283 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: Latin-1 -*-
## ## ## ## ## ## ## ## ## ## ## ## ## ## ## ## ## ## ## ## ## ## ## ## ## ##
# simulator.py --- 'Plain' DEVS Model Simulator
#                     --------------------------------
#                            Copyright (c) 2013
Severity: Minor
Found in DEVSKernel/PyPDEVS/old/simulator.py - About 2 hrs to fix

    Function simulate has 20 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def simulate(self,
    Severity: Major
    Found in DEVSKernel/PyPDEVS/old/simulator.py - About 2 hrs to fix

      Function real_simulate has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          def real_simulate(self, locations = list(range(COMM_WORLD.Get_size()))):
        try:
            for location in locations:
                # Don't run all of these on a seperate thread, as it returns no result
                proxy = getProxy(location)
      Severity: Minor
      Found in DEVSKernel/PyPDEVS/old/simulator.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function __init__ has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def __init__(self, model):
        """
        Constructor of the simulator.
        Args:
            model - a valid COUPLED model (created with the provided function)
      Severity: Minor
      Found in DEVSKernel/PyPDEVS/old/simulator.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  for i in range(len(loclist)):
                # Construct the ring
                getProxy(loclist[i]).setNextLP(loclist[(i+1) % len(loclist)], len(loclist))
      Severity: Major
      Found in DEVSKernel/PyPDEVS/old/simulator.py and 1 other location - About 1 hr to fix
      DEVSKernel/PyPDEVS/old/simulator.py on lines 152..154

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              for i in locations:
            # Construct the ring
            getProxy(locations[i]).setNextLP(locations[(i+1) % len(locations)], len(locations))
      Severity: Major
      Found in DEVSKernel/PyPDEVS/old/simulator.py and 1 other location - About 1 hr to fix
      DEVSKernel/PyPDEVS/old/simulator.py on lines 334..336

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status