Sign upLogin

careyjames/dns-scout

View on GitHub
Star
dns_information/ns_info_test.go

Summary

Maintainability
A
3 hrs
Test Coverage

Similar blocks of code found in 7 locations. Consider refactoring.
Open

func TestGetNS(t *testing.T) {
    // Celliwig: Disable for LaunchPad
//    t.Run("Valid NS Records from Google DNS", func(t *testing.T) {
//        // Mock Google DNS to return NS records.
//        domain := "example.com"
Severity: Major
Found in dns_information/ns_info_test.go and 6 other locations - About 1 hr to fix
dns_information/dns_txt_test.go on lines 13..54
dns_information/dns_txt_test.go on lines 56..118
dns_information/mx_info_test.go on lines 7..49
dns_information/ns_lookup_test.go on lines 7..49
dns_information/ns_lookup_test.go on lines 51..93
dns_information/ptr_info_test.go on lines 13..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 160.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    t.Run("No NS Records", func(t *testing.T) {
        input := "nodata.com"
        GetNSPrompt(input)
        w.Close()
        capturedOutput, _ := ioutil.ReadAll(r)
Severity: Major
Found in dns_information/ns_info_test.go and 5 other locations - About 1 hr to fix
dns_information/dkim_info_test.go on lines 140..150
dns_information/dmarc_test.go on lines 190..200
dns_information/dmarc_test.go on lines 202..212
dns_information/dns_txt_test.go on lines 142..152
dns_information/ns_info_test.go on lines 83..93

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 134.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    t.Run("Display NS Records", func(t *testing.T) {
        input := "example.com"
        GetNSPrompt(input)
        w.Close()
        capturedOutput, _ := ioutil.ReadAll(r)
Severity: Major
Found in dns_information/ns_info_test.go and 5 other locations - About 1 hr to fix
dns_information/dkim_info_test.go on lines 140..150
dns_information/dmarc_test.go on lines 190..200
dns_information/dmarc_test.go on lines 202..212
dns_information/dns_txt_test.go on lines 142..152
dns_information/ns_info_test.go on lines 95..105

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 134.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status