Sign upLogin

carmentang/engineerswithoutborders

View on GitHub
Star

Showing 389 of 389 total issues

Class has too many lines. [138/100]
Open

class VolunteersController < ApplicationController
  helper :all
  before_action :set_volunteer, only: [:show, :edit, :update, :destroy]
  before_action :find_teams, only: [:teams, :index]
Severity: Minor
Found in app/controllers/volunteers_controller.rb by rubocop

This cop checks if the length a class exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for create is too high. [46.24/15]
Open

  def create
    @volunteer = Volunteer.new(volunteer_params)
    @volunteer.team = "Unassigned"
    if @volunteer.first_name.empty?
      flash[:error] = "Error: Invalid first name."
Severity: Minor
Found in app/controllers/volunteers_controller.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Assignment Branch Condition size for index is too high. [34.71/15]
Open

  def index
    if logged_in?
      @all_status = Volunteer.all_status
      @selected_status = params[:status]
Severity: Minor
Found in app/controllers/volunteers_controller.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [29/10]
Open

  def index
    if logged_in?
      @all_status = Volunteer.all_status
      @selected_status = params[:status]
Severity: Minor
Found in app/controllers/volunteers_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [28/10]
Open

  def create
    @volunteer = Volunteer.new(volunteer_params)
    @volunteer.team = "Unassigned"
    if @volunteer.first_name.empty?
      flash[:error] = "Error: Invalid first name."
Severity: Minor
Found in app/controllers/volunteers_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [23/10]
Open

  def change
    add_column :volunteers, :first_name, :text
    add_column :volunteers, :last_name, :text
    add_column :volunteers, :phone, :text
    add_column :volunteers, :email, :text
Severity: Minor
Found in db/migrate/20160318044527_add_basic_info_to_volunteers.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [19/10]
Open

  def path_to(page_name)
    case page_name

    when /^the home\s?page$/
       '/'
Severity: Minor
Found in features/support/paths.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for change is too high. [23/15]
Open

  def change
    add_column :volunteers, :first_name, :text
    add_column :volunteers, :last_name, :text
    add_column :volunteers, :phone, :text
    add_column :volunteers, :email, :text
Severity: Minor
Found in db/migrate/20160318044527_add_basic_info_to_volunteers.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Assignment Branch Condition size for create is too high. [22.41/15]
Open

  def create
    user = User.find_by(email: params[:session][:email].downcase)
    if user && user.authenticate(params[:session][:password])
      flash[:notice] = "Login successful!"
      # Log the user in and redirect to the user's show page.
Severity: Minor
Found in app/controllers/sessions_controller.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [15/10]
Open

  def create
    # if @user.name.empty?
    #   flash[:notice]
    @user = User.new(user_params)
    if @user.email.empty? or ((@user.email.upcase =~ /^[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,}$/) != 0)
Severity: Minor
Found in app/controllers/users_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Perceived complexity for create is too high. [11/7]
Open

  def create
    @volunteer = Volunteer.new(volunteer_params)
    @volunteer.team = "Unassigned"
    if @volunteer.first_name.empty?
      flash[:error] = "Error: Invalid first name."
Severity: Minor
Found in app/controllers/volunteers_controller.rb by rubocop

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Assignment Branch Condition size for create is too high. [19.82/15]
Open

  def create
    # if @user.name.empty?
    #   flash[:notice]
    @user = User.new(user_params)
    if @user.email.empty? or ((@user.email.upcase =~ /^[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,}$/) != 0)
Severity: Minor
Found in app/controllers/users_controller.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Cyclomatic complexity for create is too high. [9/6]
Open

  def create
    @volunteer = Volunteer.new(volunteer_params)
    @volunteer.team = "Unassigned"
    if @volunteer.first_name.empty?
      flash[:error] = "Error: Invalid first name."
Severity: Minor
Found in app/controllers/volunteers_controller.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Perceived complexity for index is too high. [10/7]
Open

  def index
    if logged_in?
      @all_status = Volunteer.all_status
      @selected_status = params[:status]
Severity: Minor
Found in app/controllers/volunteers_controller.rb by rubocop

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Method has too many lines. [13/10]
Open

  def update
    if logged_in?
      respond_to do |format|
        if @volunteer.update(volunteer_params)
          format.html { redirect_to @volunteer, notice: 'Volunteer was successfully updated.' }
Severity: Minor
Found in app/controllers/volunteers_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Cyclomatic complexity for index is too high. [8/6]
Open

  def index
    if logged_in?
      @all_status = Volunteer.all_status
      @selected_status = params[:status]
Severity: Minor
Found in app/controllers/volunteers_controller.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method has too many lines. [11/10]
Open

  def edit
    if logged_in?
      @teams = Volunteer.teams
      @states = Volunteer.all_states
      @statuses = Volunteer.status_volunteer
Severity: Minor
Found in app/controllers/volunteers_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [11/10]
Open

  def create
    user = User.find_by(email: params[:session][:email].downcase)
    if user && user.authenticate(params[:session][:password])
      flash[:notice] = "Login successful!"
      # Log the user in and redirect to the user's show page.
Severity: Minor
Found in app/controllers/sessions_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for update is too high. [15.13/15]
Open

  def update
    if logged_in?
      respond_to do |format|
        if @volunteer.update(volunteer_params)
          format.html { redirect_to @volunteer, notice: 'Volunteer was successfully updated.' }
Severity: Minor
Found in app/controllers/volunteers_controller.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method create has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

  def create
    @volunteer = Volunteer.new(volunteer_params)
    @volunteer.team = "Unassigned"
    if @volunteer.first_name.empty?
      flash[:error] = "Error: Invalid first name."
Severity: Minor
Found in app/controllers/volunteers_controller.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language