casey-chow/tigertrade

View on GitHub
server/listings.go

Summary

Maintainability
C
1 day
Test Coverage

Function ReadListings has 64 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func ReadListings(w http.ResponseWriter, r *http.Request, ps httprouter.Params) {
    query := models.NewListingQuery()

    // Get limit from params
    if limit, err := strconv.ParseUint(r.URL.Query().Get("limit"), 10, 64); err == nil && limit != 0 {
Severity: Minor
Found in server/listings.go - About 1 hr to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    func UpdateListing(w http.ResponseWriter, r *http.Request, ps httprouter.Params) {
        // Get ID from params
        id := ps.ByName("id")
    
        // Get listing to add from request body
    Severity: Major
    Found in server/listings.go and 2 other locations - About 3 hrs to fix
    server/savedsearches.go on lines 105..135
    server/seeks.go on lines 104..134

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 294.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    func CreateListing(w http.ResponseWriter, r *http.Request, ps httprouter.Params) {
        // Get listing to add from request body
        listing := models.Listing{}
        err := ParseJSONFromBody(r, &listing)
        if err != nil {
    Severity: Major
    Found in server/listings.go and 2 other locations - About 3 hrs to fix
    server/savedsearches.go on lines 72..102
    server/seeks.go on lines 71..101

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 289.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    func DeleteListing(w http.ResponseWriter, r *http.Request, ps httprouter.Params) {
        id := ps.ByName("id")
    
        // Retrieve UserID
        user, err := models.GetUser(db, getUsername(r))
    Severity: Major
    Found in server/listings.go and 2 other locations - About 2 hrs to fix
    server/savedsearches.go on lines 138..158
    server/seeks.go on lines 137..157

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 216.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status