Sign upLogin

cassell/Parm

View on GitHub
Star
src/DataAccessObject.php

Summary

Maintainability
C
1 day
Test Coverage

Function save has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    public function save()
    {
        if (count($this->modifiedColumns) > 0) {

            $sql = array();
Severity: Minor
Found in src/DataAccessObject.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

DataAccessObject has 26 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class DataAccessObject extends Row implements TableInterface
{
    /**
     * Get the ID (Primary Key) of the object
     * @return mixed ID of the record in the database. null if a new record
Severity: Minor
Found in src/DataAccessObject.php - About 3 hrs to fix

    Method save has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function save()
    {
        if (count($this->modifiedColumns) > 0) {

            $sql = array();
    Severity: Minor
    Found in src/DataAccessObject.php - About 1 hr to fix

      Function __construct has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public function __construct(array $row = null, DataAccessObjectFactory $factory = null)
    {
        if ($row == null) {
            $row = static::getDefaultRow();
            $this->isNewObject = true;
      Severity: Minor
      Found in src/DataAccessObject.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          protected function setDatetimeFieldValue($columnName, $mixed)
    {
        if ($mixed instanceof \DateTime) {
            return $this->setFieldValue($columnName, $mixed->format($this->factory->getDatetimeStorageFormat()));
        } elseif (is_int($mixed)) {
      Severity: Major
      Found in src/DataAccessObject.php and 1 other location - About 1 hr to fix
      src/DataAccessObject.php on lines 249..261

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 114.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          protected function setDateFieldValue($columnName, $mixed)
    {
        if ($mixed instanceof \DateTime) {
            return $this->setFieldValue($columnName, $mixed->format($this->factory->getDateStorageFormat()));
        } elseif (is_int($mixed)) {
      Severity: Major
      Found in src/DataAccessObject.php and 1 other location - About 1 hr to fix
      src/DataAccessObject.php on lines 308..320

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 114.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status