Sign upLogin

catarse/catarse.js

View on GitHub
Star
legacy/src/c/std/input-find-location.tsx

Summary

Maintainability
A
3 hrs
Test Coverage

Function view has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    view({ attrs, state } : m.Vnode<InputFindLocationAttrs, InputFindLocationState>) {
        const cities = state.cities
        const searchCities = state.searchCities
        const hasCitiesToDisplay = cities && cities.length > 0
        const onSelect = state.onSelect
Severity: Minor
Found in legacy/src/c/std/input-find-location.tsx - About 1 hr to fix

    Function oninit has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        oninit({ attrs, state } : m.Vnode<InputFindLocationAttrs, InputFindLocationState>) {

        if (attrs.city_id) {
            getCityById(attrs.city_id).then(city => {
                state.selectedCity = city
    Severity: Minor
    Found in legacy/src/c/std/input-find-location.tsx - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                      state.cityInputValue = state.selectedCity && `${state.selectedCity.name} - ${state.selectedCity.state_name}`
      Severity: Minor
      Found in legacy/src/c/std/input-find-location.tsx and 1 other location - About 40 mins to fix
      legacy/src/c/std/input-find-location.tsx on lines 46..46

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  state.cityInputValue = state.selectedCity && `${state.selectedCity.name} - ${state.selectedCity.state_name}`
      Severity: Minor
      Found in legacy/src/c/std/input-find-location.tsx and 1 other location - About 40 mins to fix
      legacy/src/c/std/input-find-location.tsx on lines 27..27

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status