Sign upLogin

catdad/grandma

View on GitHub
Star
lib/forkmaster.js

Summary

Maintainability
D
2 days
Test Coverage
B
89%

Function start has 169 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function start(opts, callback) {
    var threads = opts.threads;
    var ready = 0;
    var workers;
Severity: Major
Found in lib/forkmaster.js - About 6 hrs to fix

    Function start has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
    Open

    function start(opts, callback) {
    var threads = opts.threads;
    var ready = 0;
    var workers;
    Severity: Minor
    Found in lib/forkmaster.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File forkmaster.js has 281 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    var path = require('path');
var child = require('child_process');

var _ = require('lodash');
var async = require('async');
    Severity: Minor
    Found in lib/forkmaster.js - About 2 hrs to fix

      Function createWorkers has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function createWorkers(opts, done) {
    var count = opts.threads;

    // create as many threads as necessary
    var forks = _.times(count, function(id) {
      Severity: Minor
      Found in lib/forkmaster.js - About 1 hr to fix

        Function onDone has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            var onDone = (function() {
        var called = false;

        function callbackAsync() {
            setImmediate(callback);
        Severity: Minor
        Found in lib/forkmaster.js - About 1 hr to fix

          TODO found
          Open

                      // TODO: figure out why async didn't work here
          Severity: Minor
          Found in lib/forkmaster.js by fixme

          TODO found
          Open

                  // TODO this should just be a task event
          Severity: Minor
          Found in lib/forkmaster.js by fixme

          There are no issues that match your filters.

          Category
          Status