Sign upLogin

catdad/grandma

View on GitHub
Star

Showing 64 of 64 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        inputs: ['view', function(results, next) {
            var linesStream = through();
            var jsonStream = through();

            input.on('data', function(chunk) {
Severity: Major
Found in lib/report-html.js and 1 other location - About 6 hrs to fix
lib/report-plot.js on lines 137..160

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 174.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        inputs: ['splitHtml', function(results, next) {
            var linesStream = through();
            var jsonStream = through();

            input.on('data', function(chunk) {
Severity: Major
Found in lib/report-plot.js and 1 other location - About 6 hrs to fix
lib/report-html.js on lines 135..158

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 174.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function start has 169 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function start(opts, callback) {
    var threads = opts.threads;
    var ready = 0;
    var workers;
Severity: Major
Found in lib/forkmaster.js - About 6 hrs to fix

    Function parseArgv has 146 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function parseArgv(defaults) {
    var yargs = require('yargs');

    function setDefaults(argv) {
        _.forEach(defaults || {}, function(val, prop) {
    Severity: Major
    Found in lib/argv.js - About 5 hrs to fix

      Function runAtRate has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
      Open

      function runAtRate(api) {

    var opts = api.options;
    var debug = api.debug;
    var writeOutput = api.writeOutput;
      Severity: Minor
      Found in lib/run-mode-rate.js - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function exports has 118 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = function(opts, done) {
    var REPORT_FILE = 'plot.html';

    var input = opts.input;
    var output = opts.output;
      Severity: Major
      Found in lib/report-plot.js - About 4 hrs to fix

        Function exports has 111 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        module.exports = function(opts, done) {
    var REPORT_FILE = path.resolve(__dirname, '..', 'views', 'html-report', 'html.html');

    var input = opts.input;
    var output = opts.output;
        Severity: Major
        Found in lib/report-html.js - About 4 hrs to fix

          Function runAtRate has 111 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function runAtRate(api) {

    var opts = api.options;
    var debug = api.debug;
    var writeOutput = api.writeOutput;
          Severity: Major
          Found in lib/run-mode-rate.js - About 4 hrs to fix

            Function exports has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
            Open

            module.exports = function(opts, done) {
    var REPORT_FILE = path.resolve(__dirname, '..', 'views', 'html-report', 'html.html');

    var input = opts.input;
    var output = opts.output;
            Severity: Minor
            Found in lib/report-html.js - About 4 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function createChart has 110 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                function createChart() {
        var yUnits;
        var yDivisor;

        function getMax(graph) {
            Severity: Major
            Found in views/html-report/line-graph.js - About 4 hrs to fix

              Function runConcurrently has 100 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function runConcurrently(api) {

    var opts = api.options;
    var writeOutput = api.writeOutput;
    var debug = api.debug;
              Severity: Major
              Found in lib/run-mode-concurrent.js - About 4 hrs to fix

                Function runConcurrently has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
                Open

                function runConcurrently(api) {

    var opts = api.options;
    var writeOutput = api.writeOutput;
    var debug = api.debug;
                Severity: Minor
                Found in lib/run-mode-concurrent.js - About 3 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function taskCreator has 94 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                module.exports = function taskCreator(opts) {
    var mode = opts.mode;
    var paused = false;
    var running = 0;
                Severity: Major
                Found in lib/runner.js - About 3 hrs to fix

                  Function start has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function start(opts, callback) {
    var threads = opts.threads;
    var ready = 0;
    var workers;
                  Severity: Minor
                  Found in lib/forkmaster.js - About 3 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function readJsonStats has 77 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  function readJsonStats(input, done) {

    var latencies = [];
    var metrics = [];
    var header = {};
                  Severity: Major
                  Found in lib/report-json.js - About 3 hrs to fix

                    Function stringifier has 76 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    var stringifier = function(opts) {
    function appendTimeUnit(val) {
        return (+val).toFixed(3) + 'ms';
    }
                    Severity: Major
                    Found in lib/report-diff.js - About 3 hrs to fix

                      File forkmaster.js has 281 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      var path = require('path');
var child = require('child_process');

var _ = require('lodash');
var async = require('async');
                      Severity: Minor
                      Found in lib/forkmaster.js - About 2 hrs to fix

                        Function jsonStats has 66 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        function jsonStats(data) {
    var reports = data.reports;
    var metrics = data.metrics;
    var header = data.header;
    var categories = data.categories;
                        Severity: Major
                        Found in lib/report-json.js - About 2 hrs to fix

                          Function Reporter has 64 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                          function Reporter(repOpts) {

    function endStream(stream) {
        if (!isStream.stdio(stream)) {
            stream.end();
                          Severity: Major
                          Found in lib/report.js - About 2 hrs to fix

                            Function exports has 59 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                            module.exports = function(streams, options, callback) {
    try {
        assertStreams(streams);
        assertOptions(options);
    } catch(e) {
                            Severity: Major
                            Found in lib/report-diff.js - About 2 hrs to fix
                              Severity
                              Category
                              Status
                              Source
                              Language