Sign upLogin

cattr-app/server-application

View on GitHub
Star

Showing 177 of 177 total issues

Avoid too many return statements within this method.
Open

        return false;
Severity: Major
Found in app/Traits/HasRole.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

            return $filter;
    Severity: Major
    Found in app/Helpers/QueryHelper.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return 0;
      Severity: Major
      Found in app/Console/Commands/MakeAdmin.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return 1;
        Severity: Major
        Found in app/Console/Commands/MakeAdmin.php - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return choicesLength < 4 ? 2 : 3;
          Severity: Major
          Found in resources/frontend/core/i18n/pluralizationRules.js - About 30 mins to fix

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                save(data, isNew = false) {
        return axios.post(`users/${isNew ? 'create' : 'edit'}`, data);
    }
            Severity: Major
            Found in resources/frontend/core/modules/Users/services/user.service.js and 3 other locations - About 30 mins to fix
            resources/frontend/core/services/resource/priority.service.js on lines 35..37
            resources/frontend/core/services/resource/status.service.js on lines 35..37
            resources/frontend/core/services/resource/user.service.js on lines 35..37

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Avoid too many return statements within this method.
            Open

                    return true;
            Severity: Major
            Found in app/Helpers/Recaptcha.php - About 30 mins to fix

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                  save(data, isNew = false) {
        return axios.post(`priorities/${isNew ? 'create' : 'edit'}`, data);
    }
              Severity: Major
              Found in resources/frontend/core/services/resource/priority.service.js and 3 other locations - About 30 mins to fix
              resources/frontend/core/modules/Users/services/user.service.js on lines 22..24
              resources/frontend/core/services/resource/status.service.js on lines 35..37
              resources/frontend/core/services/resource/user.service.js on lines 35..37

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Avoid too many return statements within this method.
              Open

                      return $this->_edit($request);
              Severity: Major
              Found in app/Http/Controllers/Api/TaskController.php - About 30 mins to fix

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                    save(data, isNew = false) {
        return axios.post(`statuses/${isNew ? 'create' : 'edit'}`, data);
    }
                Severity: Major
                Found in resources/frontend/core/services/resource/status.service.js and 3 other locations - About 30 mins to fix
                resources/frontend/core/modules/Users/services/user.service.js on lines 22..24
                resources/frontend/core/services/resource/priority.service.js on lines 35..37
                resources/frontend/core/services/resource/user.service.js on lines 35..37

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 45.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Avoid too many return statements within this method.
                Open

                        return true;
                Severity: Major
                Found in app/Helpers/Recaptcha.php - About 30 mins to fix

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                      save(data, isNew = false) {
        return axios.post(`users/${isNew ? 'create' : 'edit'}`, data);
    }
                  Severity: Major
                  Found in resources/frontend/core/services/resource/user.service.js and 3 other locations - About 30 mins to fix
                  resources/frontend/core/modules/Users/services/user.service.js on lines 22..24
                  resources/frontend/core/services/resource/priority.service.js on lines 35..37
                  resources/frontend/core/services/resource/status.service.js on lines 35..37

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 45.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Avoid too many return statements within this method.
                  Open

                          return $this->_create($request);
                  Severity: Major
                  Found in app/Http/Controllers/Api/TaskController.php - About 30 mins to fix

                    Function hasRole has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        final public function hasRole(Role|array $role): bool
    {
        if (is_array($role)) {
            foreach ($role as $e) {
                if ($this->role_id === $e->value) {
                    Severity: Minor
                    Found in app/Traits/HasRole.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function create has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function create(User $user, int $userId, int $taskId, bool $isManual): bool
    {
        $projectId = self::getProjectIdByTaskId($taskId);

        if ($isManual) {
                    Severity: Minor
                    Found in app/Policies/TimeIntervalPolicy.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function edit has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function edit(EditTaskRequest $request): JsonResponse
    {
        Filter::listen(
            Filter::getRequestFilterName(),
            static function (array $requestData) {
                    Severity: Minor
                    Found in app/Http/Controllers/Api/TaskController.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function getAvailableScreenshots has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public static function getAvailableScreenshots(): array
    {
        $service = app()->make(ScreenshotService::class);

        $collection = self::getScreenshotsCollection();
                    Severity: Minor
                    Found in app/Helpers/StorageCleaner.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language