Showing 24 of 24 total issues
Function renderControl has 108 lines of code (exceeds 25 allowed). Consider refactoring. Open
@dom def renderControl = {
<div class="row">
<div class="col s12">
<label>Selected demo</label>
<select local-id="itDemo" onchange={_: Event => selectDemo(Some(demos(itDemo.value.toInt)))}>File ui.scala has 292 lines of code (exceeds 250 allowed). Consider refactoring. Open
/*
The MIT License (MIT)
Copyright (c) 2017 Chris Camel
Function renderContent has 72 lines of code (exceeds 25 allowed). Consider refactoring. Open
@dom def renderContent = {
def handleChange[T: ClassTag](i: HTMLInputElement, to: Var[T]) = {
try{
to match {
case aDouble: Var[Double @unchecked] if classTag[T] == classTag[Double] ⇒ aDouble.value = i.value.toDoubleFile demo.scala has 258 lines of code (exceeds 250 allowed). Consider refactoring. Open
/*
The MIT License (MIT)
Copyright (c) 2017 Chris Camel
Function renderForm has 45 lines of code (exceeds 25 allowed). Consider refactoring. Open
@dom override def renderForm(): Binding[Element] = {
<div>
<div class="col s12">
<div class="col s12">
<label for="lissajous-a">Parameter a for the lissajous curve (Function onMouseMove has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
private def onMouseMove(e: MouseEvent) = {
model.drag.value match {
case Some(drag@Edition(Position(lastx, lasty), action)) ⇒
val (x, y) = (e.clientX.toInt, e.clientY.toInt)
val (dx, dy) = (x - lastx, y - lasty)Function apply has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
def apply(t: Token): CalcModel = {
state match {
case 'accum => t match {
case NoOp() => doNothing()
case Clear() => doClear()Function bodyHeader has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
@dom def bodyHeader: Binding[BindingSeq[Node]] = {
<header>
<a href="https://github.com/ccamel/playground-binding.scala">
<img style="position: absolute; top: 0; right: 0; border: 0;"
src="https://camo.githubusercontent.com/38ef81f8aca64bb9a64448d0d70f1308ef5341ab/68747470733a2f2f73332e616d617a6f6e6177732e636f6d2f6769746875622f726962626f6e732f666f726b6d655f72696768745f6461726b626c75655f3132313632312e706e67"Function header has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
@dom def header = {
<meta charset="UTF-8"/>
<title>{showCase.bind.name}</title>
<link href="http://fonts.googleapis.com/icon?family=Material+Icons|VT323|Cutive+Mono" rel="stylesheet"/>Function render has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
@dom override def render: Binding[Node] = {
<div class="container list">
<p>Virtual list displaying <em>1,000,000</em> elements. You can explore the data with the following means:</p>
<ul class="browser-default">
<li>Move the scrollbar by dragging the mouse</li>Function render has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
@dom def render: Binding[Node] = {
val btns = List(List("7", "8", "9", "+", "C"),
List("4", "5", "6", "-", "MS"),
List("1", "2", "3", "x", "MR"),
List(".", "0", "=", "/", "MC"))Function render has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
@dom override def render: Binding[Node] = {
import View._
implicit def toSvgTags(a: dom.Runtime.TagsAndTags2.type) = scalatags.JsDom.svgTags
<div class="container" style="height:100%">Function apply has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def apply(t: Token): CalcModel = {
state match {
case 'accum => t match {
case NoOp() => doNothing()
case Clear() => doClear()- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Similar blocks of code found in 2 locations. Consider refactoring. Open
case "NW" ⇒
s.x.value += dx
s.y.value += dy
s.w.value += -dx
s.h.value += -dy- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 75.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Constructor has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
x: Var[Int],
y: Var[Int],
w: Var[Int],
h: Var[Int],
selected: Var[Boolean],Similar blocks of code found in 2 locations. Consider refactoring. Open
case Resize(NW) =>
model.x.value += dx
model.y.value += dy
model.w.value += -dx
model.h.value += -dy- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 75.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
("double sinusoid", (x, y, t) => round((128d + 127d * sin(t + x / 4d) + 128d + 127d * sin(t + y / 4d)) / 2).toInt),- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 73.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
("concentric sinusoid", (x, y, t) => round((128d + (127d * sin(t + x / 8.0)) + 128d + (127d * sin(t + y / 4.0)) + 128d + (127d * sin((t + x + y) / 8.0)) + 128d + (127d * sin(t + sqrt(x * x + y * y) / 4d))) / 4d).toInt)- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 73.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Constructor has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
case class MonthlyPayment(monthNb: Int,
payment: Double,
principal: Double,
interrestPayment: Double,
loan: Double)Constructor has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
case class RectShape(x: Var[Int],
y: Var[Int],
w: Var[Int],
h: Var[Int],
label: Var[String]) extends Shape