cea-sec/miasm

View on GitHub

Showing 3,020 of 3,020 total issues

Similar blocks of code found in 16 locations. Consider refactoring.
Open

def kernel32_GlobalFree(jitter):
    ret_ad, _ = jitter.func_args_stdcall(["addr"])
    jitter.func_ret_stdcall(ret_ad, 0)
Severity: Major
Found in miasm/os_dep/win_api_x86_32.py and 15 other locations - About 30 mins to fix
miasm/os_dep/linux_stdlib.py on lines 197..199
miasm/os_dep/win_api_x86_32.py on lines 293..295
miasm/os_dep/win_api_x86_32.py on lines 310..312
miasm/os_dep/win_api_x86_32.py on lines 412..414
miasm/os_dep/win_api_x86_32.py on lines 422..424
miasm/os_dep/win_api_x86_32.py on lines 473..475
miasm/os_dep/win_api_x86_32.py on lines 478..480
miasm/os_dep/win_api_x86_32.py on lines 590..592
miasm/os_dep/win_api_x86_32.py on lines 1348..1350
miasm/os_dep/win_api_x86_32.py on lines 1994..1998
miasm/os_dep/win_api_x86_32.py on lines 2429..2431
miasm/os_dep/win_api_x86_32.py on lines 2556..2558
miasm/os_dep/win_api_x86_32.py on lines 2806..2808
miasm/os_dep/win_api_x86_32.py on lines 2936..2938
miasm/os_dep/win_api_x86_32.py on lines 3006..3008

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 7 locations. Consider refactoring.
Open

                    addr, size = (int(x, 16) for x in buf.read().split(b",", 1))
Severity: Major
Found in miasm/analysis/gdbserver.py and 6 other locations - About 30 mins to fix
miasm/analysis/gdbserver.py on lines 129..129
miasm/analysis/gdbserver.py on lines 168..168
miasm/analysis/gdbserver.py on lines 183..183
miasm/analysis/gdbserver.py on lines 202..202
miasm/analysis/gdbserver.py on lines 214..214
miasm/analysis/gdbserver.py on lines 227..227

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 16 locations. Consider refactoring.
Open

def kernel32_Sleep(jitter):
    ret_ad, _ = jitter.func_args_stdcall(['t'])
    jitter.func_ret_stdcall(ret_ad, 0)
Severity: Major
Found in miasm/os_dep/win_api_x86_32.py and 15 other locations - About 30 mins to fix
miasm/os_dep/linux_stdlib.py on lines 197..199
miasm/os_dep/win_api_x86_32.py on lines 293..295
miasm/os_dep/win_api_x86_32.py on lines 310..312
miasm/os_dep/win_api_x86_32.py on lines 316..318
miasm/os_dep/win_api_x86_32.py on lines 412..414
miasm/os_dep/win_api_x86_32.py on lines 422..424
miasm/os_dep/win_api_x86_32.py on lines 473..475
miasm/os_dep/win_api_x86_32.py on lines 478..480
miasm/os_dep/win_api_x86_32.py on lines 590..592
miasm/os_dep/win_api_x86_32.py on lines 1994..1998
miasm/os_dep/win_api_x86_32.py on lines 2429..2431
miasm/os_dep/win_api_x86_32.py on lines 2556..2558
miasm/os_dep/win_api_x86_32.py on lines 2806..2808
miasm/os_dep/win_api_x86_32.py on lines 2936..2938
miasm/os_dep/win_api_x86_32.py on lines 3006..3008

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

def kernel32_GetCurrentProcess(jitter):
    ret_ad, _ = jitter.func_args_stdcall(0)
    jitter.func_ret_stdcall(ret_ad, winobjs.handle_curprocess)
Severity: Major
Found in miasm/os_dep/win_api_x86_32.py and 5 other locations - About 30 mins to fix
miasm/os_dep/win_api_x86_32.py on lines 321..323
miasm/os_dep/win_api_x86_32.py on lines 336..338
miasm/os_dep/win_api_x86_32.py on lines 374..376
miasm/os_dep/win_api_x86_32.py on lines 457..459
miasm/os_dep/win_api_x86_32.py on lines 1002..1004

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 16 locations. Consider refactoring.
Open

def xxx_free(jitter):
    ret_ad, args = jitter.func_args_systemv(["ptr"])
    jitter.func_ret_systemv(ret_ad, 0)
Severity: Major
Found in miasm/os_dep/linux_stdlib.py and 15 other locations - About 30 mins to fix
miasm/os_dep/win_api_x86_32.py on lines 293..295
miasm/os_dep/win_api_x86_32.py on lines 310..312
miasm/os_dep/win_api_x86_32.py on lines 316..318
miasm/os_dep/win_api_x86_32.py on lines 412..414
miasm/os_dep/win_api_x86_32.py on lines 422..424
miasm/os_dep/win_api_x86_32.py on lines 473..475
miasm/os_dep/win_api_x86_32.py on lines 478..480
miasm/os_dep/win_api_x86_32.py on lines 590..592
miasm/os_dep/win_api_x86_32.py on lines 1348..1350
miasm/os_dep/win_api_x86_32.py on lines 1994..1998
miasm/os_dep/win_api_x86_32.py on lines 2429..2431
miasm/os_dep/win_api_x86_32.py on lines 2556..2558
miasm/os_dep/win_api_x86_32.py on lines 2806..2808
miasm/os_dep/win_api_x86_32.py on lines 2936..2938
miasm/os_dep/win_api_x86_32.py on lines 3006..3008

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 16 locations. Consider refactoring.
Open

def advapi32_CryptDestroyHash(jitter):
    ret_ad, _ = jitter.func_args_stdcall(["hhash"])
    jitter.func_ret_stdcall(ret_ad, 1)
Severity: Major
Found in miasm/os_dep/win_api_x86_32.py and 15 other locations - About 30 mins to fix
miasm/os_dep/linux_stdlib.py on lines 197..199
miasm/os_dep/win_api_x86_32.py on lines 293..295
miasm/os_dep/win_api_x86_32.py on lines 310..312
miasm/os_dep/win_api_x86_32.py on lines 316..318
miasm/os_dep/win_api_x86_32.py on lines 412..414
miasm/os_dep/win_api_x86_32.py on lines 422..424
miasm/os_dep/win_api_x86_32.py on lines 473..475
miasm/os_dep/win_api_x86_32.py on lines 478..480
miasm/os_dep/win_api_x86_32.py on lines 1348..1350
miasm/os_dep/win_api_x86_32.py on lines 1994..1998
miasm/os_dep/win_api_x86_32.py on lines 2429..2431
miasm/os_dep/win_api_x86_32.py on lines 2556..2558
miasm/os_dep/win_api_x86_32.py on lines 2806..2808
miasm/os_dep/win_api_x86_32.py on lines 2936..2938
miasm/os_dep/win_api_x86_32.py on lines 3006..3008

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

def kernel32_IsDebuggerPresent(jitter):
    ret_ad, _ = jitter.func_args_stdcall(0)
    jitter.func_ret_stdcall(ret_ad, winobjs.dbg_present)
Severity: Major
Found in miasm/os_dep/win_api_x86_32.py and 5 other locations - About 30 mins to fix
miasm/os_dep/win_api_x86_32.py on lines 331..333
miasm/os_dep/win_api_x86_32.py on lines 336..338
miasm/os_dep/win_api_x86_32.py on lines 374..376
miasm/os_dep/win_api_x86_32.py on lines 457..459
miasm/os_dep/win_api_x86_32.py on lines 1002..1004

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 16 locations. Consider refactoring.
Open

def user32_BlockInput(jitter):
    ret_ad, _ = jitter.func_args_stdcall(["blockit"])
    jitter.func_ret_stdcall(ret_ad, 1)
Severity: Major
Found in miasm/os_dep/win_api_x86_32.py and 15 other locations - About 30 mins to fix
miasm/os_dep/linux_stdlib.py on lines 197..199
miasm/os_dep/win_api_x86_32.py on lines 293..295
miasm/os_dep/win_api_x86_32.py on lines 310..312
miasm/os_dep/win_api_x86_32.py on lines 316..318
miasm/os_dep/win_api_x86_32.py on lines 412..414
miasm/os_dep/win_api_x86_32.py on lines 422..424
miasm/os_dep/win_api_x86_32.py on lines 473..475
miasm/os_dep/win_api_x86_32.py on lines 590..592
miasm/os_dep/win_api_x86_32.py on lines 1348..1350
miasm/os_dep/win_api_x86_32.py on lines 1994..1998
miasm/os_dep/win_api_x86_32.py on lines 2429..2431
miasm/os_dep/win_api_x86_32.py on lines 2556..2558
miasm/os_dep/win_api_x86_32.py on lines 2806..2808
miasm/os_dep/win_api_x86_32.py on lines 2936..2938
miasm/os_dep/win_api_x86_32.py on lines 3006..3008

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

def kernel32_GetCurrentProcessId(jitter):
    ret_ad, _ = jitter.func_args_stdcall(0)
    jitter.func_ret_stdcall(ret_ad, winobjs.dw_pid_cur)
Severity: Major
Found in miasm/os_dep/win_api_x86_32.py and 5 other locations - About 30 mins to fix
miasm/os_dep/win_api_x86_32.py on lines 321..323
miasm/os_dep/win_api_x86_32.py on lines 331..333
miasm/os_dep/win_api_x86_32.py on lines 374..376
miasm/os_dep/win_api_x86_32.py on lines 457..459
miasm/os_dep/win_api_x86_32.py on lines 1002..1004

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 16 locations. Consider refactoring.
Open

def kernel32_GetPriorityClass(jitter):
    ret_ad, _ = jitter.func_args_stdcall(["hwnd"])
    jitter.func_ret_stdcall(ret_ad, 0)
Severity: Major
Found in miasm/os_dep/win_api_x86_32.py and 15 other locations - About 30 mins to fix
miasm/os_dep/linux_stdlib.py on lines 197..199
miasm/os_dep/win_api_x86_32.py on lines 293..295
miasm/os_dep/win_api_x86_32.py on lines 310..312
miasm/os_dep/win_api_x86_32.py on lines 316..318
miasm/os_dep/win_api_x86_32.py on lines 422..424
miasm/os_dep/win_api_x86_32.py on lines 473..475
miasm/os_dep/win_api_x86_32.py on lines 478..480
miasm/os_dep/win_api_x86_32.py on lines 590..592
miasm/os_dep/win_api_x86_32.py on lines 1348..1350
miasm/os_dep/win_api_x86_32.py on lines 1994..1998
miasm/os_dep/win_api_x86_32.py on lines 2429..2431
miasm/os_dep/win_api_x86_32.py on lines 2556..2558
miasm/os_dep/win_api_x86_32.py on lines 2806..2808
miasm/os_dep/win_api_x86_32.py on lines 2936..2938
miasm/os_dep/win_api_x86_32.py on lines 3006..3008

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 16 locations. Consider refactoring.
Open

def ntdll_RtlFreeUnicodeString(jitter):
    ret_ad, args = jitter.func_args_stdcall(['src'])
    # l1, l2, p_src = struct.unpack('HHI', jitter.vm.get_mem(args.src, 0x8))
    # s = get_win_str_w(jitter, p_src)
    jitter.func_ret_stdcall(ret_ad, 0)
Severity: Major
Found in miasm/os_dep/win_api_x86_32.py and 15 other locations - About 30 mins to fix
miasm/os_dep/linux_stdlib.py on lines 197..199
miasm/os_dep/win_api_x86_32.py on lines 293..295
miasm/os_dep/win_api_x86_32.py on lines 310..312
miasm/os_dep/win_api_x86_32.py on lines 316..318
miasm/os_dep/win_api_x86_32.py on lines 412..414
miasm/os_dep/win_api_x86_32.py on lines 422..424
miasm/os_dep/win_api_x86_32.py on lines 473..475
miasm/os_dep/win_api_x86_32.py on lines 478..480
miasm/os_dep/win_api_x86_32.py on lines 590..592
miasm/os_dep/win_api_x86_32.py on lines 1348..1350
miasm/os_dep/win_api_x86_32.py on lines 2429..2431
miasm/os_dep/win_api_x86_32.py on lines 2556..2558
miasm/os_dep/win_api_x86_32.py on lines 2806..2808
miasm/os_dep/win_api_x86_32.py on lines 2936..2938
miasm/os_dep/win_api_x86_32.py on lines 3006..3008

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 7 locations. Consider refactoring.
Open

                    addr, size = (int(x, 16) for x in buf.read().split(b",", 1))
Severity: Major
Found in miasm/analysis/gdbserver.py and 6 other locations - About 30 mins to fix
miasm/analysis/gdbserver.py on lines 129..129
miasm/analysis/gdbserver.py on lines 158..158
miasm/analysis/gdbserver.py on lines 168..168
miasm/analysis/gdbserver.py on lines 183..183
miasm/analysis/gdbserver.py on lines 214..214
miasm/analysis/gdbserver.py on lines 227..227

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 7 locations. Consider refactoring.
Open

                    addr, size = (int(x, 16) for x in buf.read().split(b",", 1))
Severity: Major
Found in miasm/analysis/gdbserver.py and 6 other locations - About 30 mins to fix
miasm/analysis/gdbserver.py on lines 129..129
miasm/analysis/gdbserver.py on lines 158..158
miasm/analysis/gdbserver.py on lines 168..168
miasm/analysis/gdbserver.py on lines 183..183
miasm/analysis/gdbserver.py on lines 202..202
miasm/analysis/gdbserver.py on lines 214..214

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 16 locations. Consider refactoring.
Open

def kernel32_InitializeCriticalSection(jitter):
    ret_ad, _ = jitter.func_args_stdcall(["lpcritic"])
    jitter.func_ret_stdcall(ret_ad, 0)
Severity: Major
Found in miasm/os_dep/win_api_x86_32.py and 15 other locations - About 30 mins to fix
miasm/os_dep/linux_stdlib.py on lines 197..199
miasm/os_dep/win_api_x86_32.py on lines 293..295
miasm/os_dep/win_api_x86_32.py on lines 310..312
miasm/os_dep/win_api_x86_32.py on lines 316..318
miasm/os_dep/win_api_x86_32.py on lines 412..414
miasm/os_dep/win_api_x86_32.py on lines 422..424
miasm/os_dep/win_api_x86_32.py on lines 473..475
miasm/os_dep/win_api_x86_32.py on lines 478..480
miasm/os_dep/win_api_x86_32.py on lines 590..592
miasm/os_dep/win_api_x86_32.py on lines 1348..1350
miasm/os_dep/win_api_x86_32.py on lines 1994..1998
miasm/os_dep/win_api_x86_32.py on lines 2429..2431
miasm/os_dep/win_api_x86_32.py on lines 2806..2808
miasm/os_dep/win_api_x86_32.py on lines 2936..2938
miasm/os_dep/win_api_x86_32.py on lines 3006..3008

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

            return True
Severity: Major
Found in miasm/core/graph.py - About 30 mins to fix

    Similar blocks of code found in 16 locations. Consider refactoring.
    Open

    def user32_GetTopWindow(jitter):
        ret_ad, _ = jitter.func_args_stdcall(["hwnd"])
        jitter.func_ret_stdcall(ret_ad, 0)
    Severity: Major
    Found in miasm/os_dep/win_api_x86_32.py and 15 other locations - About 30 mins to fix
    miasm/os_dep/linux_stdlib.py on lines 197..199
    miasm/os_dep/win_api_x86_32.py on lines 293..295
    miasm/os_dep/win_api_x86_32.py on lines 310..312
    miasm/os_dep/win_api_x86_32.py on lines 316..318
    miasm/os_dep/win_api_x86_32.py on lines 412..414
    miasm/os_dep/win_api_x86_32.py on lines 422..424
    miasm/os_dep/win_api_x86_32.py on lines 478..480
    miasm/os_dep/win_api_x86_32.py on lines 590..592
    miasm/os_dep/win_api_x86_32.py on lines 1348..1350
    miasm/os_dep/win_api_x86_32.py on lines 1994..1998
    miasm/os_dep/win_api_x86_32.py on lines 2429..2431
    miasm/os_dep/win_api_x86_32.py on lines 2556..2558
    miasm/os_dep/win_api_x86_32.py on lines 2806..2808
    miasm/os_dep/win_api_x86_32.py on lines 2936..2938
    miasm/os_dep/win_api_x86_32.py on lines 3006..3008

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 32.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 16 locations. Consider refactoring.
    Open

    def msvcrt_free(jitter):
        ret_ad, _ = jitter.func_args_cdecl(["ptr"])
        jitter.func_ret_cdecl(ret_ad, 0)
    Severity: Major
    Found in miasm/os_dep/win_api_x86_32.py and 15 other locations - About 30 mins to fix
    miasm/os_dep/linux_stdlib.py on lines 197..199
    miasm/os_dep/win_api_x86_32.py on lines 293..295
    miasm/os_dep/win_api_x86_32.py on lines 310..312
    miasm/os_dep/win_api_x86_32.py on lines 316..318
    miasm/os_dep/win_api_x86_32.py on lines 412..414
    miasm/os_dep/win_api_x86_32.py on lines 422..424
    miasm/os_dep/win_api_x86_32.py on lines 473..475
    miasm/os_dep/win_api_x86_32.py on lines 478..480
    miasm/os_dep/win_api_x86_32.py on lines 590..592
    miasm/os_dep/win_api_x86_32.py on lines 1348..1350
    miasm/os_dep/win_api_x86_32.py on lines 1994..1998
    miasm/os_dep/win_api_x86_32.py on lines 2429..2431
    miasm/os_dep/win_api_x86_32.py on lines 2556..2558
    miasm/os_dep/win_api_x86_32.py on lines 2806..2808
    miasm/os_dep/win_api_x86_32.py on lines 3006..3008

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 32.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid too many return statements within this function.
    Open

            return True
    Severity: Major
    Found in miasm/core/graph.py - About 30 mins to fix

      Identical blocks of code found in 7 locations. Consider refactoring.
      Open

                          addr, size = (int(x, 16) for x in buf.read().split(b",", 1))
      Severity: Major
      Found in miasm/analysis/gdbserver.py and 6 other locations - About 30 mins to fix
      miasm/analysis/gdbserver.py on lines 129..129
      miasm/analysis/gdbserver.py on lines 158..158
      miasm/analysis/gdbserver.py on lines 183..183
      miasm/analysis/gdbserver.py on lines 202..202
      miasm/analysis/gdbserver.py on lines 214..214
      miasm/analysis/gdbserver.py on lines 227..227

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 32.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 16 locations. Consider refactoring.
      Open

      def msvcrt_srand(jitter):
          ret_ad, _ = jitter.func_args_cdecl(['seed'])
          jitter.func_ret_stdcall(ret_ad, 0)
      Severity: Major
      Found in miasm/os_dep/win_api_x86_32.py and 15 other locations - About 30 mins to fix
      miasm/os_dep/linux_stdlib.py on lines 197..199
      miasm/os_dep/win_api_x86_32.py on lines 293..295
      miasm/os_dep/win_api_x86_32.py on lines 310..312
      miasm/os_dep/win_api_x86_32.py on lines 316..318
      miasm/os_dep/win_api_x86_32.py on lines 412..414
      miasm/os_dep/win_api_x86_32.py on lines 422..424
      miasm/os_dep/win_api_x86_32.py on lines 473..475
      miasm/os_dep/win_api_x86_32.py on lines 478..480
      miasm/os_dep/win_api_x86_32.py on lines 590..592
      miasm/os_dep/win_api_x86_32.py on lines 1348..1350
      miasm/os_dep/win_api_x86_32.py on lines 1994..1998
      miasm/os_dep/win_api_x86_32.py on lines 2429..2431
      miasm/os_dep/win_api_x86_32.py on lines 2556..2558
      miasm/os_dep/win_api_x86_32.py on lines 2936..2938
      miasm/os_dep/win_api_x86_32.py on lines 3006..3008

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 32.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language