cea-sec/miasm

View on GitHub
miasm/analysis/gdbserver.py

Summary

Maintainability
D
2 days
Test Coverage

Function process_messages has a Cognitive Complexity of 59 (exceeds 5 allowed). Consider refactoring.
Open

    def process_messages(self):

        while self.recv_queue:
            msg = self.recv_queue.pop(0)
            buf = BytesIO(msg)
Severity: Minor
Found in miasm/analysis/gdbserver.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File gdbserver.py has 347 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#-*- coding:utf-8 -*-

from __future__ import print_function
from future.builtins import map, range

Severity: Minor
Found in miasm/analysis/gdbserver.py - About 4 hrs to fix

    Function read_register_by_name has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        def read_register_by_name(self, reg_name):
            sup_func = super(GdbServer_x86_32, self).read_register_by_name
    
            # Assert EIP on pc jitter
            if reg_name == "EIP":
    Severity: Minor
    Found in miasm/analysis/gdbserver.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function parse_messages has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        def parse_messages(self, data):
            buf = BytesIO(data)
            msgs = []
    
            while (buf.tell() < buf.len):
    Severity: Minor
    Found in miasm/analysis/gdbserver.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        general_registers_size = {
            "EAX": 4,
            "ECX": 4,
            "EDX": 4,
            "EBX": 4,
    Severity: Major
    Found in miasm/analysis/gdbserver.py and 2 other locations - About 1 hr to fix
    miasm/analysis/gdbserver.py on lines 408..424
    miasm/arch/arm/arch.py on lines 2510..2513

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 39.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        general_registers_size = {
            "PC": 2,
            "SP": 2,
            "SR": 2,
            "R3": 2,
    Severity: Major
    Found in miasm/analysis/gdbserver.py and 2 other locations - About 1 hr to fix
    miasm/analysis/gdbserver.py on lines 344..360
    miasm/arch/arm/arch.py on lines 2510..2513

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 39.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 7 locations. Consider refactoring.
    Open

                        addr, size = (int(x, 16) for x in buf.read().split(b",", 1))
    Severity: Major
    Found in miasm/analysis/gdbserver.py and 6 other locations - About 30 mins to fix
    miasm/analysis/gdbserver.py on lines 129..129
    miasm/analysis/gdbserver.py on lines 158..158
    miasm/analysis/gdbserver.py on lines 168..168
    miasm/analysis/gdbserver.py on lines 183..183
    miasm/analysis/gdbserver.py on lines 202..202
    miasm/analysis/gdbserver.py on lines 227..227

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 32.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 7 locations. Consider refactoring.
    Open

                    addr, size = (int(x, 16) for x in buf.read().split(b",", 1))
    Severity: Major
    Found in miasm/analysis/gdbserver.py and 6 other locations - About 30 mins to fix
    miasm/analysis/gdbserver.py on lines 158..158
    miasm/analysis/gdbserver.py on lines 168..168
    miasm/analysis/gdbserver.py on lines 183..183
    miasm/analysis/gdbserver.py on lines 202..202
    miasm/analysis/gdbserver.py on lines 214..214
    miasm/analysis/gdbserver.py on lines 227..227

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 32.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 7 locations. Consider refactoring.
    Open

                        addr, size = (int(x, 16) for x in buf.read().split(b",", 1))
    Severity: Major
    Found in miasm/analysis/gdbserver.py and 6 other locations - About 30 mins to fix
    miasm/analysis/gdbserver.py on lines 129..129
    miasm/analysis/gdbserver.py on lines 158..158
    miasm/analysis/gdbserver.py on lines 168..168
    miasm/analysis/gdbserver.py on lines 202..202
    miasm/analysis/gdbserver.py on lines 214..214
    miasm/analysis/gdbserver.py on lines 227..227

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 32.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 7 locations. Consider refactoring.
    Open

                        addr, size = (int(x, 16) for x in buf.read().split(b",", 1))
    Severity: Major
    Found in miasm/analysis/gdbserver.py and 6 other locations - About 30 mins to fix
    miasm/analysis/gdbserver.py on lines 129..129
    miasm/analysis/gdbserver.py on lines 158..158
    miasm/analysis/gdbserver.py on lines 168..168
    miasm/analysis/gdbserver.py on lines 183..183
    miasm/analysis/gdbserver.py on lines 214..214
    miasm/analysis/gdbserver.py on lines 227..227

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 32.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 7 locations. Consider refactoring.
    Open

                        addr, size = (int(x, 16) for x in buf.read().split(b",", 1))
    Severity: Major
    Found in miasm/analysis/gdbserver.py and 6 other locations - About 30 mins to fix
    miasm/analysis/gdbserver.py on lines 129..129
    miasm/analysis/gdbserver.py on lines 158..158
    miasm/analysis/gdbserver.py on lines 168..168
    miasm/analysis/gdbserver.py on lines 183..183
    miasm/analysis/gdbserver.py on lines 202..202
    miasm/analysis/gdbserver.py on lines 214..214

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 32.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 7 locations. Consider refactoring.
    Open

                        addr, size = (int(x, 16) for x in buf.read().split(b",", 1))
    Severity: Major
    Found in miasm/analysis/gdbserver.py and 6 other locations - About 30 mins to fix
    miasm/analysis/gdbserver.py on lines 129..129
    miasm/analysis/gdbserver.py on lines 168..168
    miasm/analysis/gdbserver.py on lines 183..183
    miasm/analysis/gdbserver.py on lines 202..202
    miasm/analysis/gdbserver.py on lines 214..214
    miasm/analysis/gdbserver.py on lines 227..227

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 32.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 7 locations. Consider refactoring.
    Open

                        addr, size = (int(x, 16) for x in buf.read().split(b",", 1))
    Severity: Major
    Found in miasm/analysis/gdbserver.py and 6 other locations - About 30 mins to fix
    miasm/analysis/gdbserver.py on lines 129..129
    miasm/analysis/gdbserver.py on lines 158..158
    miasm/analysis/gdbserver.py on lines 183..183
    miasm/analysis/gdbserver.py on lines 202..202
    miasm/analysis/gdbserver.py on lines 214..214
    miasm/analysis/gdbserver.py on lines 227..227

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 32.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status