cea-sec/miasm

View on GitHub
miasm/analysis/machine.py

Summary

Maintainability
D
3 days
Test Coverage

Function __init__ has a Cognitive Complexity of 50 (exceeds 5 allowed). Consider refactoring.
Open

    def __init__(self, machine_name):

        dis_engine = None
        mn = None
        lifter_model_call = None
Severity: Minor
Found in miasm/analysis/machine.py - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File machine.py has 252 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#-*- coding:utf-8 -*-
import warnings


class Machine(object):
Severity: Minor
Found in miasm/analysis/machine.py - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            elif machine_name == "msp430":
                from miasm.arch.msp430.disasm import dis_msp430 as dis_engine
                from miasm.arch.msp430 import arch
                try:
                    from miasm.arch.msp430 import jit
    Severity: Major
    Found in miasm/analysis/machine.py and 1 other location - About 1 hr to fix
    miasm/analysis/machine.py on lines 107..120

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            elif machine_name == "x86_32":
                from miasm.arch.x86.disasm import dis_x86_32 as dis_engine
                from miasm.arch.x86 import arch
                try:
                    from miasm.arch.x86 import jit
    Severity: Major
    Found in miasm/analysis/machine.py and 1 other location - About 1 hr to fix
    miasm/analysis/machine.py on lines 133..146

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 11 locations. Consider refactoring.
    Open

            elif machine_name == "mips32l":
                from miasm.arch.mips32.disasm import dis_mips32l as dis_engine
                from miasm.arch.mips32 import arch
                try:
                    from miasm.arch.mips32 import jit
    Severity: Major
    Found in miasm/analysis/machine.py and 10 other locations - About 1 hr to fix
    miasm/analysis/machine.py on lines 32..42
    miasm/analysis/machine.py on lines 43..53
    miasm/analysis/machine.py on lines 54..64
    miasm/analysis/machine.py on lines 65..75
    miasm/analysis/machine.py on lines 96..106
    miasm/analysis/machine.py on lines 122..132
    miasm/analysis/machine.py on lines 148..158
    miasm/analysis/machine.py on lines 170..180
    miasm/analysis/machine.py on lines 181..191
    miasm/analysis/machine.py on lines 192..202

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 38.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 11 locations. Consider refactoring.
    Open

            elif machine_name == "ppc32b":
                from miasm.arch.ppc.disasm import dis_ppc32b as dis_engine
                from miasm.arch.ppc import arch
                try:
                    from miasm.arch.ppc import jit
    Severity: Major
    Found in miasm/analysis/machine.py and 10 other locations - About 1 hr to fix
    miasm/analysis/machine.py on lines 32..42
    miasm/analysis/machine.py on lines 43..53
    miasm/analysis/machine.py on lines 54..64
    miasm/analysis/machine.py on lines 65..75
    miasm/analysis/machine.py on lines 96..106
    miasm/analysis/machine.py on lines 122..132
    miasm/analysis/machine.py on lines 148..158
    miasm/analysis/machine.py on lines 159..169
    miasm/analysis/machine.py on lines 181..191
    miasm/analysis/machine.py on lines 192..202

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 38.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 11 locations. Consider refactoring.
    Open

            elif machine_name == "mips32b":
                from miasm.arch.mips32.disasm import dis_mips32b as dis_engine
                from miasm.arch.mips32 import arch
                try:
                    from miasm.arch.mips32 import jit
    Severity: Major
    Found in miasm/analysis/machine.py and 10 other locations - About 1 hr to fix
    miasm/analysis/machine.py on lines 32..42
    miasm/analysis/machine.py on lines 43..53
    miasm/analysis/machine.py on lines 54..64
    miasm/analysis/machine.py on lines 65..75
    miasm/analysis/machine.py on lines 96..106
    miasm/analysis/machine.py on lines 122..132
    miasm/analysis/machine.py on lines 159..169
    miasm/analysis/machine.py on lines 170..180
    miasm/analysis/machine.py on lines 181..191
    miasm/analysis/machine.py on lines 192..202

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 38.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 11 locations. Consider refactoring.
    Open

            elif machine_name == "mepl":
                from miasm.arch.mep.disasm import dis_mepl as dis_engine
                from miasm.arch.mep import arch
                try:
                    from miasm.arch.mep import jit
    Severity: Major
    Found in miasm/analysis/machine.py and 10 other locations - About 1 hr to fix
    miasm/analysis/machine.py on lines 32..42
    miasm/analysis/machine.py on lines 43..53
    miasm/analysis/machine.py on lines 54..64
    miasm/analysis/machine.py on lines 65..75
    miasm/analysis/machine.py on lines 96..106
    miasm/analysis/machine.py on lines 122..132
    miasm/analysis/machine.py on lines 148..158
    miasm/analysis/machine.py on lines 159..169
    miasm/analysis/machine.py on lines 170..180
    miasm/analysis/machine.py on lines 181..191

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 38.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 11 locations. Consider refactoring.
    Open

            elif machine_name == "x86_64":
                from miasm.arch.x86.disasm import dis_x86_64 as dis_engine
                from miasm.arch.x86 import arch
                try:
                    from miasm.arch.x86 import jit
    Severity: Major
    Found in miasm/analysis/machine.py and 10 other locations - About 1 hr to fix
    miasm/analysis/machine.py on lines 32..42
    miasm/analysis/machine.py on lines 43..53
    miasm/analysis/machine.py on lines 54..64
    miasm/analysis/machine.py on lines 65..75
    miasm/analysis/machine.py on lines 96..106
    miasm/analysis/machine.py on lines 148..158
    miasm/analysis/machine.py on lines 159..169
    miasm/analysis/machine.py on lines 170..180
    miasm/analysis/machine.py on lines 181..191
    miasm/analysis/machine.py on lines 192..202

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 38.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 11 locations. Consider refactoring.
    Open

            elif machine_name == "armb":
                from miasm.arch.arm.disasm import dis_armb as dis_engine
                from miasm.arch.arm import arch
                try:
                    from miasm.arch.arm import jit
    Severity: Major
    Found in miasm/analysis/machine.py and 10 other locations - About 1 hr to fix
    miasm/analysis/machine.py on lines 32..42
    miasm/analysis/machine.py on lines 54..64
    miasm/analysis/machine.py on lines 65..75
    miasm/analysis/machine.py on lines 96..106
    miasm/analysis/machine.py on lines 122..132
    miasm/analysis/machine.py on lines 148..158
    miasm/analysis/machine.py on lines 159..169
    miasm/analysis/machine.py on lines 170..180
    miasm/analysis/machine.py on lines 181..191
    miasm/analysis/machine.py on lines 192..202

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 38.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 11 locations. Consider refactoring.
    Open

            elif machine_name == "aarch64l":
                from miasm.arch.aarch64.disasm import dis_aarch64l as dis_engine
                from miasm.arch.aarch64 import arch
                try:
                    from miasm.arch.aarch64 import jit
    Severity: Major
    Found in miasm/analysis/machine.py and 10 other locations - About 1 hr to fix
    miasm/analysis/machine.py on lines 32..42
    miasm/analysis/machine.py on lines 43..53
    miasm/analysis/machine.py on lines 65..75
    miasm/analysis/machine.py on lines 96..106
    miasm/analysis/machine.py on lines 122..132
    miasm/analysis/machine.py on lines 148..158
    miasm/analysis/machine.py on lines 159..169
    miasm/analysis/machine.py on lines 170..180
    miasm/analysis/machine.py on lines 181..191
    miasm/analysis/machine.py on lines 192..202

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 38.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 11 locations. Consider refactoring.
    Open

            elif machine_name == "x86_16":
                from miasm.arch.x86.disasm import dis_x86_16 as dis_engine
                from miasm.arch.x86 import arch
                try:
                    from miasm.arch.x86 import jit
    Severity: Major
    Found in miasm/analysis/machine.py and 10 other locations - About 1 hr to fix
    miasm/analysis/machine.py on lines 32..42
    miasm/analysis/machine.py on lines 43..53
    miasm/analysis/machine.py on lines 54..64
    miasm/analysis/machine.py on lines 65..75
    miasm/analysis/machine.py on lines 122..132
    miasm/analysis/machine.py on lines 148..158
    miasm/analysis/machine.py on lines 159..169
    miasm/analysis/machine.py on lines 170..180
    miasm/analysis/machine.py on lines 181..191
    miasm/analysis/machine.py on lines 192..202

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 38.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 11 locations. Consider refactoring.
    Open

            if machine_name == "arml":
                from miasm.arch.arm.disasm import dis_arml as dis_engine
                from miasm.arch.arm import arch
                try:
                    from miasm.arch.arm import jit
    Severity: Major
    Found in miasm/analysis/machine.py and 10 other locations - About 1 hr to fix
    miasm/analysis/machine.py on lines 43..53
    miasm/analysis/machine.py on lines 54..64
    miasm/analysis/machine.py on lines 65..75
    miasm/analysis/machine.py on lines 96..106
    miasm/analysis/machine.py on lines 122..132
    miasm/analysis/machine.py on lines 148..158
    miasm/analysis/machine.py on lines 159..169
    miasm/analysis/machine.py on lines 170..180
    miasm/analysis/machine.py on lines 181..191
    miasm/analysis/machine.py on lines 192..202

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 38.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 11 locations. Consider refactoring.
    Open

            elif machine_name == "aarch64b":
                from miasm.arch.aarch64.disasm import dis_aarch64b as dis_engine
                from miasm.arch.aarch64 import arch
                try:
                    from miasm.arch.aarch64 import jit
    Severity: Major
    Found in miasm/analysis/machine.py and 10 other locations - About 1 hr to fix
    miasm/analysis/machine.py on lines 32..42
    miasm/analysis/machine.py on lines 43..53
    miasm/analysis/machine.py on lines 54..64
    miasm/analysis/machine.py on lines 96..106
    miasm/analysis/machine.py on lines 122..132
    miasm/analysis/machine.py on lines 148..158
    miasm/analysis/machine.py on lines 159..169
    miasm/analysis/machine.py on lines 170..180
    miasm/analysis/machine.py on lines 181..191
    miasm/analysis/machine.py on lines 192..202

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 38.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 11 locations. Consider refactoring.
    Open

            elif machine_name == "mepb":
                from miasm.arch.mep.disasm import dis_mepb as dis_engine
                from miasm.arch.mep import arch
                try:
                    from miasm.arch.mep import jit
    Severity: Major
    Found in miasm/analysis/machine.py and 10 other locations - About 1 hr to fix
    miasm/analysis/machine.py on lines 32..42
    miasm/analysis/machine.py on lines 43..53
    miasm/analysis/machine.py on lines 54..64
    miasm/analysis/machine.py on lines 65..75
    miasm/analysis/machine.py on lines 96..106
    miasm/analysis/machine.py on lines 122..132
    miasm/analysis/machine.py on lines 148..158
    miasm/analysis/machine.py on lines 159..169
    miasm/analysis/machine.py on lines 170..180
    miasm/analysis/machine.py on lines 192..202

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 38.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status